Testing PR #3
Closed
Testing PR #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 2.5: [TwigBridge][Trans]set %count% only on transChoice [Debug] throw even in stacking mode to preserve code paths [Debug] preserve modified error level [DomCrawler] Fixed a forgotten case of complex XPath queries bumped Symfony version to 2.4.6 updated VERSION for 2.4.5 updated CHANGELOG for 2.4.5 bumped Symfony version to 2.3.16 updated VERSION for 2.3.15 updated CHANGELOG for 2.3.15
* 2.5: Revert "bug symfony#10894 [HttpKernel] removed absolute paths from the generated container (fabpot)" Revert "bug symfony#10937 [HttpKernel] Fix "absolute path" when we look to the cache directory (BenoitLeveque)" Revert "fixed CS" Revert "bug symfony#10979 Make rootPath part of regex greedy (artursvonda)" Revert "[HttpKernel] simplified some tests" [HttpKernel] simplified some tests Make rootPath part of regex greedy
* 2.5: Revert "bug symfony#10908 [HttpFoundation] implement session locking for PDO (Tobion)"
* 2.5: [Validator] Remove property and method targets from the optional and required constraints. fixed CHANGELOG for 2.5 bumped Symfony version to 2.5.0 updated VERSION for 2.5.0-RC1 updated CHANGELOG for 2.5.0-RC1 [DomCrawler] Fixed charset detection in html5 meta charset tag
…ceptions (nicolas-grekas) This PR was merged into the 2.6-dev branch. Discussion ---------- [Debug] enhanced error messages for uncaught exceptions | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | none Before:  After:  A double-click on the file name switches between short/full path name. Commits ------- ce66442 [Debug] enhanced error messages for uncaught exceptions
…mens-tolboom) This PR was squashed before being merged into the 2.3-dev branch (closes symfony#10980). Discussion ---------- error.html.twig should contain a email value When getting an exception on env PROD it would be nice to have an email to report to. Current code has [email] instead of a value. I'm not sure how to fix this as the email value should come from exception.html.twig ```html <div id="logs"> {% include 'TwigBundle:Exception:logs.html.twig' with { 'logs': logger.logs } only %} </div> ``` Some hints are welcome. Commits ------- 030b8c0 error.html.twig should contain a email value
…efreshUser() (lstrojny) This PR was merged into the 2.6-dev branch. Discussion ---------- [Security] Allow overloading ContextListener::refreshUser() Allow overloading refreshUser() for the use case of doing something special with user providers. | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n.A. | License | MIT | Doc PR | n.A. Commits ------- b67ed43 Allow overloading ContextListener::refreshUser()
…erat Doğan, beratdogan) This PR was squashed before being merged into the 2.6-dev branch (closes symfony#10699). Discussion ---------- [DomCrawler] Added support for slicing nodes | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT There are no easy way to slice nodes in specific range. I created a method using \LimitIterator. Works fine for me. An example using is: ```php $crawler->filter('h1')->slice(5, 10)->each(function ($node, $i) { return $node->text(); }); Commits ------- 1181bdc [DomCrawler] Added support for slicing nodes
…scheme in RequestMatcher symfony#10556 (ProPheT777) This PR was squashed before being merged into the 2.6-dev branch (closes symfony#10667). Discussion ---------- [HttpFoundation] Add a way to match a specific scheme in RequestMatcher symfony#10556 | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#10556 | License | MIT | Doc PR | no Commits ------- 787ae07 [HttpFoundation] Add a way to match a specific scheme in RequestMatcher symfony#10556
This PR was merged into the 2.6-dev branch. Discussion ---------- [SecurityBundle] added acl:set command | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | no | License | MIT | Doc PR | n/a This new command allows to set ACL directly from the command line. This useful to quickly set up an environment and for debugging / maintenance purpose. This PR also includes a functional test system for the ACL component. As an example, it is used to test the `acl:set` command. The provided entity class is not mandatory (tests will still be green without it) but can be useful to test other ACL related things. I can remove it if necessary. The instantiation of the `MaskBuilder` object is done in a separate method to be easily overridable to use a custom one (e.g. the SonataAdmin one). Commits ------- a702124 [SecurityBundle] added acl:set command
Previously, the parser treated maps ( {} ) the same as sets ( [] ).
Both were returned as PHP associative arrays. Since
these are distinct entities, this can cause considerably problems for
the users, especially when YAML is being serialized into another
format such as JSON.
This commit allows the user to enable object-map support via a third
parameter on the Parse method. It defaults to `false`, which means
that this commit does not break backwards compatibility.
If the user enables object-map support, maps are represented
by stdClass() objects. Sets remain as arrays.
…al, nicolas-grekas) This PR was merged into the 2.5-dev branch. Discussion ---------- [YAML] Added support for object-maps | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | NA | License | MIT | Doc PR | NA Proposal for symfony#10114 Commits ------- 0cee604 [Yaml] Cleanups for object maps e2d5468 [Yaml] Added support for object maps
This PR was squashed before being merged into the 2.3-dev branch (closes symfony#10851). Discussion ---------- Added retrieval of sections | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#10145 | License | MIT Commits ------- 7928767 Added retrieval of sections
…s into search form (stloyd) This PR was merged into the 2.6-dev branch. Discussion ---------- [RFC][WebProfilerBundle] Add simple placeholders into search form This is an RFC mostly, it's not a real feature, it's more like little helper for the profiler form, I guess that would mostly useful for _newcomers_, but sometimes even _old dogs_ could find it useful sometimes =) | Q | A | ------------- | --- | Bug fix? | no | New feature? | kinda | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT  Commits ------- be65226 [WebProfilerBundle] Add simple placeholders into search form
…ata (maryo) This PR was squashed before being merged into the 2.6-dev branch (closes symfony#10427). Discussion ---------- Username in UsernameNotFoundException message data | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Added username in UsernameNotFoundException message data Commits ------- 3dfaa19 Username in UsernameNotFoundException message data
This allows the translator and its extensions to be garbage collected based on the refcount rather than requiring the garbage collector run, making it much more likely to happen at the end of the CssSelector::toXPath call.
This PR was merged into the 2.6-dev branch. Discussion ---------- [Validator] Added missing Czech translation | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 8fe71a9 [Validator] Added missing Czech translation
…the circular object graph (stof) This PR was merged into the 2.3 branch. Discussion ---------- [CssSelector] Refactored the CssSelector to remove the circular object graph | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#10879, replaces symfony#11221 | License | MIT | Doc PR | n/a This allows the translator and its extensions to be garbage collected based on the refcount rather than requiring the garbage collector run, making it much more likely to happen at the end of the ``CssSelector::toXPath`` call. Node translators now receive the Translator as second argument, instead of requiring to inject it in the extension to keep a reference to it. This way, the Translator is referenced nowhere inside it, only by the caller, and so will be destructed at the end of the usage (and extensions will then be destructed after it when not used anymore). Commits ------- 994f81f Refactored the CssSelector to remove the circular object graph
…alidation (stloyd) This PR was merged into the 2.6-dev branch. Discussion ---------- [Validator] Polish translation for "empty file" validation Commits ------- 7212d0e [Validator] Polish translation for "empty file" validation
…s278) This PR was squashed before being merged into the 2.3 branch (closes symfony#11179). Discussion ---------- [Process] Fix ExecutableFinder with open basedir | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This fixes the `ExecutableFinder` object to properly fetch the `open_basedir` setting, also added a bunch of tests for the `find()` method. Commits ------- b8f8c0e [Process] Fix ExecutableFinder with open basedir
This PR was merged into the 2.3 branch. Discussion ---------- [ClassLoader] fixed PHP warning on PHP 5.3 | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- 7b2e3d9 [ClassLoader] fixed PHP warning on PHP 5.3
usage. Applied CS patch.
…bxml_disable_entity_loader usage (ccorliss) This PR was submitted for the 2.4 branch but it was merged into the 2.3 branch instead (closes symfony#11259). Discussion ---------- [Config] Fixed failed config schema loads due to libxml_disable_entity_loader usage | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#11258 | License | MIT | Doc PR | N/A PR symfony#10493 helped this issue, but it can still affect users that: 1. Have libxml_disable_entity_loader set to true by default. 2. Experience libxml_disable_entity_loader php bug https://bugs.php.net/bug.php?id=64938 I used the same approach used in the DI xml validation. https://github.com/symfony/symfony/blob/master/src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php#L452 Commits ------- de2bef5 Fixed failed config schema loads due to libxml_disable_entity_loader usage.
* 2.3: Fixed failed config schema loads due to libxml_disable_entity_loader usage. enabled PHP 5.6 for tests [Process] Fix ExecutableFinder with open basedir Refactored the CssSelector to remove the circular object graph Fix mocks to support >=5.5.14 and >=5.4.30 [ClassLoader] fixed PHP warning on PHP 5.3 [Components][Serializer] optional constructor arguments can be omitted during the denormalization process [DomCrawler] properly handle buttons with single and double quotes inside the name attribute Conflicts: src/Symfony/Component/Serializer/Tests/Normalizer/GetSetMethodNormalizerTest.php
* 2.4: Fixed failed config schema loads due to libxml_disable_entity_loader usage. enabled PHP 5.6 for tests [Process] Fix ExecutableFinder with open basedir Refactored the CssSelector to remove the circular object graph Fix mocks to support >=5.5.14 and >=5.4.30 [ClassLoader] fixed PHP warning on PHP 5.3 [Validator] added Lithuanian translation for empty file Added missing dutch translations [Components][Serializer] optional constructor arguments can be omitted during the denormalization process [DomCrawler] properly handle buttons with single and double quotes inside the name attribute Added missing pt and pt_BR translations
* 2.5: Fixed failed config schema loads due to libxml_disable_entity_loader usage. enabled PHP 5.6 for tests [Process] Fix ExecutableFinder with open basedir Refactored the CssSelector to remove the circular object graph Fix mocks to support >=5.5.14 and >=5.4.30 [ClassLoader] fixed PHP warning on PHP 5.3 [Validator] added Lithuanian translation for empty file Added missing dutch translations [Components][Serializer] optional constructor arguments can be omitted during the denormalization process [DomCrawler] properly handle buttons with single and double quotes inside the name attribute Added missing pt and pt_BR translations Conflicts: src/Symfony/Component/Validator/Resources/translations/validators.nl.xlf
…hitespaces (florianv) This PR was merged into the 2.6-dev branch. Discussion ---------- [Serializer] Added a test for decoding xml with whitespaces | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | The PR symfony@466a3d7 introduced a BC break because white spaces were previously decoded as text nodes. So this PR reverts it and adds a context option to configure it. Commits ------- f5bf45e [Serializer] Added a test for decoding xml with whitespaces
…o see the error template
This *only* shows the "Render True Error Page" if the request is GET. Additionally, it keeps the original query parameters in tact
weaverryan
pushed a commit
that referenced
this pull request
Dec 1, 2015
…eprecation on-demand (nicolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [Bridge\PhpUnit] Display the stack trace of a deprecation on-demand | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This PR has been essential into making symfony#16708, and I think everyone working on a 3.0 migration will need this. Example: ``` $ SYMFONY_DEPRECATIONS_HELPER=/FormExtensionBootstrap3LayoutTest/ ./phpunit src/Symfony/Bridge/Twig/ PHPUnit 4.8.18 by Sebastian Bergmann and contributors. Testing src/Symfony/Bridge/Twig/ ................................................ Remaining deprecation triggered by Symfony\Bridge\Twig\Tests\Extension\FormExtensionBootstrap3LayoutTest::testSingleChoiceGrouped: The value "false" for the "choices_as_values" option is deprecated since version 2.8 and will not be supported anymore in 3.0. Set this option to "true" and flip the contents of the "choices" option instead. Stack trace: #0 src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php(286): trigger_error() #1 src/Symfony/Component/OptionsResolver/OptionsResolver.php(962): Symfony\Component\Form\Extension\Core\Type\ChoiceType->Symfony\Component\Form\Extension\Core\Type\{closure}() #2 src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php(277): Symfony\Component\OptionsResolver\OptionsResolver->offsetGet() #3 src/Symfony/Component/OptionsResolver/OptionsResolver.php(962): Symfony\Component\Form\Extension\Core\Type\ChoiceType->Symfony\Component\Form\Extension\Core\Type\{closure}() #4 src/Symfony/Component/OptionsResolver/OptionsResolver.php(791): Symfony\Component\OptionsResolver\OptionsResolver->offsetGet() #5 src/Symfony/Component/Form/ResolvedFormType.php(156): Symfony\Component\OptionsResolver\OptionsResolver->resolve() #6 src/Symfony/Component/Form/FormFactory.php(119): Symfony\Component\Form\ResolvedFormType->createBuilder() #7 src/Symfony/Component/Form/FormFactory.php(48): Symfony\Component\Form\FormFactory->createNamedBuilder() #8 src/Symfony/Component/Form/Tests/AbstractBootstrap3LayoutTest.php(540): Symfony\Component\Form\FormFactory->createNamed() symfony#9 [internal function]: Symfony\Component\Form\Tests\AbstractBootstrap3LayoutTest->testSingleChoiceGrouped() symfony#10 {main} KO src/Symfony/Bridge/Twig/ ``` Commits ------- 5a88fb6 [Bridge\PhpUnit] Display the stack trace of a deprecation on-demand
|
Hi there! Thank you for your contribution! I've auto-labeled Anyone is welcome to change the status of this pull request Status: Needs Review Cheers! |
|
Looks like carson has reacted to its own comment :) |
|
... he's growing more powerful... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing PR