Thanks to visit codestin.com
Credit goes to github.com

Skip to content

RFC remove some of our examples #27151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lorentzenchr opened this issue Aug 24, 2023 · 14 comments
Open

RFC remove some of our examples #27151

lorentzenchr opened this issue Aug 24, 2023 · 14 comments

Comments

@lorentzenchr
Copy link
Member

lorentzenchr commented Aug 24, 2023

TLDR: I think we have too many examples, in particular in

On top, several examples don't render a plot in the gallery, e.g. Release Highlights 1.0.0.

I would like to discuss how we can improve this situation. My main worry is that, currently, a user does not find what she/he is looking for but gets overwhelmed by the sheer amount of examples.

Edit: See task list in #27151 (comment).

@github-actions github-actions bot added the Needs Triage Issue requires triage label Aug 24, 2023
@lorentzenchr lorentzenchr added Documentation RFC and removed Needs Triage Issue requires triage labels Aug 24, 2023
@adrinjalali
Copy link
Member

As a part of #26927 we're also removing some examples or improving them when needed.

@glemaitre
Copy link
Member

ping @ArturoAmorQ who is interested in this topic and might already have looked at aggregating some info.

+1 on removing examples then. We already have a way to redirect HTML pages as well.

@adrinjalali
Copy link
Member

@glemaitre as I mentioned also in #27108 (comment) , I'm not sure how much we should care about the redirections. I'd be totally okay with giving 404, especially since the only way users could get that 404 would be if they changed the URL manually. We don't provide any way for users to see the same page in a different version, and caring about a good redirect is making it really hard to remove examples.

@saldanhad
Copy link
Contributor

saldanhad commented Sep 15, 2024

Hi @lorentzenchr,

I would like to work on clustering examples, having reviewed, my observations and proposed changes are as follows:

Could you advise if these would suffice or there is room to remove more.

(#29937)

@adrinjalali
Copy link
Member

These sound good suggestions @saldanhad

@saldanhad
Copy link
Contributor

Hi @adrinjalali, appreciate your feedback, will submit a PR for these suggested changes soon.

@ArturoAmorQ
Copy link
Member

ArturoAmorQ commented Sep 17, 2024

Here is a non exhaustive list of other examples to be addressed:

Please submit one PR per case.

@yuanx749
Copy link
Contributor

Working on the example Plot randomly generated classification dataset.

@virchan
Copy link
Member

virchan commented Oct 11, 2024

[ ] Train error vs Test error example is really similar to Plotting Validation Curves example.

I'd like to work on this part, if it's available.

Edit: Merged.

@glemaitre
Copy link
Member

@virchan It was merged

@raviteja-ganta
Copy link

@glemaitre @ArturoAmorQ I would like to take Comparison of Calibration of Classifiers and Probability Calibration curves. Can I work on PR?

@adrinjalali
Copy link
Member

adrinjalali commented Feb 17, 2025

Those two examples in particular are pretty nice, not sure if we need to do anything about those ones?

@ArturoAmorQ
Copy link
Member

@raviteja-ganta maybe you can merge Comparison of LDA and PCA 2D projection of Iris dataset and Incremental PCA, which are quite similar.

@raviteja-ganta
Copy link

raviteja-ganta commented Feb 18, 2025

@ArturoAmorQ Looks like both are different. First one tries to compare LDA with PCA while second one(Incremental PCA) tries to compare between PCA and incremental PCA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

8 participants