Conversation
Minor fixes spotted in v1.7 template
Change remaining parameters from camel_case to snakeCase
Fix part of #432
maxulysse
reviewed
Jan 24, 2020
Member
maxulysse
left a comment
There was a problem hiding this comment.
I have a couple of questions and some changes, but looks good
apeltzer
approved these changes
Jan 26, 2020
Member
apeltzer
left a comment
There was a problem hiding this comment.
I think this is good to go! Monday release is better than fixing things on Friday alone ;-)
CI Tests: Force package version to be dev
Template: Fix ANSI codes in summary log messages
GitHub Actions: add TODO statement to encourage customisation
Fix a couple of things in CHANGELOG
maxulysse
reviewed
Jan 27, 2020
| nextflow run {{ cookiecutter.name }} -profile test,<docker/singularity/conda/institute> | ||
| ``` | ||
|
|
||
| > Please check [nf-core/configs](https://github.com/nf-core/configs#documentation) to see if a custom config file to run nf-core pipelines already exists for your Institute. If so, you can simply use `-profile institute` in your command. This will enable either `docker` or `singularity` and set the appropriate execution settings for your local compute environment. |
Member
Author
There was a problem hiding this comment.
Yes, good point 👍 I wrote that 😅 but the explanation beforehand hopefully makes that clearer whereas we cant put that in the parameter section...
Maybe you can update both of those in the next release?
maxulysse
reviewed
Jan 27, 2020
Member
maxulysse
left a comment
There was a problem hiding this comment.
Apart this -profile institute that I think needs to be consistent, I'm OK with this PR
maxulysse
approved these changes
Jan 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many thanks to contributing to nf-core/tools!
Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).
PR checklist
docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: https://github.com/nf-core/tools/tree/master/.github/CONTRIBUTING.md