-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
[MRG] 0.18.1 backports #7672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[MRG] 0.18.1 backports #7672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not provided (scikit-learn#7301) * fix min_weight_fraction_leaf when sample_weights is None * fix flake8 error * remove added newline and unnecessary assignment * remove max bc it's implemented in cython and add interaction test * edit weight calculation formula and add test to check equality * remove test that sees if two parameter build the same tree * reword min_weight_fraction_leaf docstring * clarify uniform weight in forest docstrings * update docstrings for all classes * add what's new entry * move whatsnew entry to bug fixes and explain previous behavior # Conflicts: # doc/whats_new.rst
Not to use hasattr.
* Link to SAG paper updated link to SAG paper in `References` section updated (scikit-learn#7512). * Link to SAG paper updated dead link of SAG paper in Logistic Regression user guide updated. resolves scikit-learn#7512 * SAG paper cited in docstring SAG paper cited in `Reference` section of docstring(scikit-learn#7512).
* minor edits to multiclass documentation * minor text formatting and language modifications * minor word changes, sentence clarifications * attempt to fix ci test * restored previous paragraph * minor grammatical correction * minor grammar fixes
add missing ' in RandomizedSearchCV docs
Fix for proper rendering
# Conflicts: # doc/whats_new.rst
…g for labels. (scikit-learn#7315) * refer users to the other encoders to do one hot encoding for labels. * added to the 'see more' for labelbinarizer, multilabelbinarizer, and labelencoder' as well as an example to multilabel binarizer * added note about y labels to the OneHotEncoder docstring * removed example from MultiLabelBinarizer * documentation should specify LabelBinarizer, not MultiLabelBinarizer in OHE
Run test if dataset has already been downloaded rather than always skipping it
…ikit-learn#7560) * Fixed search not expanding page * Changed the comment to warn users why not to leave fixed height on header
…ikit-learn#7330) * fix batch * add test for eval_MSE
…t_predict (scikit-learn#7585) * BUGFIX Calling fit_transform instead of transform in Pipeline's fit_predict (scikit-learn#7558) * PEP8 fixes in test_fit_predict_on_pipeline * Added comment explaining separate estimators for pipeline in test_fit_predict_on_pipeline
…earn#7519) * DOC add info to conventions for multi-label fitting * DOC move to multilabel section and small edits * DOC clean multilabel examples and clean information * DOC fix line lengths for multiclass
…r testing since the nose project web site suggests new projects should consider using Nose2, or py.test?
* mini-batch can now contain less number of classes than actual data * added tests where mini batches doesn't contain all classes
* Fix funding and website. * Update images and fix typos. * Fix images problem.
…CV (scikit-learn#7799) * label binarizer not used consistently in CalibratedClassifierCV * changed position of classes argument to make old tests run * moved parameter to constructor and added test * added test where train set doesnt have all classes * CalibratedClassifierCV can now handle cases where train set doesnt contain all labels * fixing flake error * fixing line lengths * removing np.full() * from __future__ import division for py2.7 * change is test file * added an extra test and removed a test with Ridge * stronger test * whats new entry
* DOC adding :user: role to whats_new * DOC correcting the improper username * DOC adding exceptions for ImportError in sphinx_issues.py * DOC added import for split_explicit_title * DOC reverting to the old format for core devs * DOC reverting changes for more users * DOC removing extra lines and blank lines * DOC Adding missing link target for user * DOC fixing more links * DOC adding missing links for new contributions * DOC adding space before brackets in the user links * DOC reverting a wrong change * DOC adding final changes
…sionTreeClassifier and DecisionTreeRegressor (scikit-learn#7824) * DOC adding separate fit() functions * DOC adding keywords to arguments of super() * DOC removing trailing whitespaces * DOC specifying the type of class labels * DOC removing docstring from BaseDecisionTree.fit
* Fixed cloning ``estimator`` again when calling fit a second time in SelectFromModel * fix link in whatsnew
…cikit-learn#5874) * TST if LogisticRegressionCV handles string labels properly * TST Add a test with class_weight dict * ENH Encode y and class_weight dict * Better variable names * TYPO casses --> classes * FIX Use dict comprehension; classes_labels --> classes * Revert dict comprehension (for Python 2.6 compat) * MNT reorder validation to improve clarity * Add whatsnew entry
# Conflicts: # doc/whats_new.rst
…cikit-learn#7553) * Add test for __dict__ for estimator checks check that "predict", "transform", "decision_function" or "predict_proba" methods do not change the state of __dict__ of any estimator see scikit-learn#7297 * Add a test to test_check_estimator that shows that check_estimator fails on an estimator that violates this * Fixed bug where NMF's n_iter_ attribute was set by calls to transform
@jnothman @agramfort @GaelVaroquaux @ogrisel this is the final state for 0.18.1 |
looking at tests now |
I'm not gonna change the pep8 in the setup for this, I think. If it runs through now I'll release tomorrow. |
merged manually as I didn't wanna squash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update of the 0.18.X branch with what I want to backport for 0.18.1.
It includes bugfixes and documentation changes.
It actually includes most changes from master, apart from some minor additions and API changes.
ping @jnothman @ogrisel @GaelVaroquaux.
There will be more in 0.18.X that hasn't been merged to master, see https://github.com/scikit-learn/scikit-learn/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.18.1