Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@leonwanghui
Copy link
Collaborator

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

rhsakarpos and others added 30 commits May 8, 2019 16:08
Shrink size of hotpot binary files
POST API to collect metrics and send to registered adapters
Fixed printing bug, make the summary info printing more limpid
Uniform naming access protocol
* load configuration URLs for Grafana and Alert manager

* regenerate mocks

* updated response JSON after discussing with Anvith
Add opensds controller api spec validation
Shruthi-1MN and others added 20 commits May 29, 2019 20:17
* metric unit change for utilization

* test script changes for unit change
Add fileshare controller unit test cases for create/delete fileshare and create/delete filesharesnapshots
* file share and acl cli

* Modify the Metadata display format

* Modify the keys to be displayed by cli

* Modify the code based on the review
* add metrics driver for huawei osceanStor

* Fix commented issue, and optimize some code
* Adding profile to CreateFileShareAcl and snapshot issue

* Dock and controller code for deleteaccess api
Move exporters under contrib folder
Patch 799 - Create file share fails because of no availability pool
NFS Driver FileshareAcl AccessTo is limited to one user
@leonwanghui leonwanghui added the release it's ONLY related to release preparation label Jun 3, 2019
@leonwanghui leonwanghui self-assigned this Jun 3, 2019
@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@7b68841). Click here to learn what that means.
The diff coverage is 27.41%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #806   +/-   ##
=========================================
  Coverage          ?   31.44%           
=========================================
  Files             ?       82           
  Lines             ?    14928           
  Branches          ?        0           
=========================================
  Hits              ?     4694           
  Misses            ?     9544           
  Partials          ?      690
Impacted Files Coverage Δ
...trib/drivers/huawei/fusionstorage/fusionstorage.go 0% <0%> (ø)
contrib/drivers/filesharedrivers/oceanstor/nfs.go 0% <0%> (ø)
pkg/db/drivers/etcd/etcd.go 28.03% <0%> (ø)
.../drivers/filesharedrivers/oceanstor/oceanclient.go 0% <0%> (ø)
contrib/drivers/huawei/dorado/replication.go 0% <0%> (ø)
contrib/drivers/drivers.go 30.43% <0%> (ø)
contrib/drivers/huawei/fusionstorage/fsclient.go 0% <0%> (ø)
client/client.go 29.09% <0%> (ø)
contrib/drivers/huawei/dorado/metrics.go 0% <0%> (ø)
...ib/drivers/filesharedrivers/oceanstor/oceanstor.go 0% <0%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b68841...dde37a9. Read the comment docs.

@leonwanghui leonwanghui merged commit 221e8fa into master Jun 3, 2019
@skdwriting
Copy link
Collaborator

@leonwanghui @xing-yang @wisererik
Hi All,
Some suggestions for future:

  1. dev to master merge -- always we let each feature owners review mandatory for such PRs
  2. instead of one bulk merge to master we do incremental merge/seperate PRs
    Please share your views.

@xing-yang
Copy link
Collaborator

I actually prefer to get rid of development branch. All changes should be merged to Master directly. Then cut a stable branch from master at release time. After that, we need to cherry-pick each change to stable branch.

Even for each regular PR merge (non release related), we should ask PR author to squash all those merge commits to make commits clean.

Let's start this after Capri release.

@leonwanghui
Copy link
Collaborator Author

I agree with @skdwriting and @xing-yang, the initial thought why we split development branch is because we want to make our master branch is always stable so any code change would not impact master branch which is exposed to end users. But since we have published several stable releases (v0.5.3 up to now), we can be ok to remove it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release it's ONLY related to release preparation

Projects

None yet

Development

Successfully merging this pull request may close these issues.