Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove unnecessary Material import from cupertino/slider_test.dart#180957

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
nathannewyen:fix/remove-material-import-cupertino-slider
Feb 3, 2026
Merged

Remove unnecessary Material import from cupertino/slider_test.dart#180957
auto-submit[bot] merged 1 commit intoflutter:masterfrom
nathannewyen:fix/remove-material-import-cupertino-slider

Conversation

@nathannewyen
Copy link
Contributor

@nathannewyen nathannewyen commented Jan 14, 2026

Description

Remove unnecessary Material import and Material widget wrappers from cupertino/slider_test.dart.

The CupertinoSlider tests were using Material widget wrappers unnecessarily. CupertinoSlider is a Cupertino widget that doesn't require Material ancestors.

Related Issue

Contributes to #177412

Tests

All 21 tests in slider_test.dart pass after this change.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Jan 14, 2026
gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 14, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the unnecessary Material import and Material widget wrappers from cupertino/slider_test.dart. The changes are clean and improve the tests by removing a dependency that is not required for CupertinoSlider. I've added one comment regarding code formatting that should be applied throughout the file for consistency.

@nathannewyen nathannewyen force-pushed the fix/remove-material-import-cupertino-slider branch from a185d8b to f1afb99 Compare January 15, 2026 19:28
@MitchellGoodwin
Copy link
Contributor

MitchellGoodwin commented Jan 15, 2026

From the failed analyzer:
╔═╡ERROR #1╞════════════════════════════════════════════════════════════════════
║ Huzzah! The following tests in Cupertino no longer contain cross imports!
║ packages/flutter/test/cupertino/slider_test.dart
║ However, they now need to be removed from the
║ knownCupertinoCrossImports list in the script /dev/bots/check_tests_cross_imports.dart.
╚═══════════════════════════════════════════════════════════════════════════════

@nathannewyen
Copy link
Contributor Author

nathannewyen commented Jan 15, 2026

Thanks for pointing that out! I've pushed a fix to remove slider_test.dart from the knownCupertinoCrossImports list in check_tests_cross_imports.dart.

justinmc
justinmc approved these changes Jan 17, 2026
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. I guess these tests were copied from the Material Slider tests, hence the use of the Material widget. Thanks for helping us decouple!

I see there is a CLA failure, have you signed the CLA? https://github.com/flutter/flutter/pull/180957/checks?check_run_id=60534564561

@justinmc justinmc mentioned this pull request Jan 17, 2026
Open
55 tasks
@nathannewyen
Copy link
Contributor Author

nathannewyen commented Jan 18, 2026

@googlebot I signed it!

@MitchellGoodwin
Copy link
Contributor

MitchellGoodwin commented Jan 20, 2026

@nathannewyen looks like the CLA check is failing because Claude is credited as a coauthor of a commit, and that Claude associated email is being flagged as having not signed the CLA. Could you remove that commit and make the change again without Claude getting attached to the commit?

@nathannewyen
Remove unnecessary Material import from cupertino/slider_test.dart
87622bd 
The CupertinoSlider tests were using Material widget wrappers
unnecessarily. CupertinoSlider is a Cupertino widget that doesn't
require Material ancestors.

Also removes slider_test.dart from knownCupertinoCrossImports since
it no longer has cross imports.

Contributes to flutter#177412
@nathannewyen nathannewyen force-pushed the fix/remove-material-import-cupertino-slider branch from 50f2360 to 87622bd Compare February 1, 2026 20:52
@nathannewyen
Copy link
Contributor Author

nathannewyen commented Feb 1, 2026

Fixed! Removed the co-author and squashed the commits.

@victorsanni victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 3, 2026
@auto-submit auto-submit bot added this pull request to the merge queue Feb 3, 2026
@navaronbracke
Copy link
Contributor

navaronbracke commented Feb 3, 2026

@nathannewyen I suppose I should rebase #181634 after this lands? We both did fix this test it seems.

Merged via the queue into flutter:master with commit d50e006 Feb 3, 2026
148 of 149 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 3, 2026
@navaronbracke
Copy link
Contributor

navaronbracke commented Feb 3, 2026

Rebased on top of this one, so no worries

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2026
@engine-flutter-autoroll
d50e00629 Remove unnecessary Material import from cupertino/slider_te…
faa42bc 
…st.dart (flutter/flutter#180957)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2026
@engine-flutter-autoroll
d50e00629 Remove unnecessary Material import from cupertino/slider_te…
8a818d6 
…st.dart (flutter/flutter#180957)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2026
@engine-flutter-autoroll
d50e00629 Remove unnecessary Material import from cupertino/slider_te…
5aa223b 
…st.dart (flutter/flutter#180957)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2026
Merged
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 5, 2026
@engine-flutter-autoroll
Roll Flutter from bf701fefec86 to f916dd6887bf (44 revisions) (#10967)
c197455 
Roll Flutter from bf701fefec86 to f916dd6887bf (44 revisions)

flutter/flutter@bf701fe...f916dd6

2026-02-05 [email protected] Implement macOS wide gamut (Display P3) support (flutter/flutter#181769)
2026-02-04 [email protected] Roll Skia from d23ecfbfdff9 to 8543ce512d5c (3 revisions) (flutter/flutter#181923)
2026-02-04 [email protected] Roll Dart SDK from 8001c99d952b to 8f778ffd318b (3 revisions) (flutter/flutter#181927)
2026-02-04 [email protected] Re-enable AddressSanitizer on the linux_unopt builder (flutter/flutter#181741)
2026-02-04 [email protected] Add exception to log message in ContentSizingFlag.java (flutter/flutter#181813)
2026-02-04 [email protected] Roll pub packages (flutter/flutter#181925)
2026-02-04 [email protected] [flutter_tools] Deprecate web hot reload flag (flutter/flutter#181884)
2026-02-04 [email protected] Marks platform_views_scroll_perf_impeller__timeline_summary unflaky (flutter/flutter#181649)
2026-02-04 [email protected] Roll Dart SDK from 204db085d970 to 8001c99d952b (1 revision) (flutter/flutter#181902)
2026-02-04 [email protected] Roll Skia from f37a22506eb4 to d23ecfbfdff9 (23 revisions) (flutter/flutter#181915)
2026-02-04 [email protected] In the Web codec tests, skip an undecodable image that is used to test a Skia error handling code path. (flutter/flutter#181870)
2026-02-04 [email protected] Roll Packages from 5b1bea8 to 3bddf2c (5 revisions) (flutter/flutter#181918)
2026-02-04 [email protected] Roll Fuchsia Linux SDK from UmQaaNuhkiuE8Dzug... to J2QdLcY2gyt4NP_xV... (flutter/flutter#181893)
2026-02-04 [email protected] Roll Dart SDK from 54322a0b1109 to 204db085d970 (3 revisions) (flutter/flutter#181890)
2026-02-04 [email protected] Cleanup cross imports (flutter/flutter#181807)
2026-02-04 [email protected] [Material] Remove Material import from backdrop_filter_test.dart widget tests (flutter/flutter#181386)
2026-02-04 [email protected] Move CheckedModeBanner tests to material and remove Material import from widgets banner_test (flutter/flutter#181261)
2026-02-04 [email protected] feat: Pass parameters from DropdownMenuFormField to DropDownMenu (flutter/flutter#181373)
2026-02-04 [email protected] Remove `Config complete` log when using `flutter build apk --config-only` (flutter/flutter#181864)
2026-02-04 [email protected] [Impeller] Fix flattening of very large zoomed curves with tiny stroke widths (flutter/flutter#181505)
2026-02-03 [email protected] Propagates Overlay's MediaQueryData to OverlayPortal child (flutter/flutter#181579)
2026-02-03 [email protected] Make sure that an AnimatedScale doesn't crash in 0x0 environment (flutter/flutter#181481)
2026-02-03 [email protected] Roll Dart SDK from 56294a92d5cc to 54322a0b1109 (1 revision) (flutter/flutter#181872)
2026-02-03 [email protected] Fix decorated box (flutter/flutter#179802)
2026-02-03 [email protected] Roll pub packages (flutter/flutter#181871)
2026-02-03 [email protected] Remove Material library dependency from expansible_test.dart (flutter/flutter#181657)
2026-02-03 [email protected] Organize and update fragment shader uniform tests. (flutter/flutter#181822)
2026-02-03 [email protected] fix(web_ui): handle non-invertible matrices in ImageFilter.matrix (flutter/flutter#181742)
2026-02-03 [email protected] Remove unnecessary Material import from cupertino/slider_test.dart (flutter/flutter#180957)
2026-02-03 [email protected] Remove the Flutter.xcframework as a swift dependency (flutter/flutter#181739)
2026-02-03 [email protected] feature: implementation of tooltips in the `_TestWindowingOwner` and minor bugfixes to the multiple windows example app (flutter/flutter#181510)
2026-02-03 [email protected] [Web] Fix flt-platform-view comment (flutter/flutter#181576)
2026-02-03 [email protected] Marks Linux_pixel_7pro android_verified_input_test to be unflaky (flutter/flutter#179120)
2026-02-03 [email protected] Unmark `hybrid_android_views_integration_test` as bringup (flutter/flutter#181628)
2026-02-03 [email protected] Remove material from sliver_tree_test.dart (flutter/flutter#181415)
2026-02-03 [email protected] Make `android_plugin_new_output_dir_test` only build release (flutter/flutter#181677)
2026-02-03 [email protected] Roll customer tests (flutter/flutter#181825)
2026-02-03 [email protected] Add Linux Foundation Health Score badge to README (flutter/flutter#175587)
2026-02-03 [email protected] Remove unused getters on AndroidProject class (flutter/flutter#181860)
2026-02-03 [email protected] Adds batch release doc for flutter/package (flutter/flutter#181676)
2026-02-03 [email protected] [ Tool ] Don't use `globals.platform` in `getFlutterRoot()` (flutter/flutter#181859)
2026-02-03 [email protected] Roll Packages from 837dbbd to 5b1bea8 (10 revisions) (flutter/flutter#181857)
2026-02-03 [email protected] Remove material from basic_test.dart (flutter/flutter#181444)
2026-02-03 [email protected] [ Tool ] Fix regression introduced in flutter/flutter#181421 (flutter/flutter#181826)

If this roll has caused a breakage, revert this CL and stop the roller
...
LongCatIsLooong pushed a commit to LongCatIsLooong/flutter that referenced this pull request Feb 6, 2026
@nathannewyen @LongCatIsLooong
Remove unnecessary Material import from cupertino/slider_test.dart (f…
414d74c 
…lutter#180957)

## Description

Remove unnecessary Material import and Material widget wrappers from
`cupertino/slider_test.dart`.

The CupertinoSlider tests were using `Material` widget wrappers
unnecessarily. CupertinoSlider is a Cupertino widget that doesn't
require Material ancestors.

## Related Issue

Contributes to flutter#177412

## Tests

All 21 tests in `slider_test.dart` pass after this change.
flutter-zl pushed a commit to flutter-zl/flutter that referenced this pull request Feb 10, 2026
@nathannewyen @flutter-zl
Remove unnecessary Material import from cupertino/slider_test.dart (f…
905df4e 
…lutter#180957)

## Description

Remove unnecessary Material import and Material widget wrappers from
`cupertino/slider_test.dart`.

The CupertinoSlider tests were using `Material` widget wrappers
unnecessarily. CupertinoSlider is a Cupertino widget that doesn't
require Material ancestors.

## Related Issue

Contributes to flutter#177412

## Tests

All 21 tests in `slider_test.dart` pass after this change.
rickhohler pushed a commit to rickhohler/flutter that referenced this pull request Feb 19, 2026
@nathannewyen @rickhohler
Remove unnecessary Material import from cupertino/slider_test.dart (f…
3df35cf 
…lutter#180957)

## Description

Remove unnecessary Material import and Material widget wrappers from
`cupertino/slider_test.dart`.

The CupertinoSlider tests were using `Material` widget wrappers
unnecessarily. CupertinoSlider is a Cupertino widget that doesn't
require Material ancestors.

## Related Issue

Contributes to flutter#177412

## Tests

All 21 tests in `slider_test.dart` pass after this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

@victorsanni victorsanni victorsanni approved these changes

@MitchellGoodwin MitchellGoodwin Awaiting requested review from MitchellGoodwin

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

Test cross-imports Review Queue
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nathannewyen @MitchellGoodwin @navaronbracke @justinmc @victorsanni