In the Web codec tests, skip an undecodable image that is used to test a Skia error handling code path.#181870
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom Feb 4, 2026
Conversation
Member
Author
|
cc @fmalita |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Web codec tests in engine/src/flutter/lib/web_ui/test/ui/codecs_test.dart. It adds a condition to skip processing the image file b464333052.jpg, which is an undecodable image used for testing Skia error handling. My feedback focuses on improving code maintainability by replacing the hardcoded filename with a named constant.
Comment on lines
+146
to
+149
| if (testFile == 'b464333052.jpg') { | ||
| // This is an undecodable image used to test a Skia failure code path. | ||
| continue; | ||
| } |
Contributor
There was a problem hiding this comment.
To improve readability and maintainability, consider defining 'b464333052.jpg' as a named constant. Using magic strings directly in conditional logic can make the code harder to understand and update. Extracting it to a constant with a descriptive name would clarify its purpose.
For example:
// At a suitable scope, e.g., top of the function or file.
const String _kUndecodableSkiaTestImage = 'b464333052.jpg';
// ... inside the loop
if (testFile == _kUndecodableSkiaTestImage) {
// ...
}References
- The repository style guide suggests following 'Effective Dart: Style', which recommends preferring constants over magic numbers or strings for better readability and maintainability. (link)
jtmcdole
approved these changes
Feb 3, 2026
…t a Skia error handling code path. A recent Skia change added an invalid image file that tests a decoding failure case (see https://skia.googlesource.com/skia/+/12cb69b2700acfccee52bacf63321800af8c138c) That file should be excluded from the set of Skia image assets used by the Flutter Web codec tests.
6f396dd to
4990871
Compare
Contributor
|
autosubmit label was removed for flutter/flutter/181870, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 5, 2026
…sed to test a Skia error handling code path. (flutter/flutter#181870)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Feb 5, 2026
Roll Flutter from bf701fefec86 to f916dd6887bf (44 revisions) flutter/flutter@bf701fe...f916dd6 2026-02-05 [email protected] Implement macOS wide gamut (Display P3) support (flutter/flutter#181769) 2026-02-04 [email protected] Roll Skia from d23ecfbfdff9 to 8543ce512d5c (3 revisions) (flutter/flutter#181923) 2026-02-04 [email protected] Roll Dart SDK from 8001c99d952b to 8f778ffd318b (3 revisions) (flutter/flutter#181927) 2026-02-04 [email protected] Re-enable AddressSanitizer on the linux_unopt builder (flutter/flutter#181741) 2026-02-04 [email protected] Add exception to log message in ContentSizingFlag.java (flutter/flutter#181813) 2026-02-04 [email protected] Roll pub packages (flutter/flutter#181925) 2026-02-04 [email protected] [flutter_tools] Deprecate web hot reload flag (flutter/flutter#181884) 2026-02-04 [email protected] Marks platform_views_scroll_perf_impeller__timeline_summary unflaky (flutter/flutter#181649) 2026-02-04 [email protected] Roll Dart SDK from 204db085d970 to 8001c99d952b (1 revision) (flutter/flutter#181902) 2026-02-04 [email protected] Roll Skia from f37a22506eb4 to d23ecfbfdff9 (23 revisions) (flutter/flutter#181915) 2026-02-04 [email protected] In the Web codec tests, skip an undecodable image that is used to test a Skia error handling code path. (flutter/flutter#181870) 2026-02-04 [email protected] Roll Packages from 5b1bea8 to 3bddf2c (5 revisions) (flutter/flutter#181918) 2026-02-04 [email protected] Roll Fuchsia Linux SDK from UmQaaNuhkiuE8Dzug... to J2QdLcY2gyt4NP_xV... (flutter/flutter#181893) 2026-02-04 [email protected] Roll Dart SDK from 54322a0b1109 to 204db085d970 (3 revisions) (flutter/flutter#181890) 2026-02-04 [email protected] Cleanup cross imports (flutter/flutter#181807) 2026-02-04 [email protected] [Material] Remove Material import from backdrop_filter_test.dart widget tests (flutter/flutter#181386) 2026-02-04 [email protected] Move CheckedModeBanner tests to material and remove Material import from widgets banner_test (flutter/flutter#181261) 2026-02-04 [email protected] feat: Pass parameters from DropdownMenuFormField to DropDownMenu (flutter/flutter#181373) 2026-02-04 [email protected] Remove `Config complete` log when using `flutter build apk --config-only` (flutter/flutter#181864) 2026-02-04 [email protected] [Impeller] Fix flattening of very large zoomed curves with tiny stroke widths (flutter/flutter#181505) 2026-02-03 [email protected] Propagates Overlay's MediaQueryData to OverlayPortal child (flutter/flutter#181579) 2026-02-03 [email protected] Make sure that an AnimatedScale doesn't crash in 0x0 environment (flutter/flutter#181481) 2026-02-03 [email protected] Roll Dart SDK from 56294a92d5cc to 54322a0b1109 (1 revision) (flutter/flutter#181872) 2026-02-03 [email protected] Fix decorated box (flutter/flutter#179802) 2026-02-03 [email protected] Roll pub packages (flutter/flutter#181871) 2026-02-03 [email protected] Remove Material library dependency from expansible_test.dart (flutter/flutter#181657) 2026-02-03 [email protected] Organize and update fragment shader uniform tests. (flutter/flutter#181822) 2026-02-03 [email protected] fix(web_ui): handle non-invertible matrices in ImageFilter.matrix (flutter/flutter#181742) 2026-02-03 [email protected] Remove unnecessary Material import from cupertino/slider_test.dart (flutter/flutter#180957) 2026-02-03 [email protected] Remove the Flutter.xcframework as a swift dependency (flutter/flutter#181739) 2026-02-03 [email protected] feature: implementation of tooltips in the `_TestWindowingOwner` and minor bugfixes to the multiple windows example app (flutter/flutter#181510) 2026-02-03 [email protected] [Web] Fix flt-platform-view comment (flutter/flutter#181576) 2026-02-03 [email protected] Marks Linux_pixel_7pro android_verified_input_test to be unflaky (flutter/flutter#179120) 2026-02-03 [email protected] Unmark `hybrid_android_views_integration_test` as bringup (flutter/flutter#181628) 2026-02-03 [email protected] Remove material from sliver_tree_test.dart (flutter/flutter#181415) 2026-02-03 [email protected] Make `android_plugin_new_output_dir_test` only build release (flutter/flutter#181677) 2026-02-03 [email protected] Roll customer tests (flutter/flutter#181825) 2026-02-03 [email protected] Add Linux Foundation Health Score badge to README (flutter/flutter#175587) 2026-02-03 [email protected] Remove unused getters on AndroidProject class (flutter/flutter#181860) 2026-02-03 [email protected] Adds batch release doc for flutter/package (flutter/flutter#181676) 2026-02-03 [email protected] [ Tool ] Don't use `globals.platform` in `getFlutterRoot()` (flutter/flutter#181859) 2026-02-03 [email protected] Roll Packages from 837dbbd to 5b1bea8 (10 revisions) (flutter/flutter#181857) 2026-02-03 [email protected] Remove material from basic_test.dart (flutter/flutter#181444) 2026-02-03 [email protected] [ Tool ] Fix regression introduced in flutter/flutter#181421 (flutter/flutter#181826) If this roll has caused a breakage, revert this CL and stop the roller ...
LongCatIsLooong
pushed a commit
to LongCatIsLooong/flutter
that referenced
this pull request
Feb 6, 2026
…t a Skia error handling code path. (flutter#181870) A recent Skia change added an invalid image file that tests a decoding failure case (see https://skia.googlesource.com/skia/+/12cb69b2700acfccee52bacf63321800af8c138c) That file should be excluded from the set of Skia image assets used by the Flutter Web codec tests.
flutter-zl
pushed a commit
to flutter-zl/flutter
that referenced
this pull request
Feb 10, 2026
…t a Skia error handling code path. (flutter#181870) A recent Skia change added an invalid image file that tests a decoding failure case (see https://skia.googlesource.com/skia/+/12cb69b2700acfccee52bacf63321800af8c138c) That file should be excluded from the set of Skia image assets used by the Flutter Web codec tests.
rickhohler
pushed a commit
to rickhohler/flutter
that referenced
this pull request
Feb 19, 2026
…t a Skia error handling code path. (flutter#181870) A recent Skia change added an invalid image file that tests a decoding failure case (see https://skia.googlesource.com/skia/+/12cb69b2700acfccee52bacf63321800af8c138c) That file should be excluded from the set of Skia image assets used by the Flutter Web codec tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent Skia change added an invalid image file that tests a decoding failure case (see https://skia.googlesource.com/skia/+/12cb69b2700acfccee52bacf63321800af8c138c)
That file should be excluded from the set of Skia image assets used by the Flutter Web codec tests.