Remove Material library dependency from expansible_test.dart#181657
Merged
auto-submit[bot] merged 4 commits intoflutter:masterfrom Feb 4, 2026
Merged
Remove Material library dependency from expansible_test.dart#181657auto-submit[bot] merged 4 commits intoflutter:masterfrom
auto-submit[bot] merged 4 commits intoflutter:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a nice refactoring that removes the unnecessary dependency on the Material library from expansible_test.dart by replacing MaterialApp with WidgetsApp. The changes are correct and well-explained in the description, including the adjustments to coordinate assertions. I have one suggestion to further improve the test file's maintainability by reducing code duplication.
victorsanni
reviewed
Jan 29, 2026
a469dd2 to
2ef2259
Compare
Replace MaterialApp with WidgetsApp in expansible_test.dart to avoid unnecessary Material library imports in widgets-layer tests. - Changed import from 'package:flutter/material.dart' to 'package:flutter/widgets.dart' - Replaced MaterialApp(home: ...) with WidgetsApp(builder: ...) - Updated position assertions to account for the absence of Material scaffold padding (y-coordinates adjusted by -34 pixels)
…xpansible_test.dart Replaced 12 occurrences of the verbose tester.pumpWidget(WidgetsApp(...)) pattern with the simpler pumpTestWidget(tester, ...) call. The "Expansible does not crash at zero area" test was left unchanged since it uses Directionality instead of WidgetsApp (for testing zero-size scenarios).
…up in expansible_test.dart
Contributor
Author
|
Hey @navaronbracke @victorsanni can I get a review if you have time please? |
Contributor
navaronbracke
left a comment
There was a problem hiding this comment.
LGTM, but I have to defer to someone else for approval.
victorsanni
approved these changes
Feb 3, 2026
justinmc
approved these changes
Feb 3, 2026
Contributor
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍. Straightforward. Thanks for helping out with this!
Comment on lines
-226
to
+227
| expect(tester.getBottomLeft(find.byType(Placeholder)).dy, 90.08984375); | ||
| expect(tester.getBottomLeft(find.byType(Placeholder)).dy, 56.08984375); |
Contributor
There was a problem hiding this comment.
These numbers changed just due to the switch from MaterialApp to TestWidgetsApp?
Contributor
There was a problem hiding this comment.
Ah I see you explained this above, sounds good.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 4, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 4, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 5, 2026
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Feb 5, 2026
Roll Flutter from bf701fefec86 to f916dd6887bf (44 revisions) flutter/flutter@bf701fe...f916dd6 2026-02-05 [email protected] Implement macOS wide gamut (Display P3) support (flutter/flutter#181769) 2026-02-04 [email protected] Roll Skia from d23ecfbfdff9 to 8543ce512d5c (3 revisions) (flutter/flutter#181923) 2026-02-04 [email protected] Roll Dart SDK from 8001c99d952b to 8f778ffd318b (3 revisions) (flutter/flutter#181927) 2026-02-04 [email protected] Re-enable AddressSanitizer on the linux_unopt builder (flutter/flutter#181741) 2026-02-04 [email protected] Add exception to log message in ContentSizingFlag.java (flutter/flutter#181813) 2026-02-04 [email protected] Roll pub packages (flutter/flutter#181925) 2026-02-04 [email protected] [flutter_tools] Deprecate web hot reload flag (flutter/flutter#181884) 2026-02-04 [email protected] Marks platform_views_scroll_perf_impeller__timeline_summary unflaky (flutter/flutter#181649) 2026-02-04 [email protected] Roll Dart SDK from 204db085d970 to 8001c99d952b (1 revision) (flutter/flutter#181902) 2026-02-04 [email protected] Roll Skia from f37a22506eb4 to d23ecfbfdff9 (23 revisions) (flutter/flutter#181915) 2026-02-04 [email protected] In the Web codec tests, skip an undecodable image that is used to test a Skia error handling code path. (flutter/flutter#181870) 2026-02-04 [email protected] Roll Packages from 5b1bea8 to 3bddf2c (5 revisions) (flutter/flutter#181918) 2026-02-04 [email protected] Roll Fuchsia Linux SDK from UmQaaNuhkiuE8Dzug... to J2QdLcY2gyt4NP_xV... (flutter/flutter#181893) 2026-02-04 [email protected] Roll Dart SDK from 54322a0b1109 to 204db085d970 (3 revisions) (flutter/flutter#181890) 2026-02-04 [email protected] Cleanup cross imports (flutter/flutter#181807) 2026-02-04 [email protected] [Material] Remove Material import from backdrop_filter_test.dart widget tests (flutter/flutter#181386) 2026-02-04 [email protected] Move CheckedModeBanner tests to material and remove Material import from widgets banner_test (flutter/flutter#181261) 2026-02-04 [email protected] feat: Pass parameters from DropdownMenuFormField to DropDownMenu (flutter/flutter#181373) 2026-02-04 [email protected] Remove `Config complete` log when using `flutter build apk --config-only` (flutter/flutter#181864) 2026-02-04 [email protected] [Impeller] Fix flattening of very large zoomed curves with tiny stroke widths (flutter/flutter#181505) 2026-02-03 [email protected] Propagates Overlay's MediaQueryData to OverlayPortal child (flutter/flutter#181579) 2026-02-03 [email protected] Make sure that an AnimatedScale doesn't crash in 0x0 environment (flutter/flutter#181481) 2026-02-03 [email protected] Roll Dart SDK from 56294a92d5cc to 54322a0b1109 (1 revision) (flutter/flutter#181872) 2026-02-03 [email protected] Fix decorated box (flutter/flutter#179802) 2026-02-03 [email protected] Roll pub packages (flutter/flutter#181871) 2026-02-03 [email protected] Remove Material library dependency from expansible_test.dart (flutter/flutter#181657) 2026-02-03 [email protected] Organize and update fragment shader uniform tests. (flutter/flutter#181822) 2026-02-03 [email protected] fix(web_ui): handle non-invertible matrices in ImageFilter.matrix (flutter/flutter#181742) 2026-02-03 [email protected] Remove unnecessary Material import from cupertino/slider_test.dart (flutter/flutter#180957) 2026-02-03 [email protected] Remove the Flutter.xcframework as a swift dependency (flutter/flutter#181739) 2026-02-03 [email protected] feature: implementation of tooltips in the `_TestWindowingOwner` and minor bugfixes to the multiple windows example app (flutter/flutter#181510) 2026-02-03 [email protected] [Web] Fix flt-platform-view comment (flutter/flutter#181576) 2026-02-03 [email protected] Marks Linux_pixel_7pro android_verified_input_test to be unflaky (flutter/flutter#179120) 2026-02-03 [email protected] Unmark `hybrid_android_views_integration_test` as bringup (flutter/flutter#181628) 2026-02-03 [email protected] Remove material from sliver_tree_test.dart (flutter/flutter#181415) 2026-02-03 [email protected] Make `android_plugin_new_output_dir_test` only build release (flutter/flutter#181677) 2026-02-03 [email protected] Roll customer tests (flutter/flutter#181825) 2026-02-03 [email protected] Add Linux Foundation Health Score badge to README (flutter/flutter#175587) 2026-02-03 [email protected] Remove unused getters on AndroidProject class (flutter/flutter#181860) 2026-02-03 [email protected] Adds batch release doc for flutter/package (flutter/flutter#181676) 2026-02-03 [email protected] [ Tool ] Don't use `globals.platform` in `getFlutterRoot()` (flutter/flutter#181859) 2026-02-03 [email protected] Roll Packages from 837dbbd to 5b1bea8 (10 revisions) (flutter/flutter#181857) 2026-02-03 [email protected] Remove material from basic_test.dart (flutter/flutter#181444) 2026-02-03 [email protected] [ Tool ] Fix regression introduced in flutter/flutter#181421 (flutter/flutter#181826) If this roll has caused a breakage, revert this CL and stop the roller ...
LongCatIsLooong
pushed a commit
to LongCatIsLooong/flutter
that referenced
this pull request
Feb 6, 2026
…#181657) This PR removes the unnecessary dependency on the Material library from expansible_test.dart by replacing `MaterialApp` with `WidgetsApp`. Part of flutter#177415 ### Changes 1. **Import change**: Replaced `package:flutter/material.dart` with `package:flutter/widgets.dart` 2. **Widget setup**: Changed from `MaterialApp(home: ...)` to `TestWidgetsApp(home: ...)` - `WidgetsApp` requires either `builder`, `onGenerateRoute`, or `pageRouteBuilder` to be provided If neither builder nor onGenerateRoute are provided, the pageRouteBuilder must be specified so that the default handler will know what kind of PageRoute transition to build. 3. **Updated position assertions**: Since `WidgetsApp` with `builder` doesn't include the default scaffold/status bar padding that `MaterialApp` with `home` provides, the expected y-coordinate values were adjusted by -34 pixels: - `90.08984375` → `56.08984375` - `98.0` → `64.0` - `80.91015625` → `46.91015625` - `48.0` → `14.0` ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
flutter-zl
pushed a commit
to flutter-zl/flutter
that referenced
this pull request
Feb 10, 2026
…#181657) This PR removes the unnecessary dependency on the Material library from expansible_test.dart by replacing `MaterialApp` with `WidgetsApp`. Part of flutter#177415 ### Changes 1. **Import change**: Replaced `package:flutter/material.dart` with `package:flutter/widgets.dart` 2. **Widget setup**: Changed from `MaterialApp(home: ...)` to `TestWidgetsApp(home: ...)` - `WidgetsApp` requires either `builder`, `onGenerateRoute`, or `pageRouteBuilder` to be provided If neither builder nor onGenerateRoute are provided, the pageRouteBuilder must be specified so that the default handler will know what kind of PageRoute transition to build. 3. **Updated position assertions**: Since `WidgetsApp` with `builder` doesn't include the default scaffold/status bar padding that `MaterialApp` with `home` provides, the expected y-coordinate values were adjusted by -34 pixels: - `90.08984375` → `56.08984375` - `98.0` → `64.0` - `80.91015625` → `46.91015625` - `48.0` → `14.0` ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
rickhohler
pushed a commit
to rickhohler/flutter
that referenced
this pull request
Feb 19, 2026
…#181657) This PR removes the unnecessary dependency on the Material library from expansible_test.dart by replacing `MaterialApp` with `WidgetsApp`. Part of flutter#177415 ### Changes 1. **Import change**: Replaced `package:flutter/material.dart` with `package:flutter/widgets.dart` 2. **Widget setup**: Changed from `MaterialApp(home: ...)` to `TestWidgetsApp(home: ...)` - `WidgetsApp` requires either `builder`, `onGenerateRoute`, or `pageRouteBuilder` to be provided If neither builder nor onGenerateRoute are provided, the pageRouteBuilder must be specified so that the default handler will know what kind of PageRoute transition to build. 3. **Updated position assertions**: Since `WidgetsApp` with `builder` doesn't include the default scaffold/status bar padding that `MaterialApp` with `home` provides, the expected y-coordinate values were adjusted by -34 pixels: - `90.08984375` → `56.08984375` - `98.0` → `64.0` - `80.91015625` → `46.91015625` - `48.0` → `14.0` ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the unnecessary dependency on the Material library from expansible_test.dart by replacing
MaterialAppwithWidgetsApp.Part of #177415
Changes
Import change: Replaced
package:flutter/material.dartwithpackage:flutter/widgets.dartWidget setup: Changed from
MaterialApp(home: ...)toTestWidgetsApp(home: ...)WidgetsApprequires eitherbuilder,onGenerateRoute, orpageRouteBuilderto be providedIf neither builder nor onGenerateRoute are provided, the pageRouteBuilder must be specified so that the default handler will know what kind of PageRoute transition to build.
Updated position assertions: Since
WidgetsAppwithbuilderdoesn't include the default scaffold/status bar padding thatMaterialAppwithhomeprovides, the expected y-coordinate values were adjusted by -34 pixels:90.08984375→56.0898437598.0→64.080.91015625→46.9101562548.0→14.0Pre-launch Checklist
///).