Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Roll customer tests#181825

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
loic-sharma:roll_customer_tests_remove_super_editor
Feb 3, 2026
Merged

Roll customer tests#181825
auto-submit[bot] merged 1 commit intoflutter:masterfrom
loic-sharma:roll_customer_tests_remove_super_editor

Conversation

@loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Feb 2, 2026

We need to do a hard breaking change in Flutter that affects package:super_editor: #180436

To workaround the hard breaking change, we will:

  1. Temporarily remove super_editor from Flutter's customer tests: Temporarily disable super_editor tests tests#480
  2. Roll customer tests to the flutter/flutter repo (this PR)
  3. Land the breaking change in Flutter + add a breaking migration guide to the Flutter website
  4. Update super_editor's main branch to handle Flutter's breaking change.
  5. Re-add super_editor to customer tests, using the latest commit from super_editor's main branch.
Why this is necessary...

To fix #161592, we need to pass additional styling information to the web engine.

Historically, we plumb text styling information through TextInputConnection.setStyle(...). However, every time we add a parameter here, it creates a breaking change for super_editor's TextInputConnectionDecorator as it implements TextInputConnection.

To stop this cycle, we will do a one-time breaking change to move to a more extensible pattern:

  1. Add new TextInputStyle class. This will wrap all text input styling properties.
  2. Add new TextInputConnection.updateStyle(TextInputStyle style) method.
  3. Deprecate TextInputConnection.setStyle(...).

This pattern lets us add more text input styling properties without breaking super_editor again.

To handle this breaking change, the following code will need to be added to super_editor's TextInputConnectionDecorator:

  @override
  void updateStyle(TextInputStyle style) => client?.updateStyle(style);

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@loic-sharma loic-sharma requested a review from justinmc February 2, 2026 19:53
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the commit hash in dev/customer_testing/tests.version. This file is used to pin the version of the flutter/tests repository for customer testing. The change updates this pin to a new commit, effectively rolling the customer tests to a new version.

Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 2, 2026
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 2, 2026
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 2, 2026

autosubmit label was removed for flutter/flutter/181825, because - The status or check suite triage has failed. Please fix the issues identified (or deflake) before re-applying this label.

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 3, 2026
@auto-submit auto-submit bot added this pull request to the merge queue Feb 3, 2026
Merged via the queue into flutter:master with commit 0d92c39 Feb 3, 2026
153 of 155 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 3, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2026
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 5, 2026
Roll Flutter from bf701fefec86 to f916dd6887bf (44 revisions)

flutter/flutter@bf701fe...f916dd6

2026-02-05 [email protected] Implement macOS wide gamut (Display P3) support (flutter/flutter#181769)
2026-02-04 [email protected] Roll Skia from d23ecfbfdff9 to 8543ce512d5c (3 revisions) (flutter/flutter#181923)
2026-02-04 [email protected] Roll Dart SDK from 8001c99d952b to 8f778ffd318b (3 revisions) (flutter/flutter#181927)
2026-02-04 [email protected] Re-enable AddressSanitizer on the linux_unopt builder (flutter/flutter#181741)
2026-02-04 [email protected] Add exception to log message in ContentSizingFlag.java (flutter/flutter#181813)
2026-02-04 [email protected] Roll pub packages (flutter/flutter#181925)
2026-02-04 [email protected] [flutter_tools] Deprecate web hot reload flag (flutter/flutter#181884)
2026-02-04 [email protected] Marks platform_views_scroll_perf_impeller__timeline_summary unflaky (flutter/flutter#181649)
2026-02-04 [email protected] Roll Dart SDK from 204db085d970 to 8001c99d952b (1 revision) (flutter/flutter#181902)
2026-02-04 [email protected] Roll Skia from f37a22506eb4 to d23ecfbfdff9 (23 revisions) (flutter/flutter#181915)
2026-02-04 [email protected] In the Web codec tests, skip an undecodable image that is used to test a Skia error handling code path. (flutter/flutter#181870)
2026-02-04 [email protected] Roll Packages from 5b1bea8 to 3bddf2c (5 revisions) (flutter/flutter#181918)
2026-02-04 [email protected] Roll Fuchsia Linux SDK from UmQaaNuhkiuE8Dzug... to J2QdLcY2gyt4NP_xV... (flutter/flutter#181893)
2026-02-04 [email protected] Roll Dart SDK from 54322a0b1109 to 204db085d970 (3 revisions) (flutter/flutter#181890)
2026-02-04 [email protected] Cleanup cross imports (flutter/flutter#181807)
2026-02-04 [email protected] [Material] Remove Material import from backdrop_filter_test.dart widget tests (flutter/flutter#181386)
2026-02-04 [email protected] Move CheckedModeBanner tests to material and remove Material import from widgets banner_test (flutter/flutter#181261)
2026-02-04 [email protected] feat: Pass parameters from DropdownMenuFormField to DropDownMenu (flutter/flutter#181373)
2026-02-04 [email protected] Remove `Config complete` log when using `flutter build apk --config-only` (flutter/flutter#181864)
2026-02-04 [email protected] [Impeller] Fix flattening of very large zoomed curves with tiny stroke widths (flutter/flutter#181505)
2026-02-03 [email protected] Propagates Overlay's MediaQueryData to OverlayPortal child (flutter/flutter#181579)
2026-02-03 [email protected] Make sure that an AnimatedScale doesn't crash in 0x0 environment (flutter/flutter#181481)
2026-02-03 [email protected] Roll Dart SDK from 56294a92d5cc to 54322a0b1109 (1 revision) (flutter/flutter#181872)
2026-02-03 [email protected] Fix decorated box (flutter/flutter#179802)
2026-02-03 [email protected] Roll pub packages (flutter/flutter#181871)
2026-02-03 [email protected] Remove Material library dependency from expansible_test.dart (flutter/flutter#181657)
2026-02-03 [email protected] Organize and update fragment shader uniform tests. (flutter/flutter#181822)
2026-02-03 [email protected] fix(web_ui): handle non-invertible matrices in ImageFilter.matrix (flutter/flutter#181742)
2026-02-03 [email protected] Remove unnecessary Material import from cupertino/slider_test.dart (flutter/flutter#180957)
2026-02-03 [email protected] Remove the Flutter.xcframework as a swift dependency (flutter/flutter#181739)
2026-02-03 [email protected] feature: implementation of tooltips in the `_TestWindowingOwner` and minor bugfixes to the multiple windows example app (flutter/flutter#181510)
2026-02-03 [email protected] [Web] Fix flt-platform-view comment (flutter/flutter#181576)
2026-02-03 [email protected] Marks Linux_pixel_7pro android_verified_input_test to be unflaky (flutter/flutter#179120)
2026-02-03 [email protected] Unmark `hybrid_android_views_integration_test` as bringup (flutter/flutter#181628)
2026-02-03 [email protected] Remove material from sliver_tree_test.dart (flutter/flutter#181415)
2026-02-03 [email protected] Make `android_plugin_new_output_dir_test` only build release (flutter/flutter#181677)
2026-02-03 [email protected] Roll customer tests (flutter/flutter#181825)
2026-02-03 [email protected] Add Linux Foundation Health Score badge to README (flutter/flutter#175587)
2026-02-03 [email protected] Remove unused getters on AndroidProject class (flutter/flutter#181860)
2026-02-03 [email protected] Adds batch release doc for flutter/package (flutter/flutter#181676)
2026-02-03 [email protected] [ Tool ] Don't use `globals.platform` in `getFlutterRoot()` (flutter/flutter#181859)
2026-02-03 [email protected] Roll Packages from 837dbbd to 5b1bea8 (10 revisions) (flutter/flutter#181857)
2026-02-03 [email protected] Remove material from basic_test.dart (flutter/flutter#181444)
2026-02-03 [email protected] [ Tool ] Fix regression introduced in flutter/flutter#181421 (flutter/flutter#181826)

If this roll has caused a breakage, revert this CL and stop the roller
...
LongCatIsLooong pushed a commit to LongCatIsLooong/flutter that referenced this pull request Feb 6, 2026
We need to do a hard breaking change in Flutter that affects
`package:super_editor`: flutter#180436

To workaround the hard breaking change, we will:

1. Temporarily remove super_editor from Flutter's customer tests:
flutter/tests#480
2. Roll customer tests to the flutter/flutter repo (this PR)
3. Land the breaking change in Flutter + add a breaking migration guide
to the Flutter website
4. Update super_editor's
[main](https://github.com/superlistapp/super_editor/commits/main) branch
to handle Flutter's breaking change.
5. Re-add super_editor to customer tests, using the latest commit from
super_editor's main branch.

<details><summary>Why this is necessary...</summary>

To fix flutter#161592, we need to pass
additional styling information to the web engine.

Historically, we plumb text styling information through
[TextInputConnection.setStyle(...)](https://api.flutter.dev/flutter/services/TextInputConnection/setStyle.html).
However, every time we add a parameter here, it creates a breaking
change for super_editor's
[TextInputConnectionDecorator](https://github.com/Flutter-Bounty-Hunters/super_editor/blob/068a20d3151dc4e46068b5cb54a38b0e93f7ef03/super_editor/lib/src/default_editor/document_ime/ime_decoration.dart#L8)
as it implements `TextInputConnection`.

To stop this cycle, we will do a one-time breaking change to move to a
more extensible pattern:

1. Add new
[TextInputStyle](https://github.com/flutter/flutter/pull/180436/files#diff-701a97b414026a5c87a06b546bb38ca70be2aa0ce44cbf170f4b43e8defcc91aR1530)
class. This will wrap all text input styling properties.
2. Add new [TextInputConnection.updateStyle(TextInputStyle
style)](https://github.com/flutter/flutter/pull/180436/files#diff-701a97b414026a5c87a06b546bb38ca70be2aa0ce44cbf170f4b43e8defcc91aR1793)
method.
3. Deprecate `TextInputConnection.setStyle(...)`.

This pattern lets us add more text input styling properties without
breaking super_editor again.

To handle this breaking change, the following code will need to be added
to super_editor's [
TextInputConnectionDecorator](https://github.com/Flutter-Bounty-Hunters/super_editor/blob/068a20d3151dc4e46068b5cb54a38b0e93f7ef03/super_editor/lib/src/default_editor/document_ime/ime_decoration.dart#L8):

```dart
  @OverRide
  void updateStyle(TextInputStyle style) => client?.updateStyle(style);
```

</details>

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
flutter-zl pushed a commit to flutter-zl/flutter that referenced this pull request Feb 10, 2026
We need to do a hard breaking change in Flutter that affects
`package:super_editor`: flutter#180436

To workaround the hard breaking change, we will:

1. Temporarily remove super_editor from Flutter's customer tests:
flutter/tests#480
2. Roll customer tests to the flutter/flutter repo (this PR)
3. Land the breaking change in Flutter + add a breaking migration guide
to the Flutter website
4. Update super_editor's
[main](https://github.com/superlistapp/super_editor/commits/main) branch
to handle Flutter's breaking change.
5. Re-add super_editor to customer tests, using the latest commit from
super_editor's main branch.

<details><summary>Why this is necessary...</summary>

To fix flutter#161592, we need to pass
additional styling information to the web engine.

Historically, we plumb text styling information through
[TextInputConnection.setStyle(...)](https://api.flutter.dev/flutter/services/TextInputConnection/setStyle.html).
However, every time we add a parameter here, it creates a breaking
change for super_editor's
[TextInputConnectionDecorator](https://github.com/Flutter-Bounty-Hunters/super_editor/blob/068a20d3151dc4e46068b5cb54a38b0e93f7ef03/super_editor/lib/src/default_editor/document_ime/ime_decoration.dart#L8)
as it implements `TextInputConnection`.

To stop this cycle, we will do a one-time breaking change to move to a
more extensible pattern:

1. Add new
[TextInputStyle](https://github.com/flutter/flutter/pull/180436/files#diff-701a97b414026a5c87a06b546bb38ca70be2aa0ce44cbf170f4b43e8defcc91aR1530)
class. This will wrap all text input styling properties.
2. Add new [TextInputConnection.updateStyle(TextInputStyle
style)](https://github.com/flutter/flutter/pull/180436/files#diff-701a97b414026a5c87a06b546bb38ca70be2aa0ce44cbf170f4b43e8defcc91aR1793)
method.
3. Deprecate `TextInputConnection.setStyle(...)`.

This pattern lets us add more text input styling properties without
breaking super_editor again.

To handle this breaking change, the following code will need to be added
to super_editor's [
TextInputConnectionDecorator](https://github.com/Flutter-Bounty-Hunters/super_editor/blob/068a20d3151dc4e46068b5cb54a38b0e93f7ef03/super_editor/lib/src/default_editor/document_ime/ime_decoration.dart#L8):

```dart
  @OverRide
  void updateStyle(TextInputStyle style) => client?.updateStyle(style);
```

</details>

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
rickhohler pushed a commit to rickhohler/flutter that referenced this pull request Feb 19, 2026
We need to do a hard breaking change in Flutter that affects
`package:super_editor`: flutter#180436

To workaround the hard breaking change, we will:

1. Temporarily remove super_editor from Flutter's customer tests:
flutter/tests#480
2. Roll customer tests to the flutter/flutter repo (this PR)
3. Land the breaking change in Flutter + add a breaking migration guide
to the Flutter website
4. Update super_editor's
[main](https://github.com/superlistapp/super_editor/commits/main) branch
to handle Flutter's breaking change.
5. Re-add super_editor to customer tests, using the latest commit from
super_editor's main branch.

<details><summary>Why this is necessary...</summary>

To fix flutter#161592, we need to pass
additional styling information to the web engine.

Historically, we plumb text styling information through
[TextInputConnection.setStyle(...)](https://api.flutter.dev/flutter/services/TextInputConnection/setStyle.html).
However, every time we add a parameter here, it creates a breaking
change for super_editor's
[TextInputConnectionDecorator](https://github.com/Flutter-Bounty-Hunters/super_editor/blob/068a20d3151dc4e46068b5cb54a38b0e93f7ef03/super_editor/lib/src/default_editor/document_ime/ime_decoration.dart#L8)
as it implements `TextInputConnection`.

To stop this cycle, we will do a one-time breaking change to move to a
more extensible pattern:

1. Add new
[TextInputStyle](https://github.com/flutter/flutter/pull/180436/files#diff-701a97b414026a5c87a06b546bb38ca70be2aa0ce44cbf170f4b43e8defcc91aR1530)
class. This will wrap all text input styling properties.
2. Add new [TextInputConnection.updateStyle(TextInputStyle
style)](https://github.com/flutter/flutter/pull/180436/files#diff-701a97b414026a5c87a06b546bb38ca70be2aa0ce44cbf170f4b43e8defcc91aR1793)
method.
3. Deprecate `TextInputConnection.setStyle(...)`.

This pattern lets us add more text input styling properties without
breaking super_editor again.

To handle this breaking change, the following code will need to be added
to super_editor's [
TextInputConnectionDecorator](https://github.com/Flutter-Bounty-Hunters/super_editor/blob/068a20d3151dc4e46068b5cb54a38b0e93f7ef03/super_editor/lib/src/default_editor/document_ime/ime_decoration.dart#L8):

```dart
  @OverRide
  void updateStyle(TextInputStyle style) => client?.updateStyle(style);
```

</details>

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect position of Japanese predictive conversion popup in TextFormField using maxLines on the Web

2 participants