Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[TST]: increase unit test coverage #26864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
43 of 64 tasks
tacaswell opened this issue Sep 21, 2023 · 67 comments
Open
43 of 64 tasks

[TST]: increase unit test coverage #26864

tacaswell opened this issue Sep 21, 2023 · 67 comments
Labels
mentored: hackathon topic: testing topic: units and array ducktypes
Milestone
future releases

Comments

@tacaswell
Copy link
Member

tacaswell commented Sep 21, 2023 •
edited by QuLogic
Loading

Problem

Although we nominally support units through all of our plotting APIs, this is not through tested (unfortunately this is a case where code coverage is not super informative). The address this issue we would like to add a "smoke test" (does it run without smoke coming out?) of every plotting method using "unit-full" data. The most common "unit-full" data is likely datetime, thus we are going to use datetime and timedelta values as the vehicle to exhaustively test which of the methods correctly handle units.

This is the tracking issue for this work.

Process

  1. Fork Matplotlib and get set up for development. See https://matplotlib.org/devdocs/devel/contribute.html#contribute-code for detailed instructions of setting up a local or codespaces development environment. For this work it is not strictly necessary to have a development version of Matplotlib installed, just an up-to-date installation (mpl 3.8.0) as the tested behavior should be stable.
  2. Select a method to work on (for GHC OSD we will use slack and zoom to make sure we de-conflict!)
  3. Develop a short example that exercises passing dates or time deltas into the plotting methods. Try to exercise as many of the inputs (and their combinations) as practical with the datetimes.
    1. If you have a working example open a Pull request adding the example as a body to the correct test method in lib/matplotlib/tests/test_datetime.py. Please include an image of the generated plot in the description of the PR and cross reference this issue (by including #26864 in the PR description body). This is modeled for ax.plot (I took the easiest one ;) ) in Add datetime testing skeleton #26859.
    2. If you find a method that should support datetime input but does not, open a new bug with the broken code and similarly reference this issue.
    3. If passing datetime / united data to the method does not make any sense or it should not work open a PR removing that test method and similarly reference this issue.

Task list
@tacaswell tacaswell added mentored: hackathon Good first issue Open a pull request against these issues if there are no active ones! labels Sep 21, 2023
@tacaswell tacaswell added this to the v3.9.0 milestone Sep 21, 2023
@github-actions
Copy link

Good first issue - notes for new contributors

This issue is suited to new contributors because it does not require understanding of the Matplotlib internals. To get started, please see our contributing guide.

We do not assign issues. Check the Development section in the sidebar for linked pull requests (PRs). If there are none, feel free to start working on it. If there is an open PR, please collaborate on the work by reviewing it rather than duplicating it in a competing PR.

If something is unclear, please reach out on any of our communication channels.

@seohyeonlee2020
Copy link
Contributor

Hello! I'll take Axes.scatter

@seohyeonlee2020 seohyeonlee2020 mentioned this issue Sep 22, 2023
Merged
1 task
@iandw iandw mentioned this issue Sep 23, 2023
Closed
@tgmiller5
Copy link

Hello, I will take the axes.bar

@ksunden ksunden mentioned this issue Oct 3, 2023
Closed
5 tasks
@ayushrathore111
Copy link

hii @tacaswell
I'll start working on Axes.boxplot.
thank you.

@ayushrathore111 ayushrathore111 mentioned this issue Oct 3, 2023
Closed
5 tasks
@ksunden
Copy link
Member

ksunden commented Oct 3, 2023

Note we are testing matplotlib unit support here, so please use numpy/matplotlib/datetime only in these tests (e.g. not pandas)

@kots14
Copy link
Contributor

kots14 commented Oct 4, 2023

Hi @tacaswell
I'm starting to work on Axes.contour.

@Quetzalcoatl29
Copy link

Hi @tacaswell I'd like to be assigned on one or more tasks

@rcomer
Copy link
Member

rcomer commented Oct 5, 2023

Hi @Quetzalcoatl29, we do not assign tasks. Please work on whichever one you like. If you comment to say which you are starting on, as others have done, then that will help to prevent duplication of effort.

kots14 added a commit to kots14/matplotlib that referenced this issue Oct 6, 2023
@kots14
Add test_contour for matplotlib#26864
fb2a0ec
kots14 added a commit to kots14/matplotlib that referenced this issue Oct 6, 2023
@kots14
Add test_contour matplotlib#26864
2761fa6
@kots14 kots14 mentioned this issue Oct 6, 2023
Merged
5 tasks
kots14 added a commit to kots14/matplotlib that referenced this issue Oct 6, 2023
@kots14
Add test_contour matplotlib#26864
c7a1710 
Modify test_contour matplotlib#26864
@kots14
Copy link
Contributor

kots14 commented Oct 6, 2023 •
edited
Loading

I'll be working on Axes.contourf next once this PR is merged.
Update: Since the previous PR is approved, without waiting further, raised another PR for contourf.

@yangyangdotcom
Copy link
Contributor

I will work on Axes.hist

Eben-Success added a commit to Eben-Success/matplotlib that referenced this issue Oct 7, 2023
@Eben-Success
Add unit-test to test_angle_spectrum matplotlib#26864
e60ae51
@yangyangdotcom
Copy link
Contributor

I am able to write the test and run it with no failure but I am having a problem generating the graph. I tried adding plt.show() at the end of my test but that will make the test fail. Any help would be much appreciated.

kots14 added a commit to kots14/matplotlib that referenced this issue Oct 7, 2023
@kots14
Add test_contourf matplotlib#26864
bf4e786
kots14 added a commit to kots14/matplotlib that referenced this issue Oct 7, 2023
@kots14
Add test_contourf matplotlib#26864
1471083
kots14 added a commit to kots14/matplotlib that referenced this issue Oct 7, 2023
@kots14
Add test_contourf matplotlib#26864
785cb36
kots14 added a commit to kots14/matplotlib that referenced this issue Oct 7, 2023
@kots14
Add test_contourf matplotlib#26864
677a406
@kots14 kots14 mentioned this issue Oct 7, 2023
Merged
5 tasks
@AsherHounsell
Copy link

I will work on Axes.triplot.

@EthanZheng11
Copy link

I will work on Axes.tricontourf.

@EthanZheng11 EthanZheng11 mentioned this issue Dec 9, 2023
Open
3 tasks
@AsherHounsell AsherHounsell mentioned this issue Dec 9, 2023
Open
3 tasks
@jhimanish
Copy link

Hi, I'm new to Open-Source Contributions but I'd like to contribute towards this project. I can work on creating a test for axes.streamplot.
Thank you

@jhimanish jhimanish mentioned this issue Dec 10, 2023
Open
3 tasks
@Ali-Aboelela Ali-Aboelela mentioned this issue Dec 10, 2023
Closed
1 task
bikegeek added a commit to bikegeek/matplotlib that referenced this issue Dec 10, 2023
@bikegeek
Issue matplotlib#26864 test_hexbin added extent and marginals, modifi…
ce15f4d 
…ed gridsize
bikegeek added a commit to bikegeek/matplotlib that referenced this issue Dec 10, 2023
@bikegeek
Issue matplotlib#26864 test_tripcolor plot with datetime on x-, y-, a…
995592e 
…nd both x- and y-axis
@bikegeek bikegeek mentioned this issue Dec 10, 2023
Open
1 task
@maryamyounis maryamyounis mentioned this issue Dec 10, 2023
Open
1 task
@ksunden
Copy link
Member

ksunden commented Dec 11, 2023

I do believe we now have PRs (at least) opened for each of these.

Thank you to all of the first time contributors who helped get us this far.

@shriyakalakata shriyakalakata mentioned this issue Dec 12, 2023
Closed
2 tasks
QuLogic pushed a commit that referenced this issue Dec 12, 2023
@kots14
Add test_contour under test_datetime.py (#27013)
92cc8f5 
* Add test_contour #26864

* Add test_contour #26864

Modify test_contour #26864

* Removed test_cohere and repetitive tests
This was referenced Dec 14, 2023
Closed
Closed
Closed
@szhukovska szhukovska mentioned this issue Dec 19, 2023
Closed
5 tasks
@Elllllllvin
Copy link

Hello , I would like to tackle the Axes.quiver if you don't mind, since i notice that it has not been solved yet.

@Elllllllvin Elllllllvin mentioned this issue Dec 20, 2023
Open
5 tasks
@ksunden
Copy link
Member

ksunden commented Dec 20, 2023

Please note that we have an open PR for Quiver, and we generally prefer the earlier PR when possible. #27407

@ksunden ksunden removed the Good first issue Open a pull request against these issues if there are no active ones! label Dec 20, 2023
@ksunden
Copy link
Member

ksunden commented Dec 20, 2023

I'm removing the good first issue tag because we have PRs at least started for all points here.

@Elllllllvin
Copy link

Please note that we have an open PR for Quiver, and we generally prefer the earlier PR when possible. #27407

Thank you for your reply. I just noticed that the previous #27407 did not fully solve the problem. It only tested X and did not test Y, and the previous pull request has not been merged, so I thought I could continue to contribute to this issue.

@AndyXi163 AndyXi163 mentioned this issue Dec 22, 2023
Closed
@QuLogic QuLogic modified the milestones: v3.9.0, v3.10.0 Apr 3, 2024
@oscargus oscargus mentioned this issue Apr 15, 2024
Open
@ksunden ksunden modified the milestones: v3.10.0, future releases Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mentored: hackathon topic: testing topic: units and array ducktypes
Projects
None yet
Milestone
future releases
Development

Successfully merging a pull request may close this issue.

Add datetime testing for boxplot ayushrathore111/matplotlib