forked from scikit-learn/scikit-learn
-
Notifications
You must be signed in to change notification settings - Fork 0
Revert "Update" #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-learn#13015)" This reverts commit a3f8443.
This reverts commit 29daa36.
This reverts commit 5d4996c.
This reverts commit b07dd68.
This reverts commit 696a14b.
This reverts commit 8dd95c4.
This reverts commit 534090c.
This reverts commit 492d014.
This reverts commit 80381a8.
…learn#12999)" This reverts commit 8b9bdc1.
This reverts commit 8652734.
This reverts commit d258d50.
This reverts commit f5e9d8e.
This reverts commit 1f0aa97.
This reverts commit a02c265.
…cikit-learn#12984)" This reverts commit 04ec2c9.
This reverts commit d551ff2.
…tures + handle_unknown='ignore' case (scikit-learn#12923)" This reverts commit 374f621.
This reverts commit f5d4a0f.
)" This reverts commit fc5c2a3.
This reverts commit 6a85a17.
This reverts commit ff63520.
…learn#12969)" This reverts commit 236dd9d.
…not fitted (scikit-learn#12965)" This reverts commit d857e78.
…string (scikit-learn#12954)" This reverts commit 27bac67.
…ing (scikit-learn#12926)" This reverts commit f1e78a6.
This reverts commit e89aadf.
…t-learn#12441)" This reverts commit 1a8c267.
This reverts commit a21df77.
…number of classes in Linear Discriminant Analysis (scikit-learn#12391)" This reverts commit 6cae448.
This reverts commit 9b4ea74.
This reverts commit 294884c.
…m_start = True (scikit-learn#12361)" This reverts commit cab496e.
…-learn#12279)" This reverts commit 48ceed0.
This reverts commit 32bffd8.
…cikit-learn#12402)" This reverts commit d0234e6.
This reverts commit 82428c5.
This reverts commit e0830e3.
…learn#12338)" This reverts commit 91f7a68.
…earn#12382)" This reverts commit 4b47ef5.
This reverts commit 9e7ed1f.
This reverts commit 516d81b.
This reverts commit 7df61c1.
…t-learn#12341)" This reverts commit 88744dc.
…se (scikit-learn#12304)" This reverts commit 1dc7cc0.
This reverts commit e7d8b82.
…learn#12368)" This reverts commit 347c272.
…ikit-learn#12367)" This reverts commit a48484d.
…documents example (scikit-learn#12359)" This reverts commit c3e96a7.
xhluca
pushed a commit
that referenced
this pull request
Apr 28, 2019
…13243) * Remove unused code * Squash all the PR 9040 commits initial PR commit seq_dataset.pyx generated from template seq_dataset.pyx generated from template #2 rename variables fused types consistency test for seq_dataset a sklearn/utils/tests/test_seq_dataset.py new if statement add doc sklearn/utils/seq_dataset.pyx.tp minor changes minor changes typo fix check numeric accuracy only up 5th decimal Address oliver's request for changing test name add test for make_dataset and rename a variable in test_seq_dataset * FIX tests * TST more numerically stable test_sgd.test_tol_parameter * Added benchmarks to compare SAGA 32b and 64b * Fixing gael's comments * fix * solve some issues * PEP8 * Address lesteve comments * fix merging * avoid using assert_equal * use all_close * use explicit ArrayDataset64 and CSRDataset64 * fix: remove unused import * Use parametrized to cover ArrayDaset-CSRDataset-32-64 matrix * for consistency use 32 first then 64 + add 64 suffix to variables * it would be cool if this worked !!! * more verbose version * revert SGD changes as much as possible. * Add solvers back to bench_saga * make 64 explicit in the naming * remove checking native python type + add comparison between 32 64 * Add whatsnew with everyone with commits * simplify a bit the testing * simplify the parametrize * update whatsnew * fix pep8
xhluca
pushed a commit
that referenced
this pull request
Apr 28, 2019
* initial commit * used random class * fixed failing testcases, reverted __init__.py * fixed failing testcases #2 - passed rng as parameter to ParameterSampler class - changed seed from 0 to 42 (as original) * fixed failing testcases #2 - passed rng as parameter to SparseRandomProjection class * fixed failing testcases scikit-learn#4 - passed rng as parameter to GaussianRandomProjection class * fixed failing test case because of flake 8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1