Codestin Search App

mhughes2012 · 2026-02-03T18:01:48Z

Summary

Fixes #14375 by ensuring @jest/expect-utils does not throw from iterableEquality (and therefore from matchers like toMatchObject) when it encounters “exotic” iterables whose iteration can throw at runtime (for example, an object whose [Symbol.iterator] is a TypedArray iterator).
Instead of crashing the assertion with TypeError: this is not a typed array., the equality check now treats that case as “not equal”, and a regression test covers the behavior.
(CHANGELOG.md updated.)

Test plan

yarn jest packages/expect-utils/src/__tests__/utils.test.ts -t "TypedArray iterator"
yarn jest expect-utils

…rables

netlify · 2026-02-03T18:01:55Z

✅ Deploy Preview for jestjs ready!

Name	Link
🔨 Latest commit	`2355915`
🔍 Latest deploy log	https://app.netlify.com/projects/jestjs/deploys/69fa31605cd8100008bfbd4f
😎 Deploy Preview	https://deploy-preview-15952--jestjs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

linux-foundation-easycla · 2026-02-03T18:01:56Z

The committers listed above are authorized under a signed CLA.

✅ login: mhughes2012 / name: DESKTOP-LF576SH\micha (6a97e49, c46ebbf, caf309e)
✅ login: mhughes2012 / name: Michael Hughes (7806a14)
✅ login: SimenB / name: Simen Bekkhus (0083275, 2355915, 61ed623, afddeec, c825237)

pkg-pr-new · 2026-02-03T18:07:09Z

Open in StackBlitz

babel-jest

npm i https://pkg.pr.new/babel-jest@15952

babel-plugin-jest-hoist

npm i https://pkg.pr.new/babel-plugin-jest-hoist@15952

babel-preset-jest

npm i https://pkg.pr.new/babel-preset-jest@15952

create-jest

npm i https://pkg.pr.new/create-jest@15952

@jest/diff-sequences

npm i https://pkg.pr.new/@jest/diff-sequences@15952

expect

npm i https://pkg.pr.new/expect@15952

@jest/expect-utils

npm i https://pkg.pr.new/@jest/expect-utils@15952

jest

npm i https://pkg.pr.new/jest@15952

jest-changed-files

npm i https://pkg.pr.new/jest-changed-files@15952

jest-circus

npm i https://pkg.pr.new/jest-circus@15952

jest-cli

npm i https://pkg.pr.new/jest-cli@15952

jest-config

npm i https://pkg.pr.new/jest-config@15952

@jest/console

npm i https://pkg.pr.new/@jest/console@15952

@jest/core

npm i https://pkg.pr.new/@jest/core@15952

@jest/create-cache-key-function

npm i https://pkg.pr.new/@jest/create-cache-key-function@15952

jest-diff

npm i https://pkg.pr.new/jest-diff@15952

jest-docblock

npm i https://pkg.pr.new/jest-docblock@15952

jest-each

npm i https://pkg.pr.new/jest-each@15952

@jest/environment

npm i https://pkg.pr.new/@jest/environment@15952

jest-environment-jsdom

npm i https://pkg.pr.new/jest-environment-jsdom@15952

@jest/environment-jsdom-abstract

npm i https://pkg.pr.new/@jest/environment-jsdom-abstract@15952

jest-environment-node

npm i https://pkg.pr.new/jest-environment-node@15952

@jest/expect

npm i https://pkg.pr.new/@jest/expect@15952

@jest/fake-timers

npm i https://pkg.pr.new/@jest/fake-timers@15952

@jest/get-type

npm i https://pkg.pr.new/@jest/get-type@15952

@jest/globals

npm i https://pkg.pr.new/@jest/globals@15952

jest-haste-map

npm i https://pkg.pr.new/jest-haste-map@15952

jest-jasmine2

npm i https://pkg.pr.new/jest-jasmine2@15952

jest-leak-detector

npm i https://pkg.pr.new/jest-leak-detector@15952

jest-matcher-utils

npm i https://pkg.pr.new/jest-matcher-utils@15952

jest-message-util

npm i https://pkg.pr.new/jest-message-util@15952

jest-mock

npm i https://pkg.pr.new/jest-mock@15952

@jest/pattern

npm i https://pkg.pr.new/@jest/pattern@15952

jest-phabricator

npm i https://pkg.pr.new/jest-phabricator@15952

jest-regex-util

npm i https://pkg.pr.new/jest-regex-util@15952

@jest/reporters

npm i https://pkg.pr.new/@jest/reporters@15952

jest-resolve

npm i https://pkg.pr.new/jest-resolve@15952

jest-resolve-dependencies

npm i https://pkg.pr.new/jest-resolve-dependencies@15952

jest-runner

npm i https://pkg.pr.new/jest-runner@15952

jest-runtime

npm i https://pkg.pr.new/jest-runtime@15952

@jest/schemas

npm i https://pkg.pr.new/@jest/schemas@15952

jest-snapshot

npm i https://pkg.pr.new/jest-snapshot@15952

@jest/snapshot-utils

npm i https://pkg.pr.new/@jest/snapshot-utils@15952

@jest/source-map

npm i https://pkg.pr.new/@jest/source-map@15952

@jest/test-result

npm i https://pkg.pr.new/@jest/test-result@15952

@jest/test-sequencer

npm i https://pkg.pr.new/@jest/test-sequencer@15952

@jest/transform

npm i https://pkg.pr.new/@jest/transform@15952

@jest/types

npm i https://pkg.pr.new/@jest/types@15952

jest-util

npm i https://pkg.pr.new/jest-util@15952

jest-validate

npm i https://pkg.pr.new/jest-validate@15952

jest-watcher

npm i https://pkg.pr.new/jest-watcher@15952

jest-worker

npm i https://pkg.pr.new/jest-worker@15952

pretty-format

npm i https://pkg.pr.new/pretty-format@15952

commit: 2355915

Copilot

Pull request overview

This PR aims to harden @jest/expect-utils so matcher equality no longer crashes when iterableEquality encounters iterables whose iterator implementation can throw at runtime, and to record that fix in the changelog.

Changes:

Wraps iterableEquality traversal logic in try/catch/finally and returns false on thrown iterator/getter access.
Adds a regression test for an object using Uint8Array.prototype[Symbol.iterator].
Updates the changelog entry for the expect-utils fix.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
`packages/expect-utils/src/utils.ts`	Changes `iterableEquality` error-handling and stack cleanup behavior.
`packages/expect-utils/src/__tests__/utils.test.ts`	Adds coverage for the exotic TypedArray-iterator case.
`CHANGELOG.md`	Documents the expect-utils bug fix.

+    // treat it as "not equal" rather than crashing the matcher.
+    return false;


+  } catch {
+    // If an exotic iterator/getter throws (DOM objects, proxies, host objects),
+    // treat it as "not equal" rather than crashing the matcher.
+    return false;


+  test('does not throw when iterating an object with a TypedArray iterator', () => {
+    const badIterable = {
+      [Symbol.iterator]: Uint8Array.prototype[Symbol.iterator],
+    };
+
+    expect(() => iterableEquality(badIterable, badIterable)).not.toThrow();
+    expect(iterableEquality(badIterable, badIterable)).toBe(false);


SimenB

thanks!

SimenB · 2026-05-07T19:18:19Z

https://github.com/jestjs/jest/releases/tag/v30.4.0

| datasource | package | from | to | | ---------- | ------- | ------ | ------ | | npm | jest | 30.3.0 | 30.4.0 | ## [v30.4.0](https://github.com/jestjs/jest/blob/HEAD/CHANGELOG.md#3040) ##### Features - `[babel-jest]` Support collecting coverage from `.mts`, `.cts` (and other) files ([#15994](jestjs/jest#15994)) - `[jest-circus, jest-cli, jest-config, jest-core, jest-jasmine2, jest-types]` Add `--collect-tests` flag to discover and list tests without executing them ([#16006](jestjs/jest#16006)) - `[jest-config, jest-runner, jest-worker]` Add `workerGracefulExitTimeout` config option to control how long workers are given to exit before being force-killed ([#15984](jestjs/jest#15984)) - `[jest-config]` Add support for `jest.config.mts` as a valid configuration file ([#16005](jestjs/jest#16005)) - `[jest-config, jest-core, jest-reporters, jest-runner]` `verbose` and `silent` can now be set per-project; the project-level value overrides the global value for that project's tests ([#16133](jestjs/jest#16133)) - `[@jest/fake-timers]` Accept `Temporal.Duration` in `jest.advanceTimersByTime()` and `jest.advanceTimersByTimeAsync()` ([#16128](jestjs/jest#16128)) - `[@jest/fake-timers]` Accept `Temporal.Instant` and `Temporal.ZonedDateTime` in `jest.setSystemTime()` and `useFakeTimers({now})` ([#16128](jestjs/jest#16128)) - `[@jest/fake-timers]` Support faking `Temporal.Now.*` ([#16131](jestjs/jest#16131)) - `[jest-mock]` Add `clearMocksOnScope(scope)` on `ModuleMocker` for clearing every mock function exposed on a scope object ([#16088](jestjs/jest#16088)) - `[jest-resolve]` Add `canResolveSync()` on `Resolver` so callers can detect when a user-configured resolver only exports an `async` hook ([#16064](jestjs/jest#16064)) - `[jest-runtime]` Use synchronous `evaluate()` for ES modules without top-level `await` on Node versions that support it (v24.9+), and prefer the synchronous transform path when a sync transformer is configured ([#16062](jestjs/jest#16062)) - `[jest-runtime]` Support `require()` of ES modules on Node v24.9+ ([#16074](jestjs/jest#16074)) - `[jest-runtime]` Validate TC39 import attributes (`with { type: 'json' }`) on ESM imports ([#16127](jestjs/jest#16127)) - `[@jest/transform]` Add `canTransformSync(filename)` on `ScriptTransformer` so callers can pick the sync vs async transform path ([#16062](jestjs/jest#16062)) - `[jest-util]` Add `isError` helper ([#16076](jestjs/jest#16076)) - `[pretty-format]` Support React 19 ([#16123](jestjs/jest#16123)) ##### Fixes - `[expect-utils]` Fix `toStrictEqual` failing on `structuredClone` results due to cross-realm constructor mismatch ([#15959](jestjs/jest#15959)) - `[@jest/expect-utils]` Prevent `toMatchObject`/subset matching from throwing when encountering exotic iterables ([#15952](jestjs/jest#15952)) - `[fake-timers]` Convert `Date` to milliseconds before passing to `@sinonjs/fake-timers` ([#16029](jestjs/jest#16029)) - `[jest]` Export `GlobalConfig` and `ProjectConfig` TypeScript types ([#16132](jestjs/jest#16132)) - `[jest-circus]` Prevent crash when `asyncError` is undefined for non-Error throws ([#16003](jestjs/jest#16003)) - `[jest-circus, jest-jasmine2]` Include `Error.cause` in JSON `failureMessages` output ([#15967](jestjs/jest#15967)) - `[jest-config]` Fix preset path resolution on Windows when the preset uses subpath `exports` ([#15961](jestjs/jest#15961)) - `[jest-config]` Allow `collectCoverage` and `coverageProvider` in project config without a validation warning ([#16132](jestjs/jest#16132)) - `[jest-config]` Project config validator now emits "is not supported in an individual project configuration" instead of "probably a typing mistake" for known global-only options ([#16132](jestjs/jest#16132)) - `[jest-environment-node]` Fix `--localstorage-file` warning on Node 25+ ([#16086](jestjs/jest#16086)) - `[jest-reporters]` Apply global coverage threshold to unmatched pattern files in addition to glob/path thresholds ([#16137](jestjs/jest#16137)) - `[jest-reporters, jest-runner, jest-runtime, jest-transform]` Fix coverage report not showing correct code coverage when using `projects` config option ([#16140](jestjs/jest#16140)) - `[jest-runtime]` Resolve `expect` and `@jest/expect` from the internal module registry so test-file imports share the same `JestAssertionError` as the global `expect` ([#16130](jestjs/jest#16130)) - `[jest-runtime]` Improve CJS-from-ESM interop: `__esModule`/Babel default unwrap, broader named-export coverage, and shared CJS singleton across importers ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Load `.js` files with ESM syntax but no `"type":"module"` marker as native ESM ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Extend the `.js`-with-ESM-syntax fallback to `require()` on Node v24.9+ - falls back to `require(esm)` when the CJS parser rejects ESM syntax ([#16078](jestjs/jest#16078)) - `[jest-runtime]` Fix deadlocks and double-evaluation in concurrent ESM and wasm imports ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Fix error when `require()` is called after the Jest environment has been torn down ([#15951](jestjs/jest#15951)) - `[jest-runtime]` Fix missing error when `import()` is called after the Jest environment has been torn down ([#16080](jestjs/jest#16080)) - `[jest-runtime]` Fix virtual `unstable_mockModule` registrations not respected in ESM ([#16081](jestjs/jest#16081)) - `[jest-runtime]` Apply `moduleNameMapper` when resolving modules with `require.resolve()` and the `paths` option ([#16135](jestjs/jest#16135)) ##### Chore & Maintenance - `[@jest/fake-timers]` Upgrade `@sinonjs/fake-timers` ([#16139](jestjs/jest#16139)) - `[jest-runtime]` Use synchronous `linkRequests` / `instantiate` for ESM linking on Node v24.9+ ([#16063](jestjs/jest#16063))

| datasource | package | from | to | | ---------- | ------- | ------ | ------ | | npm | jest | 30.3.0 | 30.4.2 | ## [v30.4.2](https://github.com/jestjs/jest/blob/HEAD/CHANGELOG.md#3042) ##### Fixes - `[jest-runtime]` Fix named imports from CJS modules whose `module.exports` is a function with own-property exports ([#16150](jestjs/jest#16150)) ## [v30.4.1](https://github.com/jestjs/jest/blob/HEAD/CHANGELOG.md#3041) ##### Features - `[jest-config, jest-core, jest-runner, jest-schemas, jest-types]` Allow custom runner configuration options via tuple format `['runner-path', {options}]` ([#16141](jestjs/jest#16141)) ##### Fixes - `[jest-runtime]` Align CJS-from-ESM default export with Node: `module.exports` is always the ESM default, `__esModule` unwrapping is no longer applied ([#16143](jestjs/jest#16143)) ## [v30.4.0](https://github.com/jestjs/jest/blob/HEAD/CHANGELOG.md#3040) ##### Features - `[babel-jest]` Support collecting coverage from `.mts`, `.cts` (and other) files ([#15994](jestjs/jest#15994)) - `[jest-circus, jest-cli, jest-config, jest-core, jest-jasmine2, jest-types]` Add `--collect-tests` flag to discover and list tests without executing them ([#16006](jestjs/jest#16006)) - `[jest-config, jest-runner, jest-worker]` Add `workerGracefulExitTimeout` config option to control how long workers are given to exit before being force-killed ([#15984](jestjs/jest#15984)) - `[jest-config]` Add support for `jest.config.mts` as a valid configuration file ([#16005](jestjs/jest#16005)) - `[jest-config, jest-core, jest-reporters, jest-runner]` `verbose` and `silent` can now be set per-project; the project-level value overrides the global value for that project's tests ([#16133](jestjs/jest#16133)) - `[@jest/fake-timers]` Accept `Temporal.Duration` in `jest.advanceTimersByTime()` and `jest.advanceTimersByTimeAsync()` ([#16128](jestjs/jest#16128)) - `[@jest/fake-timers]` Accept `Temporal.Instant` and `Temporal.ZonedDateTime` in `jest.setSystemTime()` and `useFakeTimers({now})` ([#16128](jestjs/jest#16128)) - `[@jest/fake-timers]` Support faking `Temporal.Now.*` ([#16131](jestjs/jest#16131)) - `[jest-mock]` Add `clearMocksOnScope(scope)` on `ModuleMocker` for clearing every mock function exposed on a scope object ([#16088](jestjs/jest#16088)) - `[jest-resolve]` Add `canResolveSync()` on `Resolver` so callers can detect when a user-configured resolver only exports an `async` hook ([#16064](jestjs/jest#16064)) - `[jest-runtime]` Use synchronous `evaluate()` for ES modules without top-level `await` on Node versions that support it (v24.9+), and prefer the synchronous transform path when a sync transformer is configured ([#16062](jestjs/jest#16062)) - `[jest-runtime]` Support `require()` of ES modules on Node v24.9+ ([#16074](jestjs/jest#16074)) - `[jest-runtime]` Validate TC39 import attributes (`with { type: 'json' }`) on ESM imports ([#16127](jestjs/jest#16127)) - `[@jest/transform]` Add `canTransformSync(filename)` on `ScriptTransformer` so callers can pick the sync vs async transform path ([#16062](jestjs/jest#16062)) - `[jest-util]` Add `isError` helper ([#16076](jestjs/jest#16076)) - `[pretty-format]` Support React 19 ([#16123](jestjs/jest#16123)) ##### Fixes - `[expect-utils]` Fix `toStrictEqual` failing on `structuredClone` results due to cross-realm constructor mismatch ([#15959](jestjs/jest#15959)) - `[@jest/expect-utils]` Prevent `toMatchObject`/subset matching from throwing when encountering exotic iterables ([#15952](jestjs/jest#15952)) - `[fake-timers]` Convert `Date` to milliseconds before passing to `@sinonjs/fake-timers` ([#16029](jestjs/jest#16029)) - `[jest]` Export `GlobalConfig` and `ProjectConfig` TypeScript types ([#16132](jestjs/jest#16132)) - `[jest-circus]` Prevent crash when `asyncError` is undefined for non-Error throws ([#16003](jestjs/jest#16003)) - `[jest-circus, jest-jasmine2]` Include `Error.cause` in JSON `failureMessages` output ([#15967](jestjs/jest#15967)) - `[jest-config]` Fix preset path resolution on Windows when the preset uses subpath `exports` ([#15961](jestjs/jest#15961)) - `[jest-config]` Allow `collectCoverage` and `coverageProvider` in project config without a validation warning ([#16132](jestjs/jest#16132)) - `[jest-config]` Project config validator now emits "is not supported in an individual project configuration" instead of "probably a typing mistake" for known global-only options ([#16132](jestjs/jest#16132)) - `[jest-environment-node]` Fix `--localstorage-file` warning on Node 25+ ([#16086](jestjs/jest#16086)) - `[jest-reporters]` Apply global coverage threshold to unmatched pattern files in addition to glob/path thresholds ([#16137](jestjs/jest#16137)) - `[jest-reporters, jest-runner, jest-runtime, jest-transform]` Fix coverage report not showing correct code coverage when using `projects` config option ([#16140](jestjs/jest#16140)) - `[jest-runtime]` Resolve `expect` and `@jest/expect` from the internal module registry so test-file imports share the same `JestAssertionError` as the global `expect` ([#16130](jestjs/jest#16130)) - `[jest-runtime]` Improve CJS-from-ESM interop: `__esModule`/Babel default unwrap, broader named-export coverage, and shared CJS singleton across importers ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Load `.js` files with ESM syntax but no `"type":"module"` marker as native ESM ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Extend the `.js`-with-ESM-syntax fallback to `require()` on Node v24.9+ - falls back to `require(esm)` when the CJS parser rejects ESM syntax ([#16078](jestjs/jest#16078)) - `[jest-runtime]` Fix deadlocks and double-evaluation in concurrent ESM and wasm imports ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Fix error when `require()` is called after the Jest environment has been torn down ([#15951](jestjs/jest#15951)) - `[jest-runtime]` Fix missing error when `import()` is called after the Jest environment has been torn down ([#16080](jestjs/jest#16080)) - `[jest-runtime]` Fix virtual `unstable_mockModule` registrations not respected in ESM ([#16081](jestjs/jest#16081)) - `[jest-runtime]` Apply `moduleNameMapper` when resolving modules with `require.resolve()` and the `paths` option ([#16135](jestjs/jest#16135)) ##### Chore & Maintenance - `[@jest/fake-timers]` Upgrade `@sinonjs/fake-timers` ([#16139](jestjs/jest#16139)) - `[jest-runtime]` Use synchronous `linkRequests` / `instantiate` for ESM linking on Node v24.9+ ([#16063](jestjs/jest#16063))

mhughes2012 added 2 commits February 3, 2026 10:34

fix(expect-utils): avoid throwing from iterableEquality on exotic ite…

caf309e

…rables

chore: add changelog entry for iterableEquality fix

6a97e49

mhughes2012 and others added 5 commits February 4, 2026 08:58

Chore: Trigger CI re-run

c46ebbf

Merge branch 'main' into fix/14375-iterableEquality-no-throw

7806a14

Merge branch 'main' into fix/14375-iterableEquality-no-throw

0083275

mobile merge is hard

c825237

neh

61ed623

SimenB requested a review from Copilot May 5, 2026 15:30

Copilot started reviewing on behalf of SimenB May 5, 2026 15:31 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

SimenB added 2 commits May 5, 2026 19:52

maybe address comments

afddeec

less diff

2355915

SimenB approved these changes May 5, 2026

View reviewed changes

SimenB merged commit 314df33 into jestjs:main May 5, 2026
90 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(expect-utils): iterableEquality should not throw on exotic iterables#15952

fix(expect-utils): iterableEquality should not throw on exotic iterables#15952
SimenB merged 9 commits into
jestjs:mainfrom
mhughes2012:fix/14375-iterableEquality-no-throw

mhughes2012 commented Feb 3, 2026

Uh oh!

netlify Bot commented Feb 3, 2026 •

edited

Loading

Uh oh!

linux-foundation-easycla Bot commented Feb 3, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Feb 3, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

SimenB left a comment

Uh oh!

Uh oh!

SimenB commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		// treat it as "not equal" rather than crashing the matcher.
		return false;

Uh oh!

Conversation

mhughes2012 commented Feb 3, 2026

Summary

Test plan

Uh oh!

netlify Bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for jestjs ready!

Uh oh!

linux-foundation-easycla Bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

SimenB left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SimenB commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify Bot commented Feb 3, 2026 •

edited

Loading

linux-foundation-easycla Bot commented Feb 3, 2026 •

edited

Loading

pkg-pr-new Bot commented Feb 3, 2026 •

edited

Loading