Codestin Search App

SimenB · 2026-05-02T09:29:44Z

Summary

jest-runtime class is 3k lines long. While this diff doesn't really reduce it much (about 200 lines), but it lifts a bunch of the states out and creates cleaner boundary. More refactorings incoming, but let's start here 😀

Test plan

A bunch of unit tests added - existing e2e tests works as regression tests

netlify · 2026-05-02T09:29:50Z

✅ Deploy Preview for jestjs ready!

Name	Link
🔨 Latest commit	`0a51475`
🔍 Latest deploy log	https://app.netlify.com/projects/jestjs/deploys/69f5d607b06ff40008b1688c
😎 Deploy Preview	https://deploy-preview-16081--jestjs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull request overview

This PR refactors jest-runtime by extracting module-resolution state and helper logic from the large Runtime class into a dedicated internal Resolution helper. It also adjusts jest-resolve option types to accept readonly arrays so the new helper can hold and forward shared condition lists more cleanly.

Changes:

Added a new Resolution internal class to own CJS/ESM condition handling, resolver pass-throughs, and sync resolution caches.
Updated Runtime to delegate resolution-related work to the new helper instead of managing resolver state inline.
Relaxed resolver option typings in jest-resolve from mutable arrays to ReadonlyArray and added focused unit tests for the new helper.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`packages/jest-runtime/src/internals/__tests__/Resolution.test.ts`	Adds unit tests for the extracted resolution helper’s conditions, caching, and resolver delegation.
`packages/jest-runtime/src/internals/Resolution.ts`	Introduces the new helper class that centralizes runtime resolution behavior.
`packages/jest-runtime/src/index.ts`	Replaces in-class resolution logic and caches with the new `Resolution` abstraction throughout `Runtime`.
`packages/jest-resolve/src/resolver.ts`	Widens resolver config array types to `ReadonlyArray` and adds casts where mutable arrays are still required downstream.
`packages/jest-resolve/src/defaultResolver.ts`	Updates resolver option types for readonly arrays and adapts internal handoff to `unrs-resolver`.

pkg-pr-new · 2026-05-02T09:39:44Z

Open in StackBlitz

babel-jest

npm i https://pkg.pr.new/babel-jest@16081

babel-plugin-jest-hoist

npm i https://pkg.pr.new/babel-plugin-jest-hoist@16081

babel-preset-jest

npm i https://pkg.pr.new/babel-preset-jest@16081

create-jest

npm i https://pkg.pr.new/create-jest@16081

@jest/diff-sequences

npm i https://pkg.pr.new/@jest/diff-sequences@16081

expect

npm i https://pkg.pr.new/expect@16081

@jest/expect-utils

npm i https://pkg.pr.new/@jest/expect-utils@16081

jest

npm i https://pkg.pr.new/jest@16081

jest-changed-files

npm i https://pkg.pr.new/jest-changed-files@16081

jest-circus

npm i https://pkg.pr.new/jest-circus@16081

jest-cli

npm i https://pkg.pr.new/jest-cli@16081

jest-config

npm i https://pkg.pr.new/jest-config@16081

@jest/console

npm i https://pkg.pr.new/@jest/console@16081

@jest/core

npm i https://pkg.pr.new/@jest/core@16081

@jest/create-cache-key-function

npm i https://pkg.pr.new/@jest/create-cache-key-function@16081

jest-diff

npm i https://pkg.pr.new/jest-diff@16081

jest-docblock

npm i https://pkg.pr.new/jest-docblock@16081

jest-each

npm i https://pkg.pr.new/jest-each@16081

@jest/environment

npm i https://pkg.pr.new/@jest/environment@16081

jest-environment-jsdom

npm i https://pkg.pr.new/jest-environment-jsdom@16081

@jest/environment-jsdom-abstract

npm i https://pkg.pr.new/@jest/environment-jsdom-abstract@16081

jest-environment-node

npm i https://pkg.pr.new/jest-environment-node@16081

@jest/expect

npm i https://pkg.pr.new/@jest/expect@16081

@jest/fake-timers

npm i https://pkg.pr.new/@jest/fake-timers@16081

@jest/get-type

npm i https://pkg.pr.new/@jest/get-type@16081

@jest/globals

npm i https://pkg.pr.new/@jest/globals@16081

jest-haste-map

npm i https://pkg.pr.new/jest-haste-map@16081

jest-jasmine2

npm i https://pkg.pr.new/jest-jasmine2@16081

jest-leak-detector

npm i https://pkg.pr.new/jest-leak-detector@16081

jest-matcher-utils

npm i https://pkg.pr.new/jest-matcher-utils@16081

jest-message-util

npm i https://pkg.pr.new/jest-message-util@16081

jest-mock

npm i https://pkg.pr.new/jest-mock@16081

@jest/pattern

npm i https://pkg.pr.new/@jest/pattern@16081

jest-phabricator

npm i https://pkg.pr.new/jest-phabricator@16081

jest-regex-util

npm i https://pkg.pr.new/jest-regex-util@16081

@jest/reporters

npm i https://pkg.pr.new/@jest/reporters@16081

jest-resolve

npm i https://pkg.pr.new/jest-resolve@16081

jest-resolve-dependencies

npm i https://pkg.pr.new/jest-resolve-dependencies@16081

jest-runner

npm i https://pkg.pr.new/jest-runner@16081

jest-runtime

npm i https://pkg.pr.new/jest-runtime@16081

@jest/schemas

npm i https://pkg.pr.new/@jest/schemas@16081

jest-snapshot

npm i https://pkg.pr.new/jest-snapshot@16081

@jest/snapshot-utils

npm i https://pkg.pr.new/@jest/snapshot-utils@16081

@jest/source-map

npm i https://pkg.pr.new/@jest/source-map@16081

@jest/test-result

npm i https://pkg.pr.new/@jest/test-result@16081

@jest/test-sequencer

npm i https://pkg.pr.new/@jest/test-sequencer@16081

@jest/transform

npm i https://pkg.pr.new/@jest/transform@16081

@jest/types

npm i https://pkg.pr.new/@jest/types@16081

jest-util

npm i https://pkg.pr.new/jest-util@16081

jest-validate

npm i https://pkg.pr.new/jest-validate@16081

jest-watcher

npm i https://pkg.pr.new/jest-watcher@16081

jest-worker

npm i https://pkg.pr.new/jest-worker@16081

pretty-format

npm i https://pkg.pr.new/pretty-format@16081

commit: 0a51475

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.

+  conditions?: ReadonlyArray<string>;
  /** Instance of default resolver. */
  defaultResolver: SyncResolver;
  /** Instance of default async resolver. */
  defaultAsyncResolver: AsyncResolver;
+  /** List of file extensions to be considered when resolving. */
+  extensions?: ReadonlyArray<string>;


+  conditions?: ReadonlyArray<string>;
+  extensions?: ReadonlyArray<string>;
+  moduleDirectory?: ReadonlyArray<string>;
+  paths?: ReadonlyArray<string>;
  resolver?: string | null;
  rootDir?: string;
  throwIfNotFound?: boolean;
 };

 export type ResolveModuleConfig = {
-  conditions?: Array<string>;
+  conditions?: ReadonlyArray<string>;
  skipNodeResolution?: boolean;
-  paths?: Array<string>;
+  paths?: ReadonlyArray<string>;


| datasource | package | from | to | | ---------- | ------- | ------ | ------ | | npm | jest | 30.3.0 | 30.4.0 | ## [v30.4.0](https://github.com/jestjs/jest/blob/HEAD/CHANGELOG.md#3040) ##### Features - `[babel-jest]` Support collecting coverage from `.mts`, `.cts` (and other) files ([#15994](jestjs/jest#15994)) - `[jest-circus, jest-cli, jest-config, jest-core, jest-jasmine2, jest-types]` Add `--collect-tests` flag to discover and list tests without executing them ([#16006](jestjs/jest#16006)) - `[jest-config, jest-runner, jest-worker]` Add `workerGracefulExitTimeout` config option to control how long workers are given to exit before being force-killed ([#15984](jestjs/jest#15984)) - `[jest-config]` Add support for `jest.config.mts` as a valid configuration file ([#16005](jestjs/jest#16005)) - `[jest-config, jest-core, jest-reporters, jest-runner]` `verbose` and `silent` can now be set per-project; the project-level value overrides the global value for that project's tests ([#16133](jestjs/jest#16133)) - `[@jest/fake-timers]` Accept `Temporal.Duration` in `jest.advanceTimersByTime()` and `jest.advanceTimersByTimeAsync()` ([#16128](jestjs/jest#16128)) - `[@jest/fake-timers]` Accept `Temporal.Instant` and `Temporal.ZonedDateTime` in `jest.setSystemTime()` and `useFakeTimers({now})` ([#16128](jestjs/jest#16128)) - `[@jest/fake-timers]` Support faking `Temporal.Now.*` ([#16131](jestjs/jest#16131)) - `[jest-mock]` Add `clearMocksOnScope(scope)` on `ModuleMocker` for clearing every mock function exposed on a scope object ([#16088](jestjs/jest#16088)) - `[jest-resolve]` Add `canResolveSync()` on `Resolver` so callers can detect when a user-configured resolver only exports an `async` hook ([#16064](jestjs/jest#16064)) - `[jest-runtime]` Use synchronous `evaluate()` for ES modules without top-level `await` on Node versions that support it (v24.9+), and prefer the synchronous transform path when a sync transformer is configured ([#16062](jestjs/jest#16062)) - `[jest-runtime]` Support `require()` of ES modules on Node v24.9+ ([#16074](jestjs/jest#16074)) - `[jest-runtime]` Validate TC39 import attributes (`with { type: 'json' }`) on ESM imports ([#16127](jestjs/jest#16127)) - `[@jest/transform]` Add `canTransformSync(filename)` on `ScriptTransformer` so callers can pick the sync vs async transform path ([#16062](jestjs/jest#16062)) - `[jest-util]` Add `isError` helper ([#16076](jestjs/jest#16076)) - `[pretty-format]` Support React 19 ([#16123](jestjs/jest#16123)) ##### Fixes - `[expect-utils]` Fix `toStrictEqual` failing on `structuredClone` results due to cross-realm constructor mismatch ([#15959](jestjs/jest#15959)) - `[@jest/expect-utils]` Prevent `toMatchObject`/subset matching from throwing when encountering exotic iterables ([#15952](jestjs/jest#15952)) - `[fake-timers]` Convert `Date` to milliseconds before passing to `@sinonjs/fake-timers` ([#16029](jestjs/jest#16029)) - `[jest]` Export `GlobalConfig` and `ProjectConfig` TypeScript types ([#16132](jestjs/jest#16132)) - `[jest-circus]` Prevent crash when `asyncError` is undefined for non-Error throws ([#16003](jestjs/jest#16003)) - `[jest-circus, jest-jasmine2]` Include `Error.cause` in JSON `failureMessages` output ([#15967](jestjs/jest#15967)) - `[jest-config]` Fix preset path resolution on Windows when the preset uses subpath `exports` ([#15961](jestjs/jest#15961)) - `[jest-config]` Allow `collectCoverage` and `coverageProvider` in project config without a validation warning ([#16132](jestjs/jest#16132)) - `[jest-config]` Project config validator now emits "is not supported in an individual project configuration" instead of "probably a typing mistake" for known global-only options ([#16132](jestjs/jest#16132)) - `[jest-environment-node]` Fix `--localstorage-file` warning on Node 25+ ([#16086](jestjs/jest#16086)) - `[jest-reporters]` Apply global coverage threshold to unmatched pattern files in addition to glob/path thresholds ([#16137](jestjs/jest#16137)) - `[jest-reporters, jest-runner, jest-runtime, jest-transform]` Fix coverage report not showing correct code coverage when using `projects` config option ([#16140](jestjs/jest#16140)) - `[jest-runtime]` Resolve `expect` and `@jest/expect` from the internal module registry so test-file imports share the same `JestAssertionError` as the global `expect` ([#16130](jestjs/jest#16130)) - `[jest-runtime]` Improve CJS-from-ESM interop: `__esModule`/Babel default unwrap, broader named-export coverage, and shared CJS singleton across importers ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Load `.js` files with ESM syntax but no `"type":"module"` marker as native ESM ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Extend the `.js`-with-ESM-syntax fallback to `require()` on Node v24.9+ - falls back to `require(esm)` when the CJS parser rejects ESM syntax ([#16078](jestjs/jest#16078)) - `[jest-runtime]` Fix deadlocks and double-evaluation in concurrent ESM and wasm imports ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Fix error when `require()` is called after the Jest environment has been torn down ([#15951](jestjs/jest#15951)) - `[jest-runtime]` Fix missing error when `import()` is called after the Jest environment has been torn down ([#16080](jestjs/jest#16080)) - `[jest-runtime]` Fix virtual `unstable_mockModule` registrations not respected in ESM ([#16081](jestjs/jest#16081)) - `[jest-runtime]` Apply `moduleNameMapper` when resolving modules with `require.resolve()` and the `paths` option ([#16135](jestjs/jest#16135)) ##### Chore & Maintenance - `[@jest/fake-timers]` Upgrade `@sinonjs/fake-timers` ([#16139](jestjs/jest#16139)) - `[jest-runtime]` Use synchronous `linkRequests` / `instantiate` for ESM linking on Node v24.9+ ([#16063](jestjs/jest#16063))

| datasource | package | from | to | | ---------- | ------- | ------ | ------ | | npm | jest | 30.3.0 | 30.4.2 | ## [v30.4.2](https://github.com/jestjs/jest/blob/HEAD/CHANGELOG.md#3042) ##### Fixes - `[jest-runtime]` Fix named imports from CJS modules whose `module.exports` is a function with own-property exports ([#16150](jestjs/jest#16150)) ## [v30.4.1](https://github.com/jestjs/jest/blob/HEAD/CHANGELOG.md#3041) ##### Features - `[jest-config, jest-core, jest-runner, jest-schemas, jest-types]` Allow custom runner configuration options via tuple format `['runner-path', {options}]` ([#16141](jestjs/jest#16141)) ##### Fixes - `[jest-runtime]` Align CJS-from-ESM default export with Node: `module.exports` is always the ESM default, `__esModule` unwrapping is no longer applied ([#16143](jestjs/jest#16143)) ## [v30.4.0](https://github.com/jestjs/jest/blob/HEAD/CHANGELOG.md#3040) ##### Features - `[babel-jest]` Support collecting coverage from `.mts`, `.cts` (and other) files ([#15994](jestjs/jest#15994)) - `[jest-circus, jest-cli, jest-config, jest-core, jest-jasmine2, jest-types]` Add `--collect-tests` flag to discover and list tests without executing them ([#16006](jestjs/jest#16006)) - `[jest-config, jest-runner, jest-worker]` Add `workerGracefulExitTimeout` config option to control how long workers are given to exit before being force-killed ([#15984](jestjs/jest#15984)) - `[jest-config]` Add support for `jest.config.mts` as a valid configuration file ([#16005](jestjs/jest#16005)) - `[jest-config, jest-core, jest-reporters, jest-runner]` `verbose` and `silent` can now be set per-project; the project-level value overrides the global value for that project's tests ([#16133](jestjs/jest#16133)) - `[@jest/fake-timers]` Accept `Temporal.Duration` in `jest.advanceTimersByTime()` and `jest.advanceTimersByTimeAsync()` ([#16128](jestjs/jest#16128)) - `[@jest/fake-timers]` Accept `Temporal.Instant` and `Temporal.ZonedDateTime` in `jest.setSystemTime()` and `useFakeTimers({now})` ([#16128](jestjs/jest#16128)) - `[@jest/fake-timers]` Support faking `Temporal.Now.*` ([#16131](jestjs/jest#16131)) - `[jest-mock]` Add `clearMocksOnScope(scope)` on `ModuleMocker` for clearing every mock function exposed on a scope object ([#16088](jestjs/jest#16088)) - `[jest-resolve]` Add `canResolveSync()` on `Resolver` so callers can detect when a user-configured resolver only exports an `async` hook ([#16064](jestjs/jest#16064)) - `[jest-runtime]` Use synchronous `evaluate()` for ES modules without top-level `await` on Node versions that support it (v24.9+), and prefer the synchronous transform path when a sync transformer is configured ([#16062](jestjs/jest#16062)) - `[jest-runtime]` Support `require()` of ES modules on Node v24.9+ ([#16074](jestjs/jest#16074)) - `[jest-runtime]` Validate TC39 import attributes (`with { type: 'json' }`) on ESM imports ([#16127](jestjs/jest#16127)) - `[@jest/transform]` Add `canTransformSync(filename)` on `ScriptTransformer` so callers can pick the sync vs async transform path ([#16062](jestjs/jest#16062)) - `[jest-util]` Add `isError` helper ([#16076](jestjs/jest#16076)) - `[pretty-format]` Support React 19 ([#16123](jestjs/jest#16123)) ##### Fixes - `[expect-utils]` Fix `toStrictEqual` failing on `structuredClone` results due to cross-realm constructor mismatch ([#15959](jestjs/jest#15959)) - `[@jest/expect-utils]` Prevent `toMatchObject`/subset matching from throwing when encountering exotic iterables ([#15952](jestjs/jest#15952)) - `[fake-timers]` Convert `Date` to milliseconds before passing to `@sinonjs/fake-timers` ([#16029](jestjs/jest#16029)) - `[jest]` Export `GlobalConfig` and `ProjectConfig` TypeScript types ([#16132](jestjs/jest#16132)) - `[jest-circus]` Prevent crash when `asyncError` is undefined for non-Error throws ([#16003](jestjs/jest#16003)) - `[jest-circus, jest-jasmine2]` Include `Error.cause` in JSON `failureMessages` output ([#15967](jestjs/jest#15967)) - `[jest-config]` Fix preset path resolution on Windows when the preset uses subpath `exports` ([#15961](jestjs/jest#15961)) - `[jest-config]` Allow `collectCoverage` and `coverageProvider` in project config without a validation warning ([#16132](jestjs/jest#16132)) - `[jest-config]` Project config validator now emits "is not supported in an individual project configuration" instead of "probably a typing mistake" for known global-only options ([#16132](jestjs/jest#16132)) - `[jest-environment-node]` Fix `--localstorage-file` warning on Node 25+ ([#16086](jestjs/jest#16086)) - `[jest-reporters]` Apply global coverage threshold to unmatched pattern files in addition to glob/path thresholds ([#16137](jestjs/jest#16137)) - `[jest-reporters, jest-runner, jest-runtime, jest-transform]` Fix coverage report not showing correct code coverage when using `projects` config option ([#16140](jestjs/jest#16140)) - `[jest-runtime]` Resolve `expect` and `@jest/expect` from the internal module registry so test-file imports share the same `JestAssertionError` as the global `expect` ([#16130](jestjs/jest#16130)) - `[jest-runtime]` Improve CJS-from-ESM interop: `__esModule`/Babel default unwrap, broader named-export coverage, and shared CJS singleton across importers ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Load `.js` files with ESM syntax but no `"type":"module"` marker as native ESM ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Extend the `.js`-with-ESM-syntax fallback to `require()` on Node v24.9+ - falls back to `require(esm)` when the CJS parser rejects ESM syntax ([#16078](jestjs/jest#16078)) - `[jest-runtime]` Fix deadlocks and double-evaluation in concurrent ESM and wasm imports ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Fix error when `require()` is called after the Jest environment has been torn down ([#15951](jestjs/jest#15951)) - `[jest-runtime]` Fix missing error when `import()` is called after the Jest environment has been torn down ([#16080](jestjs/jest#16080)) - `[jest-runtime]` Fix virtual `unstable_mockModule` registrations not respected in ESM ([#16081](jestjs/jest#16081)) - `[jest-runtime]` Apply `moduleNameMapper` when resolving modules with `require.resolve()` and the `paths` option ([#16135](jestjs/jest#16135)) ##### Chore & Maintenance - `[@jest/fake-timers]` Upgrade `@sinonjs/fake-timers` ([#16139](jestjs/jest#16139)) - `[jest-runtime]` Use synchronous `linkRequests` / `instantiate` for ESM linking on Node v24.9+ ([#16063](jestjs/jest#16063))

chore: split out resolution from runtime class

5af464d

Copilot AI review requested due to automatic review settings May 2, 2026 09:29

Copilot started reviewing on behalf of SimenB May 2, 2026 09:30 View session

inline

7d73743

Copilot AI reviewed May 2, 2026

View reviewed changes

Comment thread packages/jest-runtime/src/index.ts

Comment thread packages/jest-runtime/src/index.ts

SimenB added 9 commits May 2, 2026 11:40

mock bug fix

01b8d2a

changelog

7602ac7

also do file cache

af556c5

type tests

2056676

and v8 coverage

eaddbd3

and cjs export analysis

8464a8e

shouldLoadAsEsm as well

3c7957e

types in new tests

1a7b0fc

fix windows test

0a51475

SimenB requested a review from Copilot May 2, 2026 10:57

Copilot started reviewing on behalf of SimenB May 2, 2026 10:58 View session

Copilot AI reviewed May 2, 2026

View reviewed changes

SimenB merged commit 140849e into jestjs:main May 2, 2026
79 checks passed

SimenB deleted the runtime-refactor-resolvercache branch May 2, 2026 11:03

SimenB mentioned this pull request May 2, 2026

chore(runtime): extract transform cache and mock registries #16082

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: split out resolution from runtime class#16081

chore: split out resolution from runtime class#16081
SimenB merged 11 commits into
jestjs:mainfrom
SimenB:runtime-refactor-resolvercache

SimenB commented May 2, 2026 •

edited

Loading

Uh oh!

netlify Bot commented May 2, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

pkg-pr-new Bot commented May 2, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

SimenB commented May 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

netlify Bot commented May 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for jestjs ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

pkg-pr-new Bot commented May 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

SimenB commented May 2, 2026 •

edited

Loading

netlify Bot commented May 2, 2026 •

edited

Loading

pkg-pr-new Bot commented May 2, 2026 •

edited

Loading