Codestin Search App

SimenB · 2026-05-05T22:22:05Z

Summary

Needs sinonjs/fake-timers#574 as well, should be good to go beyond that

Test plan

Green CI

netlify · 2026-05-05T22:22:11Z

✅ Deploy Preview for jestjs ready!

Name	Link
🔨 Latest commit	`60df7f5`
🔍 Latest deploy log	https://app.netlify.com/projects/jestjs/deploys/69fc3a9602ebc900085e8f4e
😎 Deploy Preview	https://deploy-preview-16131--jestjs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds Temporal support to Jest fake timers by upgrading @sinonjs/fake-timers and wiring Temporal into the fakeable API set, plus coverage to ensure Temporal.Now.* follows the faked clock.

Changes:

Bump @sinonjs/fake-timers to ^15.4.0 and remove external @types/sinonjs__fake-timers
Add 'Temporal' to the supported fakeable APIs and update public typings accordingly
Add E2E tests validating Temporal.Now.* behavior under fake timers + setSystemTime

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
yarn.lock	Updates lockfile for the `@sinonjs/fake-timers` bump and removes the separate `@types` entry
packages/jest-types/src/Config.ts	Extends fakeable API union to include `Temporal`
packages/jest-fake-timers/src/temporalUtils.ts	Removes local Temporal duck-typing utilities
packages/jest-fake-timers/src/modernFakeTimers.ts	Switches to Sinon Temporal-related types and forwards `now`/`setSystemTime` without normalizing
packages/jest-fake-timers/src/legacyFakeTimers.ts	Inlines Temporal-duration-to-ms conversion
packages/jest-fake-timers/src/index.ts	Re-exports Sinon Temporal types under existing “Like” names
packages/jest-fake-timers/src/tests/sinon-integration.test.ts	Updates expectation for `now` to be a `Date` object
packages/jest-fake-timers/src/tests/modernFakeTimers.test.ts	Adjusts Temporal-duration tests and imports Sinon Temporal type
packages/jest-fake-timers/package.json	Bumps Sinon dependency and drops `@types/sinonjs__fake-timers`
packages/jest-environment/src/index.ts	Updates Jest public interface types for Temporal duration/epoch inputs
e2e/fake-timers-temporal/tests/temporal.test.js	Adds coverage for faking `Temporal.Now.*` and interaction with `setSystemTime`
docs/JestObjectAPI.md	Documents faking `Temporal` and updates FakeableAPI union

+export type {
+  TemporalDuration as TemporalDurationLike,
+  TemporalTimelike as TemporalEpochLike,
+} from '@sinonjs/fake-timers';


+  setSystemTime(now?: number | Date | TemporalTimelike): void {
    if (this._checkFakeTimers()) {
-      this._clock.setSystemTime(toEpochMs(now));
+      this._clock.setSystemTime(now);
    }
  }


+  advanceTimersByTime(msToRun: number | TemporalDuration): void {
    if (this._checkFakeTimers()) {
-      this._clock.tick(toDurationMs(msToRun));
+      // TODO: pass msToRun directly once https://github.com/sinonjs/fake-timers/pull/574 is published
+      this._clock.tick(
+        typeof msToRun === 'number'
+          ? msToRun
+          : msToRun.total({unit: 'millisecond'}),
+      );
    }
  }

  async advanceTimersByTimeAsync(
-    msToRun: number | TemporalDurationLike,
+    msToRun: number | TemporalDuration,
  ): Promise<void> {
    if (this._checkFakeTimers()) {
-      await this._clock.tickAsync(toDurationMs(msToRun));
+      // TODO: pass msToRun directly once https://github.com/sinonjs/fake-timers/pull/574 is published
+      await this._clock.tickAsync(
+        typeof msToRun === 'number'
+          ? msToRun
+          : msToRun.total({unit: 'millisecond'}),
+      );


pkg-pr-new · 2026-05-07T06:11:05Z

Open in StackBlitz

babel-jest

npm i https://pkg.pr.new/babel-jest@16131

babel-plugin-jest-hoist

npm i https://pkg.pr.new/babel-plugin-jest-hoist@16131

babel-preset-jest

npm i https://pkg.pr.new/babel-preset-jest@16131

create-jest

npm i https://pkg.pr.new/create-jest@16131

@jest/diff-sequences

npm i https://pkg.pr.new/@jest/diff-sequences@16131

expect

npm i https://pkg.pr.new/expect@16131

@jest/expect-utils

npm i https://pkg.pr.new/@jest/expect-utils@16131

jest

npm i https://pkg.pr.new/jest@16131

jest-changed-files

npm i https://pkg.pr.new/jest-changed-files@16131

jest-circus

npm i https://pkg.pr.new/jest-circus@16131

jest-cli

npm i https://pkg.pr.new/jest-cli@16131

jest-config

npm i https://pkg.pr.new/jest-config@16131

@jest/console

npm i https://pkg.pr.new/@jest/console@16131

@jest/core

npm i https://pkg.pr.new/@jest/core@16131

@jest/create-cache-key-function

npm i https://pkg.pr.new/@jest/create-cache-key-function@16131

jest-diff

npm i https://pkg.pr.new/jest-diff@16131

jest-docblock

npm i https://pkg.pr.new/jest-docblock@16131

jest-each

npm i https://pkg.pr.new/jest-each@16131

@jest/environment

npm i https://pkg.pr.new/@jest/environment@16131

jest-environment-jsdom

npm i https://pkg.pr.new/jest-environment-jsdom@16131

@jest/environment-jsdom-abstract

npm i https://pkg.pr.new/@jest/environment-jsdom-abstract@16131

jest-environment-node

npm i https://pkg.pr.new/jest-environment-node@16131

@jest/expect

npm i https://pkg.pr.new/@jest/expect@16131

@jest/fake-timers

npm i https://pkg.pr.new/@jest/fake-timers@16131

@jest/get-type

npm i https://pkg.pr.new/@jest/get-type@16131

@jest/globals

npm i https://pkg.pr.new/@jest/globals@16131

jest-haste-map

npm i https://pkg.pr.new/jest-haste-map@16131

jest-jasmine2

npm i https://pkg.pr.new/jest-jasmine2@16131

jest-leak-detector

npm i https://pkg.pr.new/jest-leak-detector@16131

jest-matcher-utils

npm i https://pkg.pr.new/jest-matcher-utils@16131

jest-message-util

npm i https://pkg.pr.new/jest-message-util@16131

jest-mock

npm i https://pkg.pr.new/jest-mock@16131

@jest/pattern

npm i https://pkg.pr.new/@jest/pattern@16131

jest-phabricator

npm i https://pkg.pr.new/jest-phabricator@16131

jest-regex-util

npm i https://pkg.pr.new/jest-regex-util@16131

@jest/reporters

npm i https://pkg.pr.new/@jest/reporters@16131

jest-resolve

npm i https://pkg.pr.new/jest-resolve@16131

jest-resolve-dependencies

npm i https://pkg.pr.new/jest-resolve-dependencies@16131

jest-runner

npm i https://pkg.pr.new/jest-runner@16131

jest-runtime

npm i https://pkg.pr.new/jest-runtime@16131

@jest/schemas

npm i https://pkg.pr.new/@jest/schemas@16131

jest-snapshot

npm i https://pkg.pr.new/jest-snapshot@16131

@jest/snapshot-utils

npm i https://pkg.pr.new/@jest/snapshot-utils@16131

@jest/source-map

npm i https://pkg.pr.new/@jest/source-map@16131

@jest/test-result

npm i https://pkg.pr.new/@jest/test-result@16131

@jest/test-sequencer

npm i https://pkg.pr.new/@jest/test-sequencer@16131

@jest/transform

npm i https://pkg.pr.new/@jest/transform@16131

@jest/types

npm i https://pkg.pr.new/@jest/types@16131

jest-util

npm i https://pkg.pr.new/jest-util@16131

jest-validate

npm i https://pkg.pr.new/jest-validate@16131

jest-watcher

npm i https://pkg.pr.new/jest-watcher@16131

jest-worker

npm i https://pkg.pr.new/jest-worker@16131

pretty-format

npm i https://pkg.pr.new/pretty-format@16131

commit: 60df7f5

SimenB · 2026-05-07T19:07:07Z

https://github.com/jestjs/jest/releases/tag/v30.4.0

| datasource | package | from | to | | ---------- | ------- | ------ | ------ | | npm | jest | 30.3.0 | 30.4.0 | ## [v30.4.0](https://github.com/jestjs/jest/blob/HEAD/CHANGELOG.md#3040) ##### Features - `[babel-jest]` Support collecting coverage from `.mts`, `.cts` (and other) files ([#15994](jestjs/jest#15994)) - `[jest-circus, jest-cli, jest-config, jest-core, jest-jasmine2, jest-types]` Add `--collect-tests` flag to discover and list tests without executing them ([#16006](jestjs/jest#16006)) - `[jest-config, jest-runner, jest-worker]` Add `workerGracefulExitTimeout` config option to control how long workers are given to exit before being force-killed ([#15984](jestjs/jest#15984)) - `[jest-config]` Add support for `jest.config.mts` as a valid configuration file ([#16005](jestjs/jest#16005)) - `[jest-config, jest-core, jest-reporters, jest-runner]` `verbose` and `silent` can now be set per-project; the project-level value overrides the global value for that project's tests ([#16133](jestjs/jest#16133)) - `[@jest/fake-timers]` Accept `Temporal.Duration` in `jest.advanceTimersByTime()` and `jest.advanceTimersByTimeAsync()` ([#16128](jestjs/jest#16128)) - `[@jest/fake-timers]` Accept `Temporal.Instant` and `Temporal.ZonedDateTime` in `jest.setSystemTime()` and `useFakeTimers({now})` ([#16128](jestjs/jest#16128)) - `[@jest/fake-timers]` Support faking `Temporal.Now.*` ([#16131](jestjs/jest#16131)) - `[jest-mock]` Add `clearMocksOnScope(scope)` on `ModuleMocker` for clearing every mock function exposed on a scope object ([#16088](jestjs/jest#16088)) - `[jest-resolve]` Add `canResolveSync()` on `Resolver` so callers can detect when a user-configured resolver only exports an `async` hook ([#16064](jestjs/jest#16064)) - `[jest-runtime]` Use synchronous `evaluate()` for ES modules without top-level `await` on Node versions that support it (v24.9+), and prefer the synchronous transform path when a sync transformer is configured ([#16062](jestjs/jest#16062)) - `[jest-runtime]` Support `require()` of ES modules on Node v24.9+ ([#16074](jestjs/jest#16074)) - `[jest-runtime]` Validate TC39 import attributes (`with { type: 'json' }`) on ESM imports ([#16127](jestjs/jest#16127)) - `[@jest/transform]` Add `canTransformSync(filename)` on `ScriptTransformer` so callers can pick the sync vs async transform path ([#16062](jestjs/jest#16062)) - `[jest-util]` Add `isError` helper ([#16076](jestjs/jest#16076)) - `[pretty-format]` Support React 19 ([#16123](jestjs/jest#16123)) ##### Fixes - `[expect-utils]` Fix `toStrictEqual` failing on `structuredClone` results due to cross-realm constructor mismatch ([#15959](jestjs/jest#15959)) - `[@jest/expect-utils]` Prevent `toMatchObject`/subset matching from throwing when encountering exotic iterables ([#15952](jestjs/jest#15952)) - `[fake-timers]` Convert `Date` to milliseconds before passing to `@sinonjs/fake-timers` ([#16029](jestjs/jest#16029)) - `[jest]` Export `GlobalConfig` and `ProjectConfig` TypeScript types ([#16132](jestjs/jest#16132)) - `[jest-circus]` Prevent crash when `asyncError` is undefined for non-Error throws ([#16003](jestjs/jest#16003)) - `[jest-circus, jest-jasmine2]` Include `Error.cause` in JSON `failureMessages` output ([#15967](jestjs/jest#15967)) - `[jest-config]` Fix preset path resolution on Windows when the preset uses subpath `exports` ([#15961](jestjs/jest#15961)) - `[jest-config]` Allow `collectCoverage` and `coverageProvider` in project config without a validation warning ([#16132](jestjs/jest#16132)) - `[jest-config]` Project config validator now emits "is not supported in an individual project configuration" instead of "probably a typing mistake" for known global-only options ([#16132](jestjs/jest#16132)) - `[jest-environment-node]` Fix `--localstorage-file` warning on Node 25+ ([#16086](jestjs/jest#16086)) - `[jest-reporters]` Apply global coverage threshold to unmatched pattern files in addition to glob/path thresholds ([#16137](jestjs/jest#16137)) - `[jest-reporters, jest-runner, jest-runtime, jest-transform]` Fix coverage report not showing correct code coverage when using `projects` config option ([#16140](jestjs/jest#16140)) - `[jest-runtime]` Resolve `expect` and `@jest/expect` from the internal module registry so test-file imports share the same `JestAssertionError` as the global `expect` ([#16130](jestjs/jest#16130)) - `[jest-runtime]` Improve CJS-from-ESM interop: `__esModule`/Babel default unwrap, broader named-export coverage, and shared CJS singleton across importers ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Load `.js` files with ESM syntax but no `"type":"module"` marker as native ESM ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Extend the `.js`-with-ESM-syntax fallback to `require()` on Node v24.9+ - falls back to `require(esm)` when the CJS parser rejects ESM syntax ([#16078](jestjs/jest#16078)) - `[jest-runtime]` Fix deadlocks and double-evaluation in concurrent ESM and wasm imports ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Fix error when `require()` is called after the Jest environment has been torn down ([#15951](jestjs/jest#15951)) - `[jest-runtime]` Fix missing error when `import()` is called after the Jest environment has been torn down ([#16080](jestjs/jest#16080)) - `[jest-runtime]` Fix virtual `unstable_mockModule` registrations not respected in ESM ([#16081](jestjs/jest#16081)) - `[jest-runtime]` Apply `moduleNameMapper` when resolving modules with `require.resolve()` and the `paths` option ([#16135](jestjs/jest#16135)) ##### Chore & Maintenance - `[@jest/fake-timers]` Upgrade `@sinonjs/fake-timers` ([#16139](jestjs/jest#16139)) - `[jest-runtime]` Use synchronous `linkRequests` / `instantiate` for ESM linking on Node v24.9+ ([#16063](jestjs/jest#16063))

| datasource | package | from | to | | ---------- | ------- | ------ | ------ | | npm | jest | 30.3.0 | 30.4.2 | ## [v30.4.2](https://github.com/jestjs/jest/blob/HEAD/CHANGELOG.md#3042) ##### Fixes - `[jest-runtime]` Fix named imports from CJS modules whose `module.exports` is a function with own-property exports ([#16150](jestjs/jest#16150)) ## [v30.4.1](https://github.com/jestjs/jest/blob/HEAD/CHANGELOG.md#3041) ##### Features - `[jest-config, jest-core, jest-runner, jest-schemas, jest-types]` Allow custom runner configuration options via tuple format `['runner-path', {options}]` ([#16141](jestjs/jest#16141)) ##### Fixes - `[jest-runtime]` Align CJS-from-ESM default export with Node: `module.exports` is always the ESM default, `__esModule` unwrapping is no longer applied ([#16143](jestjs/jest#16143)) ## [v30.4.0](https://github.com/jestjs/jest/blob/HEAD/CHANGELOG.md#3040) ##### Features - `[babel-jest]` Support collecting coverage from `.mts`, `.cts` (and other) files ([#15994](jestjs/jest#15994)) - `[jest-circus, jest-cli, jest-config, jest-core, jest-jasmine2, jest-types]` Add `--collect-tests` flag to discover and list tests without executing them ([#16006](jestjs/jest#16006)) - `[jest-config, jest-runner, jest-worker]` Add `workerGracefulExitTimeout` config option to control how long workers are given to exit before being force-killed ([#15984](jestjs/jest#15984)) - `[jest-config]` Add support for `jest.config.mts` as a valid configuration file ([#16005](jestjs/jest#16005)) - `[jest-config, jest-core, jest-reporters, jest-runner]` `verbose` and `silent` can now be set per-project; the project-level value overrides the global value for that project's tests ([#16133](jestjs/jest#16133)) - `[@jest/fake-timers]` Accept `Temporal.Duration` in `jest.advanceTimersByTime()` and `jest.advanceTimersByTimeAsync()` ([#16128](jestjs/jest#16128)) - `[@jest/fake-timers]` Accept `Temporal.Instant` and `Temporal.ZonedDateTime` in `jest.setSystemTime()` and `useFakeTimers({now})` ([#16128](jestjs/jest#16128)) - `[@jest/fake-timers]` Support faking `Temporal.Now.*` ([#16131](jestjs/jest#16131)) - `[jest-mock]` Add `clearMocksOnScope(scope)` on `ModuleMocker` for clearing every mock function exposed on a scope object ([#16088](jestjs/jest#16088)) - `[jest-resolve]` Add `canResolveSync()` on `Resolver` so callers can detect when a user-configured resolver only exports an `async` hook ([#16064](jestjs/jest#16064)) - `[jest-runtime]` Use synchronous `evaluate()` for ES modules without top-level `await` on Node versions that support it (v24.9+), and prefer the synchronous transform path when a sync transformer is configured ([#16062](jestjs/jest#16062)) - `[jest-runtime]` Support `require()` of ES modules on Node v24.9+ ([#16074](jestjs/jest#16074)) - `[jest-runtime]` Validate TC39 import attributes (`with { type: 'json' }`) on ESM imports ([#16127](jestjs/jest#16127)) - `[@jest/transform]` Add `canTransformSync(filename)` on `ScriptTransformer` so callers can pick the sync vs async transform path ([#16062](jestjs/jest#16062)) - `[jest-util]` Add `isError` helper ([#16076](jestjs/jest#16076)) - `[pretty-format]` Support React 19 ([#16123](jestjs/jest#16123)) ##### Fixes - `[expect-utils]` Fix `toStrictEqual` failing on `structuredClone` results due to cross-realm constructor mismatch ([#15959](jestjs/jest#15959)) - `[@jest/expect-utils]` Prevent `toMatchObject`/subset matching from throwing when encountering exotic iterables ([#15952](jestjs/jest#15952)) - `[fake-timers]` Convert `Date` to milliseconds before passing to `@sinonjs/fake-timers` ([#16029](jestjs/jest#16029)) - `[jest]` Export `GlobalConfig` and `ProjectConfig` TypeScript types ([#16132](jestjs/jest#16132)) - `[jest-circus]` Prevent crash when `asyncError` is undefined for non-Error throws ([#16003](jestjs/jest#16003)) - `[jest-circus, jest-jasmine2]` Include `Error.cause` in JSON `failureMessages` output ([#15967](jestjs/jest#15967)) - `[jest-config]` Fix preset path resolution on Windows when the preset uses subpath `exports` ([#15961](jestjs/jest#15961)) - `[jest-config]` Allow `collectCoverage` and `coverageProvider` in project config without a validation warning ([#16132](jestjs/jest#16132)) - `[jest-config]` Project config validator now emits "is not supported in an individual project configuration" instead of "probably a typing mistake" for known global-only options ([#16132](jestjs/jest#16132)) - `[jest-environment-node]` Fix `--localstorage-file` warning on Node 25+ ([#16086](jestjs/jest#16086)) - `[jest-reporters]` Apply global coverage threshold to unmatched pattern files in addition to glob/path thresholds ([#16137](jestjs/jest#16137)) - `[jest-reporters, jest-runner, jest-runtime, jest-transform]` Fix coverage report not showing correct code coverage when using `projects` config option ([#16140](jestjs/jest#16140)) - `[jest-runtime]` Resolve `expect` and `@jest/expect` from the internal module registry so test-file imports share the same `JestAssertionError` as the global `expect` ([#16130](jestjs/jest#16130)) - `[jest-runtime]` Improve CJS-from-ESM interop: `__esModule`/Babel default unwrap, broader named-export coverage, and shared CJS singleton across importers ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Load `.js` files with ESM syntax but no `"type":"module"` marker as native ESM ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Extend the `.js`-with-ESM-syntax fallback to `require()` on Node v24.9+ - falls back to `require(esm)` when the CJS parser rejects ESM syntax ([#16078](jestjs/jest#16078)) - `[jest-runtime]` Fix deadlocks and double-evaluation in concurrent ESM and wasm imports ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Fix error when `require()` is called after the Jest environment has been torn down ([#15951](jestjs/jest#15951)) - `[jest-runtime]` Fix missing error when `import()` is called after the Jest environment has been torn down ([#16080](jestjs/jest#16080)) - `[jest-runtime]` Fix virtual `unstable_mockModule` registrations not respected in ESM ([#16081](jestjs/jest#16081)) - `[jest-runtime]` Apply `moduleNameMapper` when resolving modules with `require.resolve()` and the `paths` option ([#16135](jestjs/jest#16135)) ##### Chore & Maintenance - `[@jest/fake-timers]` Upgrade `@sinonjs/fake-timers` ([#16139](jestjs/jest#16139)) - `[jest-runtime]` Use synchronous `linkRequests` / `instantiate` for ESM linking on Node v24.9+ ([#16063](jestjs/jest#16063))

SimenB added 2 commits May 5, 2026 23:39

chore: update @sinonjs/fake-timers

44888a8

fix: verify mocking Temporal works

14231c0

SimenB changed the title ~~Fake timers temporal~~ feat(fake-timers): support mocking Temporal.Now time May 5, 2026

SimenB added 2 commits May 7, 2026 07:19

do not wait for upstream

15de3e3

Merge branch 'main' into fake-timers-temporal

fe1e9e1

SimenB marked this pull request as ready for review May 7, 2026 05:23

SimenB requested a review from Copilot May 7, 2026 05:24

Copilot AI reviewed May 7, 2026

View reviewed changes

Copilot started reviewing on behalf of SimenB May 7, 2026 05:37 View session

missing from schema

ee1c7a1

meh

bf64dfd

SimenB mentioned this pull request May 7, 2026

chore: update @sinonjs/fake-timers #16139

Merged

SimenB added 2 commits May 7, 2026 09:08

Merge branch 'main' into fake-timers-temporal

10f36d8

changelog

60df7f5

SimenB merged commit 24334c9 into jestjs:main May 7, 2026
90 checks passed

SimenB deleted the fake-timers-temporal branch May 7, 2026 08:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(fake-timers): support mocking `Temporal.Now` time#16131

feat(fake-timers): support mocking `Temporal.Now` time#16131
SimenB merged 8 commits into
jestjs:mainfrom
SimenB:fake-timers-temporal

SimenB commented May 5, 2026

Uh oh!

netlify Bot commented May 5, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pkg-pr-new Bot commented May 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

SimenB commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

SimenB commented May 5, 2026

Summary

Test plan

Uh oh!

netlify Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for jestjs ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pkg-pr-new Bot commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

SimenB commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify Bot commented May 5, 2026 •

edited

Loading

pkg-pr-new Bot commented May 7, 2026 •

edited

Loading