Codestin Search App

SimenB · 2026-05-05T21:47:27Z

Summary

Test plan

Tests added

netlify · 2026-05-05T21:47:33Z

✅ Deploy Preview for jestjs ready!

Name	Link
🔨 Latest commit	`24388a8`
🔍 Latest deploy log	https://app.netlify.com/projects/jestjs/deploys/69fae92a98c1ee00088fc2ad
😎 Deploy Preview	https://deploy-preview-16130--jestjs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

pkg-pr-new · 2026-05-05T21:53:47Z

Open in StackBlitz

babel-jest

npm i https://pkg.pr.new/babel-jest@16130

babel-plugin-jest-hoist

npm i https://pkg.pr.new/babel-plugin-jest-hoist@16130

babel-preset-jest

npm i https://pkg.pr.new/babel-preset-jest@16130

create-jest

npm i https://pkg.pr.new/create-jest@16130

@jest/diff-sequences

npm i https://pkg.pr.new/@jest/diff-sequences@16130

expect

npm i https://pkg.pr.new/expect@16130

@jest/expect-utils

npm i https://pkg.pr.new/@jest/expect-utils@16130

jest

npm i https://pkg.pr.new/jest@16130

jest-changed-files

npm i https://pkg.pr.new/jest-changed-files@16130

jest-circus

npm i https://pkg.pr.new/jest-circus@16130

jest-cli

npm i https://pkg.pr.new/jest-cli@16130

jest-config

npm i https://pkg.pr.new/jest-config@16130

@jest/console

npm i https://pkg.pr.new/@jest/console@16130

@jest/core

npm i https://pkg.pr.new/@jest/core@16130

@jest/create-cache-key-function

npm i https://pkg.pr.new/@jest/create-cache-key-function@16130

jest-diff

npm i https://pkg.pr.new/jest-diff@16130

jest-docblock

npm i https://pkg.pr.new/jest-docblock@16130

jest-each

npm i https://pkg.pr.new/jest-each@16130

@jest/environment

npm i https://pkg.pr.new/@jest/environment@16130

jest-environment-jsdom

npm i https://pkg.pr.new/jest-environment-jsdom@16130

@jest/environment-jsdom-abstract

npm i https://pkg.pr.new/@jest/environment-jsdom-abstract@16130

jest-environment-node

npm i https://pkg.pr.new/jest-environment-node@16130

@jest/expect

npm i https://pkg.pr.new/@jest/expect@16130

@jest/fake-timers

npm i https://pkg.pr.new/@jest/fake-timers@16130

@jest/get-type

npm i https://pkg.pr.new/@jest/get-type@16130

@jest/globals

npm i https://pkg.pr.new/@jest/globals@16130

jest-haste-map

npm i https://pkg.pr.new/jest-haste-map@16130

jest-jasmine2

npm i https://pkg.pr.new/jest-jasmine2@16130

jest-leak-detector

npm i https://pkg.pr.new/jest-leak-detector@16130

jest-matcher-utils

npm i https://pkg.pr.new/jest-matcher-utils@16130

jest-message-util

npm i https://pkg.pr.new/jest-message-util@16130

jest-mock

npm i https://pkg.pr.new/jest-mock@16130

@jest/pattern

npm i https://pkg.pr.new/@jest/pattern@16130

jest-phabricator

npm i https://pkg.pr.new/jest-phabricator@16130

jest-regex-util

npm i https://pkg.pr.new/jest-regex-util@16130

@jest/reporters

npm i https://pkg.pr.new/@jest/reporters@16130

jest-resolve

npm i https://pkg.pr.new/jest-resolve@16130

jest-resolve-dependencies

npm i https://pkg.pr.new/jest-resolve-dependencies@16130

jest-runner

npm i https://pkg.pr.new/jest-runner@16130

jest-runtime

npm i https://pkg.pr.new/jest-runtime@16130

@jest/schemas

npm i https://pkg.pr.new/@jest/schemas@16130

jest-snapshot

npm i https://pkg.pr.new/jest-snapshot@16130

@jest/snapshot-utils

npm i https://pkg.pr.new/@jest/snapshot-utils@16130

@jest/source-map

npm i https://pkg.pr.new/@jest/source-map@16130

@jest/test-result

npm i https://pkg.pr.new/@jest/test-result@16130

@jest/test-sequencer

npm i https://pkg.pr.new/@jest/test-sequencer@16130

@jest/transform

npm i https://pkg.pr.new/@jest/transform@16130

@jest/types

npm i https://pkg.pr.new/@jest/types@16130

jest-util

npm i https://pkg.pr.new/jest-util@16130

jest-validate

npm i https://pkg.pr.new/jest-validate@16130

jest-watcher

npm i https://pkg.pr.new/jest-watcher@16130

jest-worker

npm i https://pkg.pr.new/jest-worker@16130

pretty-format

npm i https://pkg.pr.new/pretty-format@16130

commit: 24388a8

Copilot

Pull request overview

This PR updates expect(...).toThrow(SomeClass) to better handle exceptions whose constructor comes from a different realm/module registry, which is relevant in Jest because the injected global expect and a test’s own imported expect classes can be distinct objects.

Changes:

Added a cross-realm fallback in toThrow’s class-matching path by walking the thrown value’s prototype chain and comparing constructor names.
Added unit tests and snapshot coverage for cross-realm class matching behavior.
Added an e2e regression fixture/test for JestAssertionError plus a changelog entry for the fix.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`packages/expect/src/toThrowMatchers.ts`	Adds the new cross-realm class-matching helper and uses it in `toThrow(SomeClass)`.
`packages/expect/src/__tests__/toThrowMatchers.test.ts`	Adds unit tests covering cross-realm pass/fail cases.
`packages/expect/src/__tests__/__snapshots__/toThrowMatchers.test.ts.snap`	Records expected snapshot output for the new failing cross-realm case.
`e2e/jest-assertion-error-cross-realm/package.json`	Defines the fixture package config for the new e2e scenario.
`e2e/jest-assertion-error-cross-realm/__tests__/index.test.js`	Reproduces the real-world separate-registry `JestAssertionError` case.
`e2e/__tests__/jestAssertionErrorCrossRealm.test.ts`	Verifies the new e2e fixture exits successfully.
`CHANGELOG.md`	Documents the cross-realm `toThrow(SomeClass)` fix.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

| datasource | package | from | to | | ---------- | ------- | ------ | ------ | | npm | jest | 30.3.0 | 30.4.0 | ## [v30.4.0](https://github.com/jestjs/jest/blob/HEAD/CHANGELOG.md#3040) ##### Features - `[babel-jest]` Support collecting coverage from `.mts`, `.cts` (and other) files ([#15994](jestjs/jest#15994)) - `[jest-circus, jest-cli, jest-config, jest-core, jest-jasmine2, jest-types]` Add `--collect-tests` flag to discover and list tests without executing them ([#16006](jestjs/jest#16006)) - `[jest-config, jest-runner, jest-worker]` Add `workerGracefulExitTimeout` config option to control how long workers are given to exit before being force-killed ([#15984](jestjs/jest#15984)) - `[jest-config]` Add support for `jest.config.mts` as a valid configuration file ([#16005](jestjs/jest#16005)) - `[jest-config, jest-core, jest-reporters, jest-runner]` `verbose` and `silent` can now be set per-project; the project-level value overrides the global value for that project's tests ([#16133](jestjs/jest#16133)) - `[@jest/fake-timers]` Accept `Temporal.Duration` in `jest.advanceTimersByTime()` and `jest.advanceTimersByTimeAsync()` ([#16128](jestjs/jest#16128)) - `[@jest/fake-timers]` Accept `Temporal.Instant` and `Temporal.ZonedDateTime` in `jest.setSystemTime()` and `useFakeTimers({now})` ([#16128](jestjs/jest#16128)) - `[@jest/fake-timers]` Support faking `Temporal.Now.*` ([#16131](jestjs/jest#16131)) - `[jest-mock]` Add `clearMocksOnScope(scope)` on `ModuleMocker` for clearing every mock function exposed on a scope object ([#16088](jestjs/jest#16088)) - `[jest-resolve]` Add `canResolveSync()` on `Resolver` so callers can detect when a user-configured resolver only exports an `async` hook ([#16064](jestjs/jest#16064)) - `[jest-runtime]` Use synchronous `evaluate()` for ES modules without top-level `await` on Node versions that support it (v24.9+), and prefer the synchronous transform path when a sync transformer is configured ([#16062](jestjs/jest#16062)) - `[jest-runtime]` Support `require()` of ES modules on Node v24.9+ ([#16074](jestjs/jest#16074)) - `[jest-runtime]` Validate TC39 import attributes (`with { type: 'json' }`) on ESM imports ([#16127](jestjs/jest#16127)) - `[@jest/transform]` Add `canTransformSync(filename)` on `ScriptTransformer` so callers can pick the sync vs async transform path ([#16062](jestjs/jest#16062)) - `[jest-util]` Add `isError` helper ([#16076](jestjs/jest#16076)) - `[pretty-format]` Support React 19 ([#16123](jestjs/jest#16123)) ##### Fixes - `[expect-utils]` Fix `toStrictEqual` failing on `structuredClone` results due to cross-realm constructor mismatch ([#15959](jestjs/jest#15959)) - `[@jest/expect-utils]` Prevent `toMatchObject`/subset matching from throwing when encountering exotic iterables ([#15952](jestjs/jest#15952)) - `[fake-timers]` Convert `Date` to milliseconds before passing to `@sinonjs/fake-timers` ([#16029](jestjs/jest#16029)) - `[jest]` Export `GlobalConfig` and `ProjectConfig` TypeScript types ([#16132](jestjs/jest#16132)) - `[jest-circus]` Prevent crash when `asyncError` is undefined for non-Error throws ([#16003](jestjs/jest#16003)) - `[jest-circus, jest-jasmine2]` Include `Error.cause` in JSON `failureMessages` output ([#15967](jestjs/jest#15967)) - `[jest-config]` Fix preset path resolution on Windows when the preset uses subpath `exports` ([#15961](jestjs/jest#15961)) - `[jest-config]` Allow `collectCoverage` and `coverageProvider` in project config without a validation warning ([#16132](jestjs/jest#16132)) - `[jest-config]` Project config validator now emits "is not supported in an individual project configuration" instead of "probably a typing mistake" for known global-only options ([#16132](jestjs/jest#16132)) - `[jest-environment-node]` Fix `--localstorage-file` warning on Node 25+ ([#16086](jestjs/jest#16086)) - `[jest-reporters]` Apply global coverage threshold to unmatched pattern files in addition to glob/path thresholds ([#16137](jestjs/jest#16137)) - `[jest-reporters, jest-runner, jest-runtime, jest-transform]` Fix coverage report not showing correct code coverage when using `projects` config option ([#16140](jestjs/jest#16140)) - `[jest-runtime]` Resolve `expect` and `@jest/expect` from the internal module registry so test-file imports share the same `JestAssertionError` as the global `expect` ([#16130](jestjs/jest#16130)) - `[jest-runtime]` Improve CJS-from-ESM interop: `__esModule`/Babel default unwrap, broader named-export coverage, and shared CJS singleton across importers ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Load `.js` files with ESM syntax but no `"type":"module"` marker as native ESM ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Extend the `.js`-with-ESM-syntax fallback to `require()` on Node v24.9+ - falls back to `require(esm)` when the CJS parser rejects ESM syntax ([#16078](jestjs/jest#16078)) - `[jest-runtime]` Fix deadlocks and double-evaluation in concurrent ESM and wasm imports ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Fix error when `require()` is called after the Jest environment has been torn down ([#15951](jestjs/jest#15951)) - `[jest-runtime]` Fix missing error when `import()` is called after the Jest environment has been torn down ([#16080](jestjs/jest#16080)) - `[jest-runtime]` Fix virtual `unstable_mockModule` registrations not respected in ESM ([#16081](jestjs/jest#16081)) - `[jest-runtime]` Apply `moduleNameMapper` when resolving modules with `require.resolve()` and the `paths` option ([#16135](jestjs/jest#16135)) ##### Chore & Maintenance - `[@jest/fake-timers]` Upgrade `@sinonjs/fake-timers` ([#16139](jestjs/jest#16139)) - `[jest-runtime]` Use synchronous `linkRequests` / `instantiate` for ESM linking on Node v24.9+ ([#16063](jestjs/jest#16063))

| datasource | package | from | to | | ---------- | ------- | ------ | ------ | | npm | jest | 30.3.0 | 30.4.2 | ## [v30.4.2](https://github.com/jestjs/jest/blob/HEAD/CHANGELOG.md#3042) ##### Fixes - `[jest-runtime]` Fix named imports from CJS modules whose `module.exports` is a function with own-property exports ([#16150](jestjs/jest#16150)) ## [v30.4.1](https://github.com/jestjs/jest/blob/HEAD/CHANGELOG.md#3041) ##### Features - `[jest-config, jest-core, jest-runner, jest-schemas, jest-types]` Allow custom runner configuration options via tuple format `['runner-path', {options}]` ([#16141](jestjs/jest#16141)) ##### Fixes - `[jest-runtime]` Align CJS-from-ESM default export with Node: `module.exports` is always the ESM default, `__esModule` unwrapping is no longer applied ([#16143](jestjs/jest#16143)) ## [v30.4.0](https://github.com/jestjs/jest/blob/HEAD/CHANGELOG.md#3040) ##### Features - `[babel-jest]` Support collecting coverage from `.mts`, `.cts` (and other) files ([#15994](jestjs/jest#15994)) - `[jest-circus, jest-cli, jest-config, jest-core, jest-jasmine2, jest-types]` Add `--collect-tests` flag to discover and list tests without executing them ([#16006](jestjs/jest#16006)) - `[jest-config, jest-runner, jest-worker]` Add `workerGracefulExitTimeout` config option to control how long workers are given to exit before being force-killed ([#15984](jestjs/jest#15984)) - `[jest-config]` Add support for `jest.config.mts` as a valid configuration file ([#16005](jestjs/jest#16005)) - `[jest-config, jest-core, jest-reporters, jest-runner]` `verbose` and `silent` can now be set per-project; the project-level value overrides the global value for that project's tests ([#16133](jestjs/jest#16133)) - `[@jest/fake-timers]` Accept `Temporal.Duration` in `jest.advanceTimersByTime()` and `jest.advanceTimersByTimeAsync()` ([#16128](jestjs/jest#16128)) - `[@jest/fake-timers]` Accept `Temporal.Instant` and `Temporal.ZonedDateTime` in `jest.setSystemTime()` and `useFakeTimers({now})` ([#16128](jestjs/jest#16128)) - `[@jest/fake-timers]` Support faking `Temporal.Now.*` ([#16131](jestjs/jest#16131)) - `[jest-mock]` Add `clearMocksOnScope(scope)` on `ModuleMocker` for clearing every mock function exposed on a scope object ([#16088](jestjs/jest#16088)) - `[jest-resolve]` Add `canResolveSync()` on `Resolver` so callers can detect when a user-configured resolver only exports an `async` hook ([#16064](jestjs/jest#16064)) - `[jest-runtime]` Use synchronous `evaluate()` for ES modules without top-level `await` on Node versions that support it (v24.9+), and prefer the synchronous transform path when a sync transformer is configured ([#16062](jestjs/jest#16062)) - `[jest-runtime]` Support `require()` of ES modules on Node v24.9+ ([#16074](jestjs/jest#16074)) - `[jest-runtime]` Validate TC39 import attributes (`with { type: 'json' }`) on ESM imports ([#16127](jestjs/jest#16127)) - `[@jest/transform]` Add `canTransformSync(filename)` on `ScriptTransformer` so callers can pick the sync vs async transform path ([#16062](jestjs/jest#16062)) - `[jest-util]` Add `isError` helper ([#16076](jestjs/jest#16076)) - `[pretty-format]` Support React 19 ([#16123](jestjs/jest#16123)) ##### Fixes - `[expect-utils]` Fix `toStrictEqual` failing on `structuredClone` results due to cross-realm constructor mismatch ([#15959](jestjs/jest#15959)) - `[@jest/expect-utils]` Prevent `toMatchObject`/subset matching from throwing when encountering exotic iterables ([#15952](jestjs/jest#15952)) - `[fake-timers]` Convert `Date` to milliseconds before passing to `@sinonjs/fake-timers` ([#16029](jestjs/jest#16029)) - `[jest]` Export `GlobalConfig` and `ProjectConfig` TypeScript types ([#16132](jestjs/jest#16132)) - `[jest-circus]` Prevent crash when `asyncError` is undefined for non-Error throws ([#16003](jestjs/jest#16003)) - `[jest-circus, jest-jasmine2]` Include `Error.cause` in JSON `failureMessages` output ([#15967](jestjs/jest#15967)) - `[jest-config]` Fix preset path resolution on Windows when the preset uses subpath `exports` ([#15961](jestjs/jest#15961)) - `[jest-config]` Allow `collectCoverage` and `coverageProvider` in project config without a validation warning ([#16132](jestjs/jest#16132)) - `[jest-config]` Project config validator now emits "is not supported in an individual project configuration" instead of "probably a typing mistake" for known global-only options ([#16132](jestjs/jest#16132)) - `[jest-environment-node]` Fix `--localstorage-file` warning on Node 25+ ([#16086](jestjs/jest#16086)) - `[jest-reporters]` Apply global coverage threshold to unmatched pattern files in addition to glob/path thresholds ([#16137](jestjs/jest#16137)) - `[jest-reporters, jest-runner, jest-runtime, jest-transform]` Fix coverage report not showing correct code coverage when using `projects` config option ([#16140](jestjs/jest#16140)) - `[jest-runtime]` Resolve `expect` and `@jest/expect` from the internal module registry so test-file imports share the same `JestAssertionError` as the global `expect` ([#16130](jestjs/jest#16130)) - `[jest-runtime]` Improve CJS-from-ESM interop: `__esModule`/Babel default unwrap, broader named-export coverage, and shared CJS singleton across importers ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Load `.js` files with ESM syntax but no `"type":"module"` marker as native ESM ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Extend the `.js`-with-ESM-syntax fallback to `require()` on Node v24.9+ - falls back to `require(esm)` when the CJS parser rejects ESM syntax ([#16078](jestjs/jest#16078)) - `[jest-runtime]` Fix deadlocks and double-evaluation in concurrent ESM and wasm imports ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Fix error when `require()` is called after the Jest environment has been torn down ([#15951](jestjs/jest#15951)) - `[jest-runtime]` Fix missing error when `import()` is called after the Jest environment has been torn down ([#16080](jestjs/jest#16080)) - `[jest-runtime]` Fix virtual `unstable_mockModule` registrations not respected in ESM ([#16081](jestjs/jest#16081)) - `[jest-runtime]` Apply `moduleNameMapper` when resolving modules with `require.resolve()` and the `paths` option ([#16135](jestjs/jest#16135)) ##### Chore & Maintenance - `[@jest/fake-timers]` Upgrade `@sinonjs/fake-timers` ([#16139](jestjs/jest#16139)) - `[jest-runtime]` Use synchronous `linkRequests` / `instantiate` for ESM linking on Node v24.9+ ([#16063](jestjs/jest#16063))

Copilot AI review requested due to automatic review settings May 5, 2026 21:47

fix: handle Errors from different realms in toThrowError

75eeeb3

SimenB force-pushed the jest-assertion-error-crash branch from 444d50e to 75eeeb3 Compare May 5, 2026 21:47

Copilot AI reviewed May 5, 2026

View reviewed changes

Comment thread packages/expect/src/toThrowMatchers.ts Outdated

review

d3328b4

SimenB requested a review from Copilot May 5, 2026 22:33

Copilot started reviewing on behalf of SimenB May 5, 2026 22:35 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

Comment thread packages/expect/src/toThrowMatchers.ts Outdated

apply real fix

ae8862c

SimenB requested a review from Copilot May 6, 2026 06:57

Copilot started reviewing on behalf of SimenB May 6, 2026 06:57 View session

extra test

95edbb5

SimenB force-pushed the jest-assertion-error-crash branch from a0d3619 to 95edbb5 Compare May 6, 2026 07:02

Copilot AI reviewed May 6, 2026

View reviewed changes

Comment thread packages/jest-runtime/src/__tests__/runtime_require_module_or_mock.test.js Outdated

Comment thread packages/expect/src/__tests__/__snapshots__/toThrowMatchers.test.ts.snap Outdated

SimenB added 2 commits May 6, 2026 09:04

oops

98aa9b8

test cover both modules

9cb44ff

SimenB requested a review from Copilot May 6, 2026 07:05

Copilot started reviewing on behalf of SimenB May 6, 2026 07:06 View session

re-org tests

24388a8

Copilot AI reviewed May 6, 2026

View reviewed changes

SimenB changed the title ~~fix: handle Errors from different realms in toThrowError~~ fix(runtime): resolve expect and @jest/expect from the internal module registry May 6, 2026

SimenB merged commit 9664ba1 into jestjs:main May 6, 2026
90 checks passed

SimenB deleted the jest-assertion-error-crash branch May 6, 2026 07:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(runtime): resolve `expect` and `@jest/expect` from the internal module registry#16130

fix(runtime): resolve `expect` and `@jest/expect` from the internal module registry#16130
SimenB merged 7 commits into
jestjs:mainfrom
SimenB:jest-assertion-error-crash

SimenB commented May 5, 2026

Uh oh!

netlify Bot commented May 5, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented May 5, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

SimenB commented May 5, 2026

Summary

Test plan

Uh oh!

netlify Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for jestjs ready!

Uh oh!

pkg-pr-new Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify Bot commented May 5, 2026 •

edited

Loading

pkg-pr-new Bot commented May 5, 2026 •

edited

Loading