Codestin Search App

SimenB · 2026-05-01T21:27:21Z

Summary

#15951 made me realize we don't have the same error for import as require.

Needed another boolean, so refactored to a state union

Test plan

Tests added.

netlify · 2026-05-01T21:27:27Z

✅ Deploy Preview for jestjs ready!

Name	Link
🔨 Latest commit	`1627adf`
🔍 Latest deploy log	https://app.netlify.com/projects/jestjs/deploys/69f5af33678d980007785420
😎 Deploy Preview	https://deploy-preview-16080--jestjs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

pkg-pr-new · 2026-05-01T21:33:16Z

Open in StackBlitz

babel-jest

npm i https://pkg.pr.new/babel-jest@16080

babel-plugin-jest-hoist

npm i https://pkg.pr.new/babel-plugin-jest-hoist@16080

babel-preset-jest

npm i https://pkg.pr.new/babel-preset-jest@16080

create-jest

npm i https://pkg.pr.new/create-jest@16080

@jest/diff-sequences

npm i https://pkg.pr.new/@jest/diff-sequences@16080

expect

npm i https://pkg.pr.new/expect@16080

@jest/expect-utils

npm i https://pkg.pr.new/@jest/expect-utils@16080

jest

npm i https://pkg.pr.new/jest@16080

jest-changed-files

npm i https://pkg.pr.new/jest-changed-files@16080

jest-circus

npm i https://pkg.pr.new/jest-circus@16080

jest-cli

npm i https://pkg.pr.new/jest-cli@16080

jest-config

npm i https://pkg.pr.new/jest-config@16080

@jest/console

npm i https://pkg.pr.new/@jest/console@16080

@jest/core

npm i https://pkg.pr.new/@jest/core@16080

@jest/create-cache-key-function

npm i https://pkg.pr.new/@jest/create-cache-key-function@16080

jest-diff

npm i https://pkg.pr.new/jest-diff@16080

jest-docblock

npm i https://pkg.pr.new/jest-docblock@16080

jest-each

npm i https://pkg.pr.new/jest-each@16080

@jest/environment

npm i https://pkg.pr.new/@jest/environment@16080

jest-environment-jsdom

npm i https://pkg.pr.new/jest-environment-jsdom@16080

@jest/environment-jsdom-abstract

npm i https://pkg.pr.new/@jest/environment-jsdom-abstract@16080

jest-environment-node

npm i https://pkg.pr.new/jest-environment-node@16080

@jest/expect

npm i https://pkg.pr.new/@jest/expect@16080

@jest/fake-timers

npm i https://pkg.pr.new/@jest/fake-timers@16080

@jest/get-type

npm i https://pkg.pr.new/@jest/get-type@16080

@jest/globals

npm i https://pkg.pr.new/@jest/globals@16080

jest-haste-map

npm i https://pkg.pr.new/jest-haste-map@16080

jest-jasmine2

npm i https://pkg.pr.new/jest-jasmine2@16080

jest-leak-detector

npm i https://pkg.pr.new/jest-leak-detector@16080

jest-matcher-utils

npm i https://pkg.pr.new/jest-matcher-utils@16080

jest-message-util

npm i https://pkg.pr.new/jest-message-util@16080

jest-mock

npm i https://pkg.pr.new/jest-mock@16080

@jest/pattern

npm i https://pkg.pr.new/@jest/pattern@16080

jest-phabricator

npm i https://pkg.pr.new/jest-phabricator@16080

jest-regex-util

npm i https://pkg.pr.new/jest-regex-util@16080

@jest/reporters

npm i https://pkg.pr.new/@jest/reporters@16080

jest-resolve

npm i https://pkg.pr.new/jest-resolve@16080

jest-resolve-dependencies

npm i https://pkg.pr.new/jest-resolve-dependencies@16080

jest-runner

npm i https://pkg.pr.new/jest-runner@16080

jest-runtime

npm i https://pkg.pr.new/jest-runtime@16080

@jest/schemas

npm i https://pkg.pr.new/@jest/schemas@16080

jest-snapshot

npm i https://pkg.pr.new/jest-snapshot@16080

@jest/snapshot-utils

npm i https://pkg.pr.new/@jest/snapshot-utils@16080

@jest/source-map

npm i https://pkg.pr.new/@jest/source-map@16080

@jest/test-result

npm i https://pkg.pr.new/@jest/test-result@16080

@jest/test-sequencer

npm i https://pkg.pr.new/@jest/test-sequencer@16080

@jest/transform

npm i https://pkg.pr.new/@jest/transform@16080

@jest/types

npm i https://pkg.pr.new/@jest/types@16080

jest-util

npm i https://pkg.pr.new/jest-util@16080

jest-validate

npm i https://pkg.pr.new/jest-validate@16080

jest-watcher

npm i https://pkg.pr.new/jest-watcher@16080

jest-worker

npm i https://pkg.pr.new/jest-worker@16080

pretty-format

npm i https://pkg.pr.new/pretty-format@16080

commit: 1627adf

Copilot

Pull request overview

This PR aligns Jest Runtime’s post-teardown behavior for import() with the existing require() handling, and adds an e2e fixture to snapshot the resulting diagnostics.

Changes:

Refactors runtime teardown / in-test tracking into a testState union and applies it across import/require entry points.
Adds a new e2e fixture (e2e/import-after-teardown) that triggers a late dynamic import() after test completion.
Adds an e2e test + snapshot coverage for both --waitForUnhandledRejections modes, plus a new snapshot normalization helper for Node version strings.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
packages/jest-runtime/src/index.ts	Introduces `testState` and adds guards for dynamic `import()`/`require()` based on teardown/test execution state.
e2e/import-after-teardown/package.json	Adds an e2e fixture config for the new import-after-teardown scenario.
e2e/import-after-teardown/double.mjs	Simple ESM module used by the fixture’s late import.
e2e/import-after-teardown/tests/lateImport.test.mjs	Fixture test that triggers a dynamic `import()` inside a timer after the test completes.
e2e/tests/importAfterTeardown.test.ts	Adds e2e assertions + snapshots for the late-import error output in both modes.
e2e/tests/snapshots/importAfterTeardown.test.ts.snap	Captures expected stderr output for the new e2e coverage.
e2e/Utils.ts	Adds `replaceNodeVersion` helper to normalize Node version strings in snapshots.

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

+const repoRoot = path.resolve(__dirname, '..');
+
+export const replaceRepoRoot = (str: string) =>
+  str.replaceAll(repoRoot, '<<REPO_ROOT>>');


SimenB · 2026-05-07T19:13:23Z

https://github.com/jestjs/jest/releases/tag/v30.4.0

| datasource | package | from | to | | ---------- | ------- | ------ | ------ | | npm | jest | 30.3.0 | 30.4.0 | ## [v30.4.0](https://github.com/jestjs/jest/blob/HEAD/CHANGELOG.md#3040) ##### Features - `[babel-jest]` Support collecting coverage from `.mts`, `.cts` (and other) files ([#15994](jestjs/jest#15994)) - `[jest-circus, jest-cli, jest-config, jest-core, jest-jasmine2, jest-types]` Add `--collect-tests` flag to discover and list tests without executing them ([#16006](jestjs/jest#16006)) - `[jest-config, jest-runner, jest-worker]` Add `workerGracefulExitTimeout` config option to control how long workers are given to exit before being force-killed ([#15984](jestjs/jest#15984)) - `[jest-config]` Add support for `jest.config.mts` as a valid configuration file ([#16005](jestjs/jest#16005)) - `[jest-config, jest-core, jest-reporters, jest-runner]` `verbose` and `silent` can now be set per-project; the project-level value overrides the global value for that project's tests ([#16133](jestjs/jest#16133)) - `[@jest/fake-timers]` Accept `Temporal.Duration` in `jest.advanceTimersByTime()` and `jest.advanceTimersByTimeAsync()` ([#16128](jestjs/jest#16128)) - `[@jest/fake-timers]` Accept `Temporal.Instant` and `Temporal.ZonedDateTime` in `jest.setSystemTime()` and `useFakeTimers({now})` ([#16128](jestjs/jest#16128)) - `[@jest/fake-timers]` Support faking `Temporal.Now.*` ([#16131](jestjs/jest#16131)) - `[jest-mock]` Add `clearMocksOnScope(scope)` on `ModuleMocker` for clearing every mock function exposed on a scope object ([#16088](jestjs/jest#16088)) - `[jest-resolve]` Add `canResolveSync()` on `Resolver` so callers can detect when a user-configured resolver only exports an `async` hook ([#16064](jestjs/jest#16064)) - `[jest-runtime]` Use synchronous `evaluate()` for ES modules without top-level `await` on Node versions that support it (v24.9+), and prefer the synchronous transform path when a sync transformer is configured ([#16062](jestjs/jest#16062)) - `[jest-runtime]` Support `require()` of ES modules on Node v24.9+ ([#16074](jestjs/jest#16074)) - `[jest-runtime]` Validate TC39 import attributes (`with { type: 'json' }`) on ESM imports ([#16127](jestjs/jest#16127)) - `[@jest/transform]` Add `canTransformSync(filename)` on `ScriptTransformer` so callers can pick the sync vs async transform path ([#16062](jestjs/jest#16062)) - `[jest-util]` Add `isError` helper ([#16076](jestjs/jest#16076)) - `[pretty-format]` Support React 19 ([#16123](jestjs/jest#16123)) ##### Fixes - `[expect-utils]` Fix `toStrictEqual` failing on `structuredClone` results due to cross-realm constructor mismatch ([#15959](jestjs/jest#15959)) - `[@jest/expect-utils]` Prevent `toMatchObject`/subset matching from throwing when encountering exotic iterables ([#15952](jestjs/jest#15952)) - `[fake-timers]` Convert `Date` to milliseconds before passing to `@sinonjs/fake-timers` ([#16029](jestjs/jest#16029)) - `[jest]` Export `GlobalConfig` and `ProjectConfig` TypeScript types ([#16132](jestjs/jest#16132)) - `[jest-circus]` Prevent crash when `asyncError` is undefined for non-Error throws ([#16003](jestjs/jest#16003)) - `[jest-circus, jest-jasmine2]` Include `Error.cause` in JSON `failureMessages` output ([#15967](jestjs/jest#15967)) - `[jest-config]` Fix preset path resolution on Windows when the preset uses subpath `exports` ([#15961](jestjs/jest#15961)) - `[jest-config]` Allow `collectCoverage` and `coverageProvider` in project config without a validation warning ([#16132](jestjs/jest#16132)) - `[jest-config]` Project config validator now emits "is not supported in an individual project configuration" instead of "probably a typing mistake" for known global-only options ([#16132](jestjs/jest#16132)) - `[jest-environment-node]` Fix `--localstorage-file` warning on Node 25+ ([#16086](jestjs/jest#16086)) - `[jest-reporters]` Apply global coverage threshold to unmatched pattern files in addition to glob/path thresholds ([#16137](jestjs/jest#16137)) - `[jest-reporters, jest-runner, jest-runtime, jest-transform]` Fix coverage report not showing correct code coverage when using `projects` config option ([#16140](jestjs/jest#16140)) - `[jest-runtime]` Resolve `expect` and `@jest/expect` from the internal module registry so test-file imports share the same `JestAssertionError` as the global `expect` ([#16130](jestjs/jest#16130)) - `[jest-runtime]` Improve CJS-from-ESM interop: `__esModule`/Babel default unwrap, broader named-export coverage, and shared CJS singleton across importers ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Load `.js` files with ESM syntax but no `"type":"module"` marker as native ESM ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Extend the `.js`-with-ESM-syntax fallback to `require()` on Node v24.9+ - falls back to `require(esm)` when the CJS parser rejects ESM syntax ([#16078](jestjs/jest#16078)) - `[jest-runtime]` Fix deadlocks and double-evaluation in concurrent ESM and wasm imports ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Fix error when `require()` is called after the Jest environment has been torn down ([#15951](jestjs/jest#15951)) - `[jest-runtime]` Fix missing error when `import()` is called after the Jest environment has been torn down ([#16080](jestjs/jest#16080)) - `[jest-runtime]` Fix virtual `unstable_mockModule` registrations not respected in ESM ([#16081](jestjs/jest#16081)) - `[jest-runtime]` Apply `moduleNameMapper` when resolving modules with `require.resolve()` and the `paths` option ([#16135](jestjs/jest#16135)) ##### Chore & Maintenance - `[@jest/fake-timers]` Upgrade `@sinonjs/fake-timers` ([#16139](jestjs/jest#16139)) - `[jest-runtime]` Use synchronous `linkRequests` / `instantiate` for ESM linking on Node v24.9+ ([#16063](jestjs/jest#16063))

| datasource | package | from | to | | ---------- | ------- | ------ | ------ | | npm | jest | 30.3.0 | 30.4.2 | ## [v30.4.2](https://github.com/jestjs/jest/blob/HEAD/CHANGELOG.md#3042) ##### Fixes - `[jest-runtime]` Fix named imports from CJS modules whose `module.exports` is a function with own-property exports ([#16150](jestjs/jest#16150)) ## [v30.4.1](https://github.com/jestjs/jest/blob/HEAD/CHANGELOG.md#3041) ##### Features - `[jest-config, jest-core, jest-runner, jest-schemas, jest-types]` Allow custom runner configuration options via tuple format `['runner-path', {options}]` ([#16141](jestjs/jest#16141)) ##### Fixes - `[jest-runtime]` Align CJS-from-ESM default export with Node: `module.exports` is always the ESM default, `__esModule` unwrapping is no longer applied ([#16143](jestjs/jest#16143)) ## [v30.4.0](https://github.com/jestjs/jest/blob/HEAD/CHANGELOG.md#3040) ##### Features - `[babel-jest]` Support collecting coverage from `.mts`, `.cts` (and other) files ([#15994](jestjs/jest#15994)) - `[jest-circus, jest-cli, jest-config, jest-core, jest-jasmine2, jest-types]` Add `--collect-tests` flag to discover and list tests without executing them ([#16006](jestjs/jest#16006)) - `[jest-config, jest-runner, jest-worker]` Add `workerGracefulExitTimeout` config option to control how long workers are given to exit before being force-killed ([#15984](jestjs/jest#15984)) - `[jest-config]` Add support for `jest.config.mts` as a valid configuration file ([#16005](jestjs/jest#16005)) - `[jest-config, jest-core, jest-reporters, jest-runner]` `verbose` and `silent` can now be set per-project; the project-level value overrides the global value for that project's tests ([#16133](jestjs/jest#16133)) - `[@jest/fake-timers]` Accept `Temporal.Duration` in `jest.advanceTimersByTime()` and `jest.advanceTimersByTimeAsync()` ([#16128](jestjs/jest#16128)) - `[@jest/fake-timers]` Accept `Temporal.Instant` and `Temporal.ZonedDateTime` in `jest.setSystemTime()` and `useFakeTimers({now})` ([#16128](jestjs/jest#16128)) - `[@jest/fake-timers]` Support faking `Temporal.Now.*` ([#16131](jestjs/jest#16131)) - `[jest-mock]` Add `clearMocksOnScope(scope)` on `ModuleMocker` for clearing every mock function exposed on a scope object ([#16088](jestjs/jest#16088)) - `[jest-resolve]` Add `canResolveSync()` on `Resolver` so callers can detect when a user-configured resolver only exports an `async` hook ([#16064](jestjs/jest#16064)) - `[jest-runtime]` Use synchronous `evaluate()` for ES modules without top-level `await` on Node versions that support it (v24.9+), and prefer the synchronous transform path when a sync transformer is configured ([#16062](jestjs/jest#16062)) - `[jest-runtime]` Support `require()` of ES modules on Node v24.9+ ([#16074](jestjs/jest#16074)) - `[jest-runtime]` Validate TC39 import attributes (`with { type: 'json' }`) on ESM imports ([#16127](jestjs/jest#16127)) - `[@jest/transform]` Add `canTransformSync(filename)` on `ScriptTransformer` so callers can pick the sync vs async transform path ([#16062](jestjs/jest#16062)) - `[jest-util]` Add `isError` helper ([#16076](jestjs/jest#16076)) - `[pretty-format]` Support React 19 ([#16123](jestjs/jest#16123)) ##### Fixes - `[expect-utils]` Fix `toStrictEqual` failing on `structuredClone` results due to cross-realm constructor mismatch ([#15959](jestjs/jest#15959)) - `[@jest/expect-utils]` Prevent `toMatchObject`/subset matching from throwing when encountering exotic iterables ([#15952](jestjs/jest#15952)) - `[fake-timers]` Convert `Date` to milliseconds before passing to `@sinonjs/fake-timers` ([#16029](jestjs/jest#16029)) - `[jest]` Export `GlobalConfig` and `ProjectConfig` TypeScript types ([#16132](jestjs/jest#16132)) - `[jest-circus]` Prevent crash when `asyncError` is undefined for non-Error throws ([#16003](jestjs/jest#16003)) - `[jest-circus, jest-jasmine2]` Include `Error.cause` in JSON `failureMessages` output ([#15967](jestjs/jest#15967)) - `[jest-config]` Fix preset path resolution on Windows when the preset uses subpath `exports` ([#15961](jestjs/jest#15961)) - `[jest-config]` Allow `collectCoverage` and `coverageProvider` in project config without a validation warning ([#16132](jestjs/jest#16132)) - `[jest-config]` Project config validator now emits "is not supported in an individual project configuration" instead of "probably a typing mistake" for known global-only options ([#16132](jestjs/jest#16132)) - `[jest-environment-node]` Fix `--localstorage-file` warning on Node 25+ ([#16086](jestjs/jest#16086)) - `[jest-reporters]` Apply global coverage threshold to unmatched pattern files in addition to glob/path thresholds ([#16137](jestjs/jest#16137)) - `[jest-reporters, jest-runner, jest-runtime, jest-transform]` Fix coverage report not showing correct code coverage when using `projects` config option ([#16140](jestjs/jest#16140)) - `[jest-runtime]` Resolve `expect` and `@jest/expect` from the internal module registry so test-file imports share the same `JestAssertionError` as the global `expect` ([#16130](jestjs/jest#16130)) - `[jest-runtime]` Improve CJS-from-ESM interop: `__esModule`/Babel default unwrap, broader named-export coverage, and shared CJS singleton across importers ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Load `.js` files with ESM syntax but no `"type":"module"` marker as native ESM ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Extend the `.js`-with-ESM-syntax fallback to `require()` on Node v24.9+ - falls back to `require(esm)` when the CJS parser rejects ESM syntax ([#16078](jestjs/jest#16078)) - `[jest-runtime]` Fix deadlocks and double-evaluation in concurrent ESM and wasm imports ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Fix error when `require()` is called after the Jest environment has been torn down ([#15951](jestjs/jest#15951)) - `[jest-runtime]` Fix missing error when `import()` is called after the Jest environment has been torn down ([#16080](jestjs/jest#16080)) - `[jest-runtime]` Fix virtual `unstable_mockModule` registrations not respected in ESM ([#16081](jestjs/jest#16081)) - `[jest-runtime]` Apply `moduleNameMapper` when resolving modules with `require.resolve()` and the `paths` option ([#16135](jestjs/jest#16135)) ##### Chore & Maintenance - `[@jest/fake-timers]` Upgrade `@sinonjs/fake-timers` ([#16139](jestjs/jest#16139)) - `[jest-runtime]` Use synchronous `linkRequests` / `instantiate` for ESM linking on Node v24.9+ ([#16063](jestjs/jest#16063))

fix: handle imports after teardown same as require

391f6fa

Copilot AI review requested due to automatic review settings May 1, 2026 21:27

Copilot started reviewing on behalf of SimenB May 1, 2026 21:29 View session

clean other snaps

89b3838

Copilot AI reviewed May 1, 2026

View reviewed changes

Comment thread packages/jest-runtime/src/index.ts Outdated

Comment thread packages/jest-runtime/src/index.ts Outdated

SimenB added 3 commits May 1, 2026 23:49

more replacements

6dde8e1

changelog

e1a3213

tweak error

27d4aa1

SimenB requested a review from Copilot May 1, 2026 21:53

Copilot started reviewing on behalf of SimenB May 1, 2026 21:54 View session

Copilot AI reviewed May 1, 2026

View reviewed changes

SimenB added 4 commits May 2, 2026 00:15

review comments

5f96b7c

Merge branch 'main' into import-after-teardown

8822439

prettier

caacaa5

maybe windows

1627adf

SimenB merged commit 71926d1 into jestjs:main May 2, 2026
72 of 75 checks passed

SimenB deleted the import-after-teardown branch May 2, 2026 08:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: handle `import`s after teardown same as `require`#16080

fix: handle `import`s after teardown same as `require`#16080
SimenB merged 9 commits into
jestjs:mainfrom
SimenB:import-after-teardown

SimenB commented May 1, 2026

Uh oh!

netlify Bot commented May 1, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented May 1, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SimenB commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

SimenB commented May 1, 2026

Summary

Test plan

Uh oh!

netlify Bot commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for jestjs ready!

Uh oh!

pkg-pr-new Bot commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SimenB commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify Bot commented May 1, 2026 •

edited

Loading

pkg-pr-new Bot commented May 1, 2026 •

edited

Loading