Codestin Search App

SimenB · 2026-05-05T14:22:27Z

Summary

Not actually asserting/throwing, just printing a warning. Will start to throw in Jest 31

Test plan

Tests added

netlify · 2026-05-05T14:22:34Z

✅ Deploy Preview for jestjs ready!

Name	Link
🔨 Latest commit	`fb1b759`
🔍 Latest deploy log	https://app.netlify.com/projects/jestjs/deploys/69fa16c6fc367a000830de6e
😎 Deploy Preview	https://deploy-preview-16127--jestjs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull request overview

This PR adds runtime-level validation for TC39 import attributes on ESM imports (notably JSON modules), including a deprecation warning when importing JSON without with {type: 'json'} (planned to become a hard error in the next major). It threads import-attributes metadata through Jest’s VM dynamic import plumbing and adds unit + e2e coverage across Node versions (legacy assert vs modern with syntax).

Changes:

Plumb importAttributes through vm.compileFunction(... importModuleDynamically ...) → Runtime → EsmLoader.dynamicImportFromCjs.
Introduce validateImportAttributes() in EsmLoader and enforce it for sync-graph linking, async linker callbacks, and dynamic imports; warn (deduped) on missing JSON attributes for now.
Add unit tests for the validator and e2e fixtures/tests for with {type:'json'} (Node >= 22) plus mismatch cases; update snapshots and changelog.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
packages/jest-runtime/src/internals/ModuleExecutor.ts	Passes VM dynamic import attributes through to Jest’s dynamic import hook.
packages/jest-runtime/src/internals/EsmLoader.ts	Implements and applies import-attribute validation across ESM load/link paths, plus deprecation warning behavior.
packages/jest-runtime/src/internals/tests/EsmLoader.test.ts	Adds unit tests for `validateImportAttributes` behavior and warning dedupe.
packages/jest-runtime/src/index.ts	Wires the new `importAttributes` parameter through `Runtime`’s `ModuleExecutor` setup.
e2e/native-esm/tests/native-esm-missing-import-assertions.test.js	Documents fixture intent: JSON without attributes still works but should warn.
e2e/native-esm/tests/native-esm-import-attributes.test.js	New fixture for `with {type:'json'}` static + dynamic JSON imports.
e2e/native-esm/tests/native-esm-import-attribute-mismatch.test.js	New fixture asserting runtime errors for unsupported/mismatched attributes.
e2e/tests/nativeEsm.test.ts	Updates e2e dispatcher to assert the new warning and add Node>=22 import-attributes coverage.
e2e/tests/snapshots/nativeEsm.test.ts.snap	Updates snapshots for renamed/added e2e tests.
CHANGELOG.md	Adds a `jest-runtime` changelog entry for import-attributes validation.

pkg-pr-new · 2026-05-05T15:07:44Z

Open in StackBlitz

babel-jest

npm i https://pkg.pr.new/babel-jest@16127

babel-plugin-jest-hoist

npm i https://pkg.pr.new/babel-plugin-jest-hoist@16127

babel-preset-jest

npm i https://pkg.pr.new/babel-preset-jest@16127

create-jest

npm i https://pkg.pr.new/create-jest@16127

@jest/diff-sequences

npm i https://pkg.pr.new/@jest/diff-sequences@16127

expect

npm i https://pkg.pr.new/expect@16127

@jest/expect-utils

npm i https://pkg.pr.new/@jest/expect-utils@16127

jest

npm i https://pkg.pr.new/jest@16127

jest-changed-files

npm i https://pkg.pr.new/jest-changed-files@16127

jest-circus

npm i https://pkg.pr.new/jest-circus@16127

jest-cli

npm i https://pkg.pr.new/jest-cli@16127

jest-config

npm i https://pkg.pr.new/jest-config@16127

@jest/console

npm i https://pkg.pr.new/@jest/console@16127

@jest/core

npm i https://pkg.pr.new/@jest/core@16127

@jest/create-cache-key-function

npm i https://pkg.pr.new/@jest/create-cache-key-function@16127

jest-diff

npm i https://pkg.pr.new/jest-diff@16127

jest-docblock

npm i https://pkg.pr.new/jest-docblock@16127

jest-each

npm i https://pkg.pr.new/jest-each@16127

@jest/environment

npm i https://pkg.pr.new/@jest/environment@16127

jest-environment-jsdom

npm i https://pkg.pr.new/jest-environment-jsdom@16127

@jest/environment-jsdom-abstract

npm i https://pkg.pr.new/@jest/environment-jsdom-abstract@16127

jest-environment-node

npm i https://pkg.pr.new/jest-environment-node@16127

@jest/expect

npm i https://pkg.pr.new/@jest/expect@16127

@jest/fake-timers

npm i https://pkg.pr.new/@jest/fake-timers@16127

@jest/get-type

npm i https://pkg.pr.new/@jest/get-type@16127

@jest/globals

npm i https://pkg.pr.new/@jest/globals@16127

jest-haste-map

npm i https://pkg.pr.new/jest-haste-map@16127

jest-jasmine2

npm i https://pkg.pr.new/jest-jasmine2@16127

jest-leak-detector

npm i https://pkg.pr.new/jest-leak-detector@16127

jest-matcher-utils

npm i https://pkg.pr.new/jest-matcher-utils@16127

jest-message-util

npm i https://pkg.pr.new/jest-message-util@16127

jest-mock

npm i https://pkg.pr.new/jest-mock@16127

@jest/pattern

npm i https://pkg.pr.new/@jest/pattern@16127

jest-phabricator

npm i https://pkg.pr.new/jest-phabricator@16127

jest-regex-util

npm i https://pkg.pr.new/jest-regex-util@16127

@jest/reporters

npm i https://pkg.pr.new/@jest/reporters@16127

jest-resolve

npm i https://pkg.pr.new/jest-resolve@16127

jest-resolve-dependencies

npm i https://pkg.pr.new/jest-resolve-dependencies@16127

jest-runner

npm i https://pkg.pr.new/jest-runner@16127

jest-runtime

npm i https://pkg.pr.new/jest-runtime@16127

@jest/schemas

npm i https://pkg.pr.new/@jest/schemas@16127

jest-snapshot

npm i https://pkg.pr.new/jest-snapshot@16127

@jest/snapshot-utils

npm i https://pkg.pr.new/@jest/snapshot-utils@16127

@jest/source-map

npm i https://pkg.pr.new/@jest/source-map@16127

@jest/test-result

npm i https://pkg.pr.new/@jest/test-result@16127

@jest/test-sequencer

npm i https://pkg.pr.new/@jest/test-sequencer@16127

@jest/transform

npm i https://pkg.pr.new/@jest/transform@16127

@jest/types

npm i https://pkg.pr.new/@jest/types@16127

jest-util

npm i https://pkg.pr.new/jest-util@16127

jest-validate

npm i https://pkg.pr.new/jest-validate@16127

jest-watcher

npm i https://pkg.pr.new/jest-watcher@16127

jest-worker

npm i https://pkg.pr.new/jest-worker@16127

pretty-format

npm i https://pkg.pr.new/pretty-format@16127

commit: fb1b759

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

+      const dedupeKey = `${referencingIdentifier}::${modulePath}`;
+      if (!warnedMissingJsonAttributePairs.has(dedupeKey)) {
+        if (warnedMissingJsonAttributePairs.size >= MAX_WARNED_PAIRS) {
+          warnedMissingJsonAttributePairs.clear();
+        }
+        warnedMissingJsonAttributePairs.add(dedupeKey);
+        const moduleLabel = describeForWarning(modulePath);
+        console.warn(


+  for (const key of Object.keys(attributes)) {
+    if (key !== 'type') {
+      throw makeImportAttributeError(
+        'ERR_IMPORT_ATTRIBUTE_UNSUPPORTED',
+        `Import attribute "${key}" with value "${attributes[key]}" is not supported (importing "${modulePath}" from ${referencingIdentifier})`,
+      );


| datasource | package | from | to | | ---------- | ------- | ------ | ------ | | npm | jest | 30.3.0 | 30.4.0 | ## [v30.4.0](https://github.com/jestjs/jest/blob/HEAD/CHANGELOG.md#3040) ##### Features - `[babel-jest]` Support collecting coverage from `.mts`, `.cts` (and other) files ([#15994](jestjs/jest#15994)) - `[jest-circus, jest-cli, jest-config, jest-core, jest-jasmine2, jest-types]` Add `--collect-tests` flag to discover and list tests without executing them ([#16006](jestjs/jest#16006)) - `[jest-config, jest-runner, jest-worker]` Add `workerGracefulExitTimeout` config option to control how long workers are given to exit before being force-killed ([#15984](jestjs/jest#15984)) - `[jest-config]` Add support for `jest.config.mts` as a valid configuration file ([#16005](jestjs/jest#16005)) - `[jest-config, jest-core, jest-reporters, jest-runner]` `verbose` and `silent` can now be set per-project; the project-level value overrides the global value for that project's tests ([#16133](jestjs/jest#16133)) - `[@jest/fake-timers]` Accept `Temporal.Duration` in `jest.advanceTimersByTime()` and `jest.advanceTimersByTimeAsync()` ([#16128](jestjs/jest#16128)) - `[@jest/fake-timers]` Accept `Temporal.Instant` and `Temporal.ZonedDateTime` in `jest.setSystemTime()` and `useFakeTimers({now})` ([#16128](jestjs/jest#16128)) - `[@jest/fake-timers]` Support faking `Temporal.Now.*` ([#16131](jestjs/jest#16131)) - `[jest-mock]` Add `clearMocksOnScope(scope)` on `ModuleMocker` for clearing every mock function exposed on a scope object ([#16088](jestjs/jest#16088)) - `[jest-resolve]` Add `canResolveSync()` on `Resolver` so callers can detect when a user-configured resolver only exports an `async` hook ([#16064](jestjs/jest#16064)) - `[jest-runtime]` Use synchronous `evaluate()` for ES modules without top-level `await` on Node versions that support it (v24.9+), and prefer the synchronous transform path when a sync transformer is configured ([#16062](jestjs/jest#16062)) - `[jest-runtime]` Support `require()` of ES modules on Node v24.9+ ([#16074](jestjs/jest#16074)) - `[jest-runtime]` Validate TC39 import attributes (`with { type: 'json' }`) on ESM imports ([#16127](jestjs/jest#16127)) - `[@jest/transform]` Add `canTransformSync(filename)` on `ScriptTransformer` so callers can pick the sync vs async transform path ([#16062](jestjs/jest#16062)) - `[jest-util]` Add `isError` helper ([#16076](jestjs/jest#16076)) - `[pretty-format]` Support React 19 ([#16123](jestjs/jest#16123)) ##### Fixes - `[expect-utils]` Fix `toStrictEqual` failing on `structuredClone` results due to cross-realm constructor mismatch ([#15959](jestjs/jest#15959)) - `[@jest/expect-utils]` Prevent `toMatchObject`/subset matching from throwing when encountering exotic iterables ([#15952](jestjs/jest#15952)) - `[fake-timers]` Convert `Date` to milliseconds before passing to `@sinonjs/fake-timers` ([#16029](jestjs/jest#16029)) - `[jest]` Export `GlobalConfig` and `ProjectConfig` TypeScript types ([#16132](jestjs/jest#16132)) - `[jest-circus]` Prevent crash when `asyncError` is undefined for non-Error throws ([#16003](jestjs/jest#16003)) - `[jest-circus, jest-jasmine2]` Include `Error.cause` in JSON `failureMessages` output ([#15967](jestjs/jest#15967)) - `[jest-config]` Fix preset path resolution on Windows when the preset uses subpath `exports` ([#15961](jestjs/jest#15961)) - `[jest-config]` Allow `collectCoverage` and `coverageProvider` in project config without a validation warning ([#16132](jestjs/jest#16132)) - `[jest-config]` Project config validator now emits "is not supported in an individual project configuration" instead of "probably a typing mistake" for known global-only options ([#16132](jestjs/jest#16132)) - `[jest-environment-node]` Fix `--localstorage-file` warning on Node 25+ ([#16086](jestjs/jest#16086)) - `[jest-reporters]` Apply global coverage threshold to unmatched pattern files in addition to glob/path thresholds ([#16137](jestjs/jest#16137)) - `[jest-reporters, jest-runner, jest-runtime, jest-transform]` Fix coverage report not showing correct code coverage when using `projects` config option ([#16140](jestjs/jest#16140)) - `[jest-runtime]` Resolve `expect` and `@jest/expect` from the internal module registry so test-file imports share the same `JestAssertionError` as the global `expect` ([#16130](jestjs/jest#16130)) - `[jest-runtime]` Improve CJS-from-ESM interop: `__esModule`/Babel default unwrap, broader named-export coverage, and shared CJS singleton across importers ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Load `.js` files with ESM syntax but no `"type":"module"` marker as native ESM ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Extend the `.js`-with-ESM-syntax fallback to `require()` on Node v24.9+ - falls back to `require(esm)` when the CJS parser rejects ESM syntax ([#16078](jestjs/jest#16078)) - `[jest-runtime]` Fix deadlocks and double-evaluation in concurrent ESM and wasm imports ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Fix error when `require()` is called after the Jest environment has been torn down ([#15951](jestjs/jest#15951)) - `[jest-runtime]` Fix missing error when `import()` is called after the Jest environment has been torn down ([#16080](jestjs/jest#16080)) - `[jest-runtime]` Fix virtual `unstable_mockModule` registrations not respected in ESM ([#16081](jestjs/jest#16081)) - `[jest-runtime]` Apply `moduleNameMapper` when resolving modules with `require.resolve()` and the `paths` option ([#16135](jestjs/jest#16135)) ##### Chore & Maintenance - `[@jest/fake-timers]` Upgrade `@sinonjs/fake-timers` ([#16139](jestjs/jest#16139)) - `[jest-runtime]` Use synchronous `linkRequests` / `instantiate` for ESM linking on Node v24.9+ ([#16063](jestjs/jest#16063))

| datasource | package | from | to | | ---------- | ------- | ------ | ------ | | npm | jest | 30.3.0 | 30.4.2 | ## [v30.4.2](https://github.com/jestjs/jest/blob/HEAD/CHANGELOG.md#3042) ##### Fixes - `[jest-runtime]` Fix named imports from CJS modules whose `module.exports` is a function with own-property exports ([#16150](jestjs/jest#16150)) ## [v30.4.1](https://github.com/jestjs/jest/blob/HEAD/CHANGELOG.md#3041) ##### Features - `[jest-config, jest-core, jest-runner, jest-schemas, jest-types]` Allow custom runner configuration options via tuple format `['runner-path', {options}]` ([#16141](jestjs/jest#16141)) ##### Fixes - `[jest-runtime]` Align CJS-from-ESM default export with Node: `module.exports` is always the ESM default, `__esModule` unwrapping is no longer applied ([#16143](jestjs/jest#16143)) ## [v30.4.0](https://github.com/jestjs/jest/blob/HEAD/CHANGELOG.md#3040) ##### Features - `[babel-jest]` Support collecting coverage from `.mts`, `.cts` (and other) files ([#15994](jestjs/jest#15994)) - `[jest-circus, jest-cli, jest-config, jest-core, jest-jasmine2, jest-types]` Add `--collect-tests` flag to discover and list tests without executing them ([#16006](jestjs/jest#16006)) - `[jest-config, jest-runner, jest-worker]` Add `workerGracefulExitTimeout` config option to control how long workers are given to exit before being force-killed ([#15984](jestjs/jest#15984)) - `[jest-config]` Add support for `jest.config.mts` as a valid configuration file ([#16005](jestjs/jest#16005)) - `[jest-config, jest-core, jest-reporters, jest-runner]` `verbose` and `silent` can now be set per-project; the project-level value overrides the global value for that project's tests ([#16133](jestjs/jest#16133)) - `[@jest/fake-timers]` Accept `Temporal.Duration` in `jest.advanceTimersByTime()` and `jest.advanceTimersByTimeAsync()` ([#16128](jestjs/jest#16128)) - `[@jest/fake-timers]` Accept `Temporal.Instant` and `Temporal.ZonedDateTime` in `jest.setSystemTime()` and `useFakeTimers({now})` ([#16128](jestjs/jest#16128)) - `[@jest/fake-timers]` Support faking `Temporal.Now.*` ([#16131](jestjs/jest#16131)) - `[jest-mock]` Add `clearMocksOnScope(scope)` on `ModuleMocker` for clearing every mock function exposed on a scope object ([#16088](jestjs/jest#16088)) - `[jest-resolve]` Add `canResolveSync()` on `Resolver` so callers can detect when a user-configured resolver only exports an `async` hook ([#16064](jestjs/jest#16064)) - `[jest-runtime]` Use synchronous `evaluate()` for ES modules without top-level `await` on Node versions that support it (v24.9+), and prefer the synchronous transform path when a sync transformer is configured ([#16062](jestjs/jest#16062)) - `[jest-runtime]` Support `require()` of ES modules on Node v24.9+ ([#16074](jestjs/jest#16074)) - `[jest-runtime]` Validate TC39 import attributes (`with { type: 'json' }`) on ESM imports ([#16127](jestjs/jest#16127)) - `[@jest/transform]` Add `canTransformSync(filename)` on `ScriptTransformer` so callers can pick the sync vs async transform path ([#16062](jestjs/jest#16062)) - `[jest-util]` Add `isError` helper ([#16076](jestjs/jest#16076)) - `[pretty-format]` Support React 19 ([#16123](jestjs/jest#16123)) ##### Fixes - `[expect-utils]` Fix `toStrictEqual` failing on `structuredClone` results due to cross-realm constructor mismatch ([#15959](jestjs/jest#15959)) - `[@jest/expect-utils]` Prevent `toMatchObject`/subset matching from throwing when encountering exotic iterables ([#15952](jestjs/jest#15952)) - `[fake-timers]` Convert `Date` to milliseconds before passing to `@sinonjs/fake-timers` ([#16029](jestjs/jest#16029)) - `[jest]` Export `GlobalConfig` and `ProjectConfig` TypeScript types ([#16132](jestjs/jest#16132)) - `[jest-circus]` Prevent crash when `asyncError` is undefined for non-Error throws ([#16003](jestjs/jest#16003)) - `[jest-circus, jest-jasmine2]` Include `Error.cause` in JSON `failureMessages` output ([#15967](jestjs/jest#15967)) - `[jest-config]` Fix preset path resolution on Windows when the preset uses subpath `exports` ([#15961](jestjs/jest#15961)) - `[jest-config]` Allow `collectCoverage` and `coverageProvider` in project config without a validation warning ([#16132](jestjs/jest#16132)) - `[jest-config]` Project config validator now emits "is not supported in an individual project configuration" instead of "probably a typing mistake" for known global-only options ([#16132](jestjs/jest#16132)) - `[jest-environment-node]` Fix `--localstorage-file` warning on Node 25+ ([#16086](jestjs/jest#16086)) - `[jest-reporters]` Apply global coverage threshold to unmatched pattern files in addition to glob/path thresholds ([#16137](jestjs/jest#16137)) - `[jest-reporters, jest-runner, jest-runtime, jest-transform]` Fix coverage report not showing correct code coverage when using `projects` config option ([#16140](jestjs/jest#16140)) - `[jest-runtime]` Resolve `expect` and `@jest/expect` from the internal module registry so test-file imports share the same `JestAssertionError` as the global `expect` ([#16130](jestjs/jest#16130)) - `[jest-runtime]` Improve CJS-from-ESM interop: `__esModule`/Babel default unwrap, broader named-export coverage, and shared CJS singleton across importers ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Load `.js` files with ESM syntax but no `"type":"module"` marker as native ESM ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Extend the `.js`-with-ESM-syntax fallback to `require()` on Node v24.9+ - falls back to `require(esm)` when the CJS parser rejects ESM syntax ([#16078](jestjs/jest#16078)) - `[jest-runtime]` Fix deadlocks and double-evaluation in concurrent ESM and wasm imports ([#16050](jestjs/jest#16050)) - `[jest-runtime]` Fix error when `require()` is called after the Jest environment has been torn down ([#15951](jestjs/jest#15951)) - `[jest-runtime]` Fix missing error when `import()` is called after the Jest environment has been torn down ([#16080](jestjs/jest#16080)) - `[jest-runtime]` Fix virtual `unstable_mockModule` registrations not respected in ESM ([#16081](jestjs/jest#16081)) - `[jest-runtime]` Apply `moduleNameMapper` when resolving modules with `require.resolve()` and the `paths` option ([#16135](jestjs/jest#16135)) ##### Chore & Maintenance - `[@jest/fake-timers]` Upgrade `@sinonjs/fake-timers` ([#16139](jestjs/jest#16139)) - `[jest-runtime]` Use synchronous `linkRequests` / `instantiate` for ESM linking on Node v24.9+ ([#16063](jestjs/jest#16063))

feat: support import attributes

4356269

Copilot AI review requested due to automatic review settings May 5, 2026 14:22

changelog

214d596

Copilot started reviewing on behalf of SimenB May 5, 2026 14:25 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

Comment thread packages/jest-runtime/src/internals/EsmLoader.ts

Comment thread packages/jest-runtime/src/internals/EsmLoader.ts

SimenB added 3 commits May 5, 2026 16:42

Merge branch 'main' into import-attributes-15000

acc6620

fix placeholder link

4ab5e6a

review comments

72ccdd7

SimenB force-pushed the import-attributes-15000 branch from 2411acb to 72ccdd7 Compare May 5, 2026 15:01

SimenB requested a review from Copilot May 5, 2026 15:21

Copilot started reviewing on behalf of SimenB May 5, 2026 15:21 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

Comment thread packages/jest-runtime/src/internals/EsmLoader.ts

one more review comment

fb1b759

SimenB requested a review from Copilot May 5, 2026 16:11

Copilot started reviewing on behalf of SimenB May 5, 2026 16:13 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

SimenB merged commit 69a28ba into jestjs:main May 5, 2026
94 checks passed

SimenB deleted the import-attributes-15000 branch May 5, 2026 16:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: support import attributes#16127

feat: support import attributes#16127
SimenB merged 6 commits into
jestjs:mainfrom
SimenB:import-attributes-15000

SimenB commented May 5, 2026

Uh oh!

netlify Bot commented May 5, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

pkg-pr-new Bot commented May 5, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

SimenB commented May 5, 2026

Summary

Test plan

Uh oh!

netlify Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for jestjs ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

pkg-pr-new Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify Bot commented May 5, 2026 •

edited

Loading

pkg-pr-new Bot commented May 5, 2026 •

edited

Loading